Bug 1699586 - Rename default right arrow icon to arrow-right.svg for naming consistency with its other directions. Use it rather than flipping the left arrow. r=Itiel,desktop-theme-reviewers

Differential Revision: https://phabricator.services.mozilla.com/D118424

browser/themes/osx/places/organizer.css

@@ -96,10 +96,15 @@
 
 /* back and forward button */
 #back-button,
-#forward-button {
+#forward-button:-moz-locale-dir(rtl) {
   list-style-image: url("chrome://global/skin/icons/arrow-left.svg");
 }
 
+#forward-button,
+#back-button:-moz-locale-dir(rtl) {
+  list-style-image: url("chrome://global/skin/icons/arrow-right.svg");
+}
+
 #back-button {
   margin-inline-end: 0 !important; /* override margin from #placesToolbar > toolbarbutton */
 }
@@ -108,11 +113,6 @@
   margin-inline-start: 0 !important; /* override margin from #placesToolbar > toolbarbutton */
 }
 
-#back-button:-moz-locale-dir(rtl) > .toolbarbutton-icon,
-#forward-button:-moz-locale-dir(ltr) > .toolbarbutton-icon {
-  transform: scaleX(-1);
-}
-
 #back-button > .toolbarbutton-icon {
   margin-inline: 3px 2px !important;
 }

browser/themes/shared/customizableui/panelUI.inc.css

@@ -1401,7 +1401,7 @@ panelview .toolbarbutton-1,
 
 .subviewbutton > .menu-right {
   appearance: none;
-  list-style-image: url(chrome://global/skin/icons/menu-arrow.svg);
+  list-style-image: url(chrome://global/skin/icons/arrow-right.svg);
   -moz-context-properties: fill, fill-opacity;
   fill: currentColor;
   fill-opacity: 0.6;
@@ -1412,7 +1412,7 @@ panelview .toolbarbutton-1,
 }
 
 .subviewbutton > .menu-right:-moz-locale-dir(rtl) {
-  transform: scaleX(-1);
+  list-style-image: url(chrome://global/skin/icons/arrow-left.svg);
 }
 
 @media not (-moz-proton) {
@@ -1570,7 +1570,7 @@ panelview .toolbarbutton-1,
 .widget-overflow-list .subviewbutton-nav::after,
 .PanelUI-subView .subviewbutton-nav::after {
   -moz-context-properties: fill, fill-opacity;
-  content: url(chrome://global/skin/icons/menu-arrow.svg);
+  content: url(chrome://global/skin/icons/arrow-right.svg);
   fill: currentColor;
   fill-opacity: 0.6;
   display: -moz-box;
@@ -1580,7 +1580,7 @@ panelview .toolbarbutton-1,
 #identity-popup-mainView .subviewbutton-nav:-moz-locale-dir(rtl)::after,
 .widget-overflow-list .subviewbutton-nav:-moz-locale-dir(rtl)::after,
 .PanelUI-subView .subviewbutton-nav:-moz-locale-dir(rtl)::after {
-  scale: -1 1;
+  content: url(chrome://global/skin/icons/arrow-left.svg);
 }
 
 #identity-popup-security-button > .toolbarbutton-text {
@@ -2262,8 +2262,8 @@ toolbarpaletteitem[place="menu-panel"] > .subviewbutton-nav::after {
 }
 } /** End Proton **/
 
-.subviewbutton-back:-moz-locale-dir(rtl) {
-  transform: scaleX(-1);
+.panel-header > .subviewbutton-back:-moz-locale-dir(rtl) {
+  list-style-image: url(chrome://global/skin/icons/arrow-right.svg);
 }
 
 .subviewbutton-back > .toolbarbutton-text {

browser/themes/shared/downloads/downloads.inc.css

@@ -270,7 +270,7 @@ button.downloadButton {
 }
 
 .downloadIconSubviewArrow > .button-box > .button-icon:-moz-locale-dir(ltr) {
-  transform: scaleX(-1);
+  list-style-image: url("chrome://global/skin/icons/arrow-right.svg");
 }
 
 /*** Blocked subview ***/

toolkit/components/printing/content/printPagination.css

@@ -110,9 +110,12 @@
 }
 
 #navigatePrevious:-moz-locale-dir(rtl)::after,
-#navigateEnd:-moz-locale-dir(rtl)::after,
-#navigateHome:-moz-locale-dir(ltr)::after,
 #navigateNext:-moz-locale-dir(ltr)::after {
+  background-image: url("chrome://global/skin/icons/arrow-right.svg");
+}
+
+#navigateEnd:-moz-locale-dir(rtl)::after,
+#navigateHome:-moz-locale-dir(ltr)::after {
   transform: scaleX(-1);
 }
 

toolkit/themes/shared/arrowscrollbox.css

@@ -25,17 +25,18 @@ toolbarbutton[disabled="true"] {
   fill-opacity: 0.4;
 }
 
-:host([orient="horizontal"]) > toolbarbutton {
-  list-style-image: url("chrome://global/skin/icons/arrow-left.svg");
-}
-
 #scrollbutton-up > .toolbarbutton-icon {
   list-style-image: url("chrome://global/skin/icons/arrow-up-12.svg");
 }
 
+:host([orient="horizontal"]) > #scrollbutton-up:-moz-locale-dir(ltr) > .toolbarbutton-icon,
+:host([orient="horizontal"]) > #scrollbutton-down:-moz-locale-dir(rtl) > .toolbarbutton-icon {
+  list-style-image: url("chrome://global/skin/icons/arrow-left.svg");
+}
+
 :host([orient="horizontal"]) > #scrollbutton-down:-moz-locale-dir(ltr) > .toolbarbutton-icon,
 :host([orient="horizontal"]) > #scrollbutton-up:-moz-locale-dir(rtl) > .toolbarbutton-icon {
-  transform: scaleX(-1);
+  list-style-image: url("chrome://global/skin/icons/arrow-right.svg");
 }
 
 toolbarbutton > .toolbarbutton-text {

toolkit/themes/shared/jar.inc.mn

@@ -31,6 +31,7 @@ toolkit.jar:
   skin/classic/global/in-content/toggle-button.css         (../../shared/in-content/toggle-button.css)
   skin/classic/global/icons/add.svg                        (../../shared/icons/add.svg)
   skin/classic/global/icons/arrow-left.svg                 (../../shared/icons/arrow-left.svg)
+  skin/classic/global/icons/arrow-right.svg                (../../shared/icons/arrow-right.svg)
   skin/classic/global/icons/autoscroll.svg                 (../../shared/icons/autoscroll.svg)
   skin/classic/global/icons/autoscroll-horizontal.svg      (../../shared/icons/autoscroll-horizontal.svg)
   skin/classic/global/icons/autoscroll-vertical.svg        (../../shared/icons/autoscroll-vertical.svg)
@@ -53,7 +54,6 @@ toolkit.jar:
   skin/classic/global/icons/lightbulb.svg                  (../../shared/icons/lightbulb.svg)
   skin/classic/global/icons/loading.png                    (../../shared/icons/loading.png)
   skin/classic/global/icons/loading@2x.png                 (../../shared/icons/loading@2x.png)
-  skin/classic/global/icons/menu-arrow.svg                 (../../shared/icons/menu-arrow.svg)
   skin/classic/global/icons/more.svg                       (../../shared/icons/more.svg)
   skin/classic/global/icons/open-in-new.svg                (../../shared/icons/open-in-new.svg)
   skin/classic/global/icons/page-portrait.svg              (../../shared/icons/page-portrait.svg)

toolkit/themes/windows/global/menu.css

@@ -146,7 +146,7 @@ menucaption {
 @media (-moz-windows-non-native-menus) {
   .menu-right {
     appearance: none;
-    list-style-image: url("chrome://global/skin/icons/menu-arrow.svg");
+    list-style-image: url("chrome://global/skin/icons/arrow-right.svg");
     -moz-context-properties: fill, fill-opacity;
     fill: currentColor;
     fill-opacity: var(--menu-icon-opacity);
@@ -161,7 +161,7 @@ menucaption {
   }
 
   .menu-right:-moz-locale-dir(rtl) {
-    transform: scaleX(-1);
+    list-style-image: url("chrome://global/skin/icons/arrow-left.svg");
   }
 }