Bug 369505 - "Dangerous sprintf calls in NSInstallExecute::toString" [p=benjamin@smedbergs.us (Benjamin Smedberg) r=dveditz a1.9=schrep]

xpinstall/src/nsInstallExecute.cpp

@@ -273,7 +273,7 @@ char* nsInstallExecute::toString()
 
         if (rsrcVal)
         {
-            sprintf( buffer, rsrcVal, tempString);
+            PR_snprintf(buffer, sizeof(buffer), rsrcVal, tempString);
             nsCRT::free(rsrcVal);
         }
         
@@ -288,7 +288,7 @@ char* nsInstallExecute::toString()
         {
             nsCAutoString temp;
             mExecutableFile->GetNativePath(temp);
-            sprintf( buffer, rsrcVal, temp.get());
+            PR_snprintf(buffer, sizeof(buffer), rsrcVal, temp.get());
             nsCRT::free(rsrcVal);
         }
     }