From d97ecd55942aaff69c32452b28979c3a9f93c642 Mon Sep 17 00:00:00 2001 From: Chenxia Liu Date: Tue, 4 Mar 2014 10:31:37 -0800 Subject: [PATCH] Bug 942878 - Part 0: Add final modifier to GeckoPreferences. r=lucasr --- .../base/preferences/GeckoPreferences.java | 32 +++++++++---------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/mobile/android/base/preferences/GeckoPreferences.java b/mobile/android/base/preferences/GeckoPreferences.java index ba7fe45aaed6..0cee4f880bc1 100644 --- a/mobile/android/base/preferences/GeckoPreferences.java +++ b/mobile/android/base/preferences/GeckoPreferences.java @@ -75,26 +75,26 @@ public class GeckoPreferences private int mPrefsRequestId = 0; // These match keys in resources/xml*/preferences*.xml - private static String PREFS_SEARCH_RESTORE_DEFAULTS = NON_PREF_PREFIX + "search.restore_defaults"; + private static final String PREFS_SEARCH_RESTORE_DEFAULTS = NON_PREF_PREFIX + "search.restore_defaults"; - private static String PREFS_ANNOUNCEMENTS_ENABLED = NON_PREF_PREFIX + "privacy.announcements.enabled"; - private static String PREFS_DATA_REPORTING_PREFERENCES = NON_PREF_PREFIX + "datareporting.preferences"; - private static String PREFS_TELEMETRY_ENABLED = "datareporting.telemetry.enabled"; - private static String PREFS_CRASHREPORTER_ENABLED = "datareporting.crashreporter.submitEnabled"; - private static String PREFS_MENU_CHAR_ENCODING = "browser.menu.showCharacterEncoding"; - private static String PREFS_MP_ENABLED = "privacy.masterpassword.enabled"; - private static String PREFS_UPDATER_AUTODOWNLOAD = "app.update.autodownload"; - private static String PREFS_GEO_REPORTING = "app.geo.reportdata"; - private static String PREFS_HEALTHREPORT_LINK = NON_PREF_PREFIX + "healthreport.link"; - private static String PREFS_DEVTOOLS_REMOTE_ENABLED = "devtools.debugger.remote-enabled"; - private static String PREFS_DISPLAY_REFLOW_ON_ZOOM = "browser.zoom.reflowOnZoom"; - private static String PREFS_SYNC = NON_PREF_PREFIX + "sync"; + private static final String PREFS_ANNOUNCEMENTS_ENABLED = NON_PREF_PREFIX + "privacy.announcements.enabled"; + private static final String PREFS_DATA_REPORTING_PREFERENCES = NON_PREF_PREFIX + "datareporting.preferences"; + private static final String PREFS_TELEMETRY_ENABLED = "datareporting.telemetry.enabled"; + private static final String PREFS_CRASHREPORTER_ENABLED = "datareporting.crashreporter.submitEnabled"; + private static final String PREFS_MENU_CHAR_ENCODING = "browser.menu.showCharacterEncoding"; + private static final String PREFS_MP_ENABLED = "privacy.masterpassword.enabled"; + private static final String PREFS_UPDATER_AUTODOWNLOAD = "app.update.autodownload"; + private static final String PREFS_GEO_REPORTING = "app.geo.reportdata"; + private static final String PREFS_HEALTHREPORT_LINK = NON_PREF_PREFIX + "healthreport.link"; + private static final String PREFS_DEVTOOLS_REMOTE_ENABLED = "devtools.debugger.remote-enabled"; + private static final String PREFS_DISPLAY_REFLOW_ON_ZOOM = "browser.zoom.reflowOnZoom"; + private static final String PREFS_SYNC = NON_PREF_PREFIX + "sync"; - public static String PREFS_RESTORE_SESSION = NON_PREF_PREFIX + "restoreSession3"; + public static final String PREFS_RESTORE_SESSION = NON_PREF_PREFIX + "restoreSession3"; // These values are chosen to be distinct from other Activity constants. - private static int REQUEST_CODE_PREF_SCREEN = 5; - private static int RESULT_CODE_EXIT_SETTINGS = 6; + private static final int REQUEST_CODE_PREF_SCREEN = 5; + private static final int RESULT_CODE_EXIT_SETTINGS = 6; @Override protected void onCreate(Bundle savedInstanceState) {