From dba81844c2302c4d2ca0423ad7d9fd760df6a466 Mon Sep 17 00:00:00 2001 From: Sylvestre Ledru Date: Mon, 21 Sep 2020 13:43:52 +0000 Subject: [PATCH] Bug 1666244 - Update of the wording + url at the end of the build r=mhoye Differential Revision: https://phabricator.services.mozilla.com/D90855 --- docs/setup/contributing_code.rst | 2 +- python/mozbuild/mozbuild/controller/building.py | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/setup/contributing_code.rst b/docs/setup/contributing_code.rst index 4689cb45b183..ec0022d53fa9 100644 --- a/docs/setup/contributing_code.rst +++ b/docs/setup/contributing_code.rst @@ -1,7 +1,7 @@ How To Contribute Code To Firefox ================================= -The whole process is a bit long, and it will take time to get things right. +The whole process can be a bit long, and it might take time to get things right. If at any point you are stuck, please don't hesitate to ask at `https://chat.mozilla.org `_ in the `#introduction `_ channel. diff --git a/python/mozbuild/mozbuild/controller/building.py b/python/mozbuild/mozbuild/controller/building.py index 39e742e92afc..5d5518cdc14e 100644 --- a/python/mozbuild/mozbuild/controller/building.py +++ b/python/mozbuild/mozbuild/controller/building.py @@ -1361,11 +1361,12 @@ class BuildDriver(MozbuildObject): print('To view resource usage of the build, run |mach ' 'resource-usage|.') - long_build = monitor.elapsed > 600 + long_build = monitor.elapsed > 1200 if long_build: output.on_line( 'We know it took a while, but your build finally finished successfully!') + output.on_line('If you are building Firefox often, SCCache can save you a lot of time. You can learn more here: https://firefox-source-docs.mozilla.org/build/buildsystem/sccache-dist.html') # noqa else: output.on_line('Your build was successful!') @@ -1381,7 +1382,7 @@ class BuildDriver(MozbuildObject): if app in ('browser', 'mobile/android'): print( 'For more information on what to do now, see ' - 'https://developer.mozilla.org/docs/Developer_Guide/So_You_Just_Built_Firefox' # noqa + 'https://firefox-source-docs.mozilla.org/setup/contributing_code.html' # noqa ) except Exception: # Ignore Exceptions in case we can't find config.status (such