Bug 1873158 - Update ESLint related modules to their latest versions. r=mossop,aminomancer,devtools-reviewers,reusable-components-reviewers

Differential Revision: https://phabricator.services.mozilla.com/D197765

browser/components/extensions/test/browser/browser_ext_menus_replace_menu_context.js

@@ -47,7 +47,6 @@ add_task(async function overrideContext_with_context() {
           "Expected successful executeScript"
         );
         browser.test.sendMessage("testTabAccessDone", "executeScript_ok");
-        return;
       } catch (e) {
         browser.test.assertEq(
           "Missing host permission for the tab",

browser/components/newtab/content-src/components/CustomizeMenu/ContentSection/ContentSection.jsx

@@ -126,7 +126,7 @@ export class ContentSection extends React.PureComponent {
                   id="row-selector"
                   className="selector"
                   name="row-count"
-                  preference="topSitesRows"
+                  data-preference="topSitesRows"
                   value={topSitesRowsCount}
                   onChange={this.onPreferenceSelect}
                   disabled={!topSitesEnabled}

browser/components/newtab/data/content/activity-stream.bundle.js

@@ -9209,7 +9209,7 @@ class ContentSection extends (external_React_default()).PureComponent {
       id: "row-selector",
       className: "selector",
       name: "row-count",
-      preference: "topSitesRows",
+      "data-preference": "topSitesRows",
       value: topSitesRowsCount,
       onChange: this.onPreferenceSelect,
       disabled: !topSitesEnabled,

devtools/server/actors/webconsole.js

@@ -860,7 +860,6 @@ class WebConsoleActor extends Actor {
           startTime,
           ...response,
         });
-        return;
       } catch (e) {
         const message = `Encountered error while waiting for Helper Result: ${e}\n${e.stack}`;
         DevToolsUtils.reportException("evaluateJSAsync", Error(message));

package.json

@@ -4,25 +4,25 @@
   "repository": {},
   "license": "MPL-2.0",
   "devDependencies": {
-    "@babel/core": "7.21.4",
-    "@babel/eslint-parser": "7.21.3",
-    "@babel/eslint-plugin": "7.19.1",
-    "@babel/plugin-syntax-jsx": "7.21.4",
+    "@babel/core": "7.23.7",
+    "@babel/eslint-parser": "7.23.3",
+    "@babel/eslint-plugin": "7.23.5",
+    "@babel/plugin-syntax-jsx": "7.23.3",
     "@microsoft/eslint-plugin-sdl": "0.2.2",
-    "eslint": "8.38.0",
+    "eslint": "8.56.0",
     "eslint-config-prettier": "8.8.0",
-    "eslint-plugin-eslint-plugin": "5.0.8",
+    "eslint-plugin-eslint-plugin": "5.2.1",
     "eslint-plugin-fetch-options": "0.0.5",
     "eslint-plugin-file-header": "0.0.1",
     "eslint-plugin-html": "7.1.0",
-    "eslint-plugin-import": "2.27.5",
-    "eslint-plugin-jest": "23.20.0",
+    "eslint-plugin-import": "2.29.1",
+    "eslint-plugin-jest": "27.6.1",
     "eslint-plugin-jsdoc": "39.9.1",
     "eslint-plugin-json": "3.1.0",
-    "eslint-plugin-jsx-a11y": "6.7.1",
+    "eslint-plugin-jsx-a11y": "6.8.0",
     "eslint-plugin-mozilla": "file:tools/lint/eslint/eslint-plugin-mozilla",
     "eslint-plugin-no-unsanitized": "4.0.2",
-    "eslint-plugin-react": "7.29.4",
+    "eslint-plugin-react": "7.33.2",
     "eslint-plugin-react-hooks": "4.6.0",
     "eslint-plugin-spidermonkey-js": "file:tools/lint/eslint/eslint-plugin-spidermonkey-js",
     "jsdoc": "4.0.2",
@@ -30,7 +30,7 @@
     "stylelint": "15.10.3",
     "stylelint-config-recommended": "13.0.0",
     "stylelint-config-standard-scss": "11.0.0",
-    "yarn": "1.22.19"
+    "yarn": "1.22.21"
   },
   "notes(private)": "We don't want to publish to npm, so this is marked as private",
   "private": true

services/sync/tps/extensions/tps/resource/tps.sys.mjs

@@ -216,7 +216,6 @@ export var TPS = {
           } else {
             this._triggeredSync = false;
             this.DumpError("Sync error; aborting test");
-            return;
           }
 
           break;

toolkit/content/widgets/panel.js

@@ -170,7 +170,6 @@
         );
         if (!this._prevFocus.get()) {
           this._prevFocus = Cu.getWeakReference(document.activeElement);
-          return;
         }
       } catch (ex) {
         this._prevFocus = Cu.getWeakReference(document.activeElement);

tools/lint/eslint/eslint-plugin-mozilla/manifest.tt

@@ -1,9 +1,9 @@
 [
   {
     "filename": "eslint-plugin-mozilla.tar.gz",
-    "size": 8169616,
+    "size": 7769140,
     "algorithm": "sha512",
-    "digest": "cd06349e3f61b41dcdf4f11c5e10c0f78c16eb68bd3473381b00faf63c92c28cb8c282f5ce66cbef2f655a974682b53c37562bb8b2fb60ee082eba782d94de0b",
+    "digest": "46c3263a65bc22aaddc2b673294a1488cd9db1a2f1f8be7812db8716b91cf7aeae0850b19a5636b0cde879c6dd126298d27b2fb7497fad1872aae7a666cadfbc",
     "unpack": true,
     "visibility": "public"
   }

tools/lint/eslint/eslint-plugin-mozilla/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-mozilla",
-  "version": "3.3.2",
+  "version": "3.4.0",
   "description": "A collection of rules that help enforce JavaScript coding standard in the Mozilla project.",
   "keywords": [
     "eslint",
@@ -20,23 +20,23 @@
   "author": "Mike Ratcliffe",
   "main": "lib/index.js",
   "dependencies": {
-    "@babel/core": "^7.20.12",
-    "@babel/eslint-parser": "^7.19.1",
-    "eslint-scope": "^7.1.1",
-    "eslint-visitor-keys": "^3.3.0",
+    "@babel/core": "^7.23.7",
+    "@babel/eslint-parser": "^7.23.3",
+    "eslint-scope": "^7.2.2",
+    "eslint-visitor-keys": "^3.4.3",
     "estraverse": "^5.3.0",
     "htmlparser2": "^8.0.1",
     "multi-ini": "^2.3.2",
-    "toml-eslint-parser": "0.6.0"
+    "toml-eslint-parser": "0.9.3"
   },
   "devDependencies": {
-    "eslint": "8.38.0",
+    "eslint": "8.56.0",
     "mocha": "10.2.0"
   },
   "peerDependencies": {
     "@microsoft/eslint-plugin-sdl": "^0.2.2",
     "eslint": "^7.23.0 || ^8.0.0",
-    "eslint-config-prettier": "^8.0.0",
+    "eslint-config-prettier": "^8.0.0 || ^9.0.0",
     "eslint-plugin-fetch-options": "^0.0.5",
     "eslint-plugin-html": "^7.0.0",
     "eslint-plugin-json": "^3.1.0",

tools/lint/eslint/manifest.tt

@@ -1,9 +1,9 @@
 [
   {
     "filename": "eslint.tar.gz",
-    "size": 25395561,
+    "size": 23718337,
     "algorithm": "sha512",
-    "digest": "b4258b0ee324f5f01cb620f2e619a7293d6542811a88cd17a090fcdaec4596c752220e1a4a67ff03e8a333507d95a0dc09054263ff706a7f2d1e6f1a1309f3b1",
+    "digest": "e32ab04fa5180e4f9b7dd901c263879c1ef1e4449d7d60a288f97579943d59d93341195f17fca0e5273e83b04f32195330398a61210ad33a8426c0bb1cc86034",
     "unpack": true,
     "visibility": "public"
   }

widget/tests/window_composition_text_querycontent.xhtml

@@ -6705,10 +6705,8 @@ function runCSSTransformTest()
       return;
     }
     lastCharRectTranslatedAsArray = synthesizeQueryTextRectArray(textarea.value.length - 1, textarea.value.length);
-    if (!checkQueryContentResult(lastCharRectTranslatedAsArray, "runCSSTransformTest: lastCharRectTranslatedAsArray, " + textarea.style.transform) ||
-        !checkRectArray(lastCharRectTranslatedAsArray, [lastCharRectTranslated], "runCSSTransformTest: lastCharRectTranslatedAsArray, " + textarea.style.transform)) {
-      return;
-    }
+    checkQueryContentResult(lastCharRectTranslatedAsArray, "runCSSTransformTest: lastCharRectTranslatedAsArray, " + textarea.style.transform);
+    checkRectArray(lastCharRectTranslatedAsArray, [lastCharRectTranslated], "runCSSTransformTest: lastCharRectTranslatedAsArray, " + textarea.style.transform);
   } finally {
     textarea.style.transform = "";
   }