From dcb4911aa5d8fa4f2442bc075f6d96612cb0f66a Mon Sep 17 00:00:00 2001 From: Sotaro Ikeda Date: Thu, 14 May 2015 15:48:06 -0700 Subject: [PATCH] Bug 1164697 - Fix time unit of AudioOffloadPlayer r=bholley --- dom/media/omx/AudioOffloadPlayer.cpp | 7 ------- dom/media/omx/AudioOffloadPlayer.h | 4 +--- dom/media/omx/AudioOffloadPlayerBase.h | 2 +- dom/media/omx/MediaOmxCommonDecoder.cpp | 2 +- 4 files changed, 3 insertions(+), 12 deletions(-) diff --git a/dom/media/omx/AudioOffloadPlayer.cpp b/dom/media/omx/AudioOffloadPlayer.cpp index 5525bdfc10b3..beb7e528c07f 100644 --- a/dom/media/omx/AudioOffloadPlayer.cpp +++ b/dom/media/omx/AudioOffloadPlayer.cpp @@ -385,13 +385,6 @@ status_t AudioOffloadPlayer::DoSeek() return OK; } -double AudioOffloadPlayer::GetMediaTimeSecs() -{ - MOZ_ASSERT(NS_IsMainThread()); - return (static_cast(GetMediaTimeUs()) / - static_cast(USECS_PER_S)); -} - int64_t AudioOffloadPlayer::GetMediaTimeUs() { android::Mutex::Autolock autoLock(mLock); diff --git a/dom/media/omx/AudioOffloadPlayer.h b/dom/media/omx/AudioOffloadPlayer.h index f2efa4600d82..2ee3f454b84b 100644 --- a/dom/media/omx/AudioOffloadPlayer.h +++ b/dom/media/omx/AudioOffloadPlayer.h @@ -88,7 +88,7 @@ public: virtual void SetVolume(double aVolume) override; - virtual double GetMediaTimeSecs() override; + virtual int64_t GetMediaTimeUs() override; // To update progress bar when the element is visible virtual void SetElementVisibility(bool aIsVisible) override;; @@ -192,8 +192,6 @@ private: // Used only from main thread so no lock is needed. nsRefPtr mWakeLock; - int64_t GetMediaTimeUs(); - // Provide the playback position in microseconds from total number of // frames played by audio track int64_t GetOutputPlayPositionUs_l() const; diff --git a/dom/media/omx/AudioOffloadPlayerBase.h b/dom/media/omx/AudioOffloadPlayerBase.h index 73c6310466a7..f62452b2edf2 100644 --- a/dom/media/omx/AudioOffloadPlayerBase.h +++ b/dom/media/omx/AudioOffloadPlayerBase.h @@ -54,7 +54,7 @@ public: virtual void SetVolume(double aVolume) {} - virtual double GetMediaTimeSecs() { return 0; } + virtual int64_t GetMediaTimeUs() { return 0; } // To update progress bar when the element is visible virtual void SetElementVisibility(bool aIsVisible) {} diff --git a/dom/media/omx/MediaOmxCommonDecoder.cpp b/dom/media/omx/MediaOmxCommonDecoder.cpp index 03a85c300fab..e138b4b823a1 100644 --- a/dom/media/omx/MediaOmxCommonDecoder.cpp +++ b/dom/media/omx/MediaOmxCommonDecoder.cpp @@ -244,7 +244,7 @@ MediaOmxCommonDecoder::CurrentPosition() } ReentrantMonitorAutoEnter mon(GetReentrantMonitor()); - return mAudioOffloadPlayer->GetMediaTimeSecs(); + return mAudioOffloadPlayer->GetMediaTimeUs(); } void