From dce439792031565a59dea1b4d183ae159ae9af8d Mon Sep 17 00:00:00 2001 From: "dmose%netscape.com" Date: Tue, 15 Nov 2005 20:09:01 +0000 Subject: [PATCH] If authentication fails during LDAP autocomplete, bring up a new password dialog rather than showing an obscure error message (bug 150723); r=ducarroz@netscape.com, sr=hewitt@netscape.com --- mailnews/addrbook/src/nsLDAPAutoCompleteSession.cpp | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/mailnews/addrbook/src/nsLDAPAutoCompleteSession.cpp b/mailnews/addrbook/src/nsLDAPAutoCompleteSession.cpp index b68973083367..5066a7a79012 100644 --- a/mailnews/addrbook/src/nsLDAPAutoCompleteSession.cpp +++ b/mailnews/addrbook/src/nsLDAPAutoCompleteSession.cpp @@ -685,6 +685,17 @@ nsLDAPAutoCompleteSession::OnLDAPBind(nsILDAPMessage *aMessage) // pop up a dialog telling the user to go manually delete // this password in the password manager. } + + // XXXdmose We should probably pop up an error dialog telling + // the user that the login failed here, rather than just bringing + // up the password dialog again, which is what calling OnLDAPInit() + // does. See bug 152997. + + PR_LOG(sLDAPAutoCompleteLogModule, PR_LOG_DEBUG, + ("nsLDAPAutoCompleteSession::OnLDAPBind(): auth error;" + " calling OnLDAPInit() again")); + + return OnLDAPInit(NS_OK); } // reset to the default state