Bug 1528236 - [raptor] Use opt-out mechanism for setting test specific preferences. r=perftest-reviewers,stephendonner

Due to missing class abstractions for Gecko- and non-Gecko based
browsers it's currently sub-optimal to define when preferences
as defined by tests will be set.

Given that by default we run Gecko-based applications other
browsers should opt-out from setting test preferences.

Differential Revision: https://phabricator.services.mozilla.com/D30923

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Henrik Skupin 2019-05-14 19:32:27 +00:00
Родитель 22364e41eb
Коммит dceb981485
1 изменённых файлов: 7 добавлений и 7 удалений

Просмотреть файл

@ -239,8 +239,8 @@ class Raptor(object):
def set_browser_test_prefs(self, raw_prefs):
# add test specific preferences
self.log.info("preferences were configured for the test, however \
we currently do not install them on non Firefox browsers.")
self.log.info("setting test-specific Firefox preferences")
self.profile.set_preferences(json.loads(raw_prefs))
def build_browser_profile(self):
self.profile = create_profile(self.profile_class)
@ -600,11 +600,6 @@ class RaptorDesktopFirefox(RaptorDesktop):
# to disk; then profiles are picked up by gecko_profile.symbolicate
self.control_server.gecko_profile_dir = self.gecko_profiler.gecko_profile_dir
def set_browser_test_prefs(self, raw_prefs):
# add test specific preferences
self.log.info("setting test-specific Firefox preferences")
self.profile.set_preferences(json.loads(raw_prefs))
class RaptorDesktopChrome(RaptorDesktop):
@ -636,6 +631,11 @@ class RaptorDesktopChrome(RaptorDesktop):
self.start_runner_proc()
def set_browser_test_prefs(self, raw_prefs):
# add test-specific preferences
self.log.info("preferences were configured for the test, however \
we currently do not install them on non-Firefox browsers.")
class RaptorAndroid(Raptor):