Bug 1588872 - Enable ESLint rule mozilla/prefer-boolean-length-check by default, disable for failing locations. r=Mardak

Differential Revision: https://phabricator.services.mozilla.com/D49437

--HG--
extra : moz-landing-system : lando

.eslintrc.js

@@ -357,11 +357,30 @@ module.exports = {
     }
   }, {
     "files": [
-      "toolkit/**",
-      "browser/**",
+      "accessible/**",
+      "devtools/**",
+      "dom/**",
+      "docshell/**",
+      "editor/libeditor/tests/**",
+      "editor/spellchecker/tests/test_bug338427.html",
+      "gfx/**",
+      "image/test/browser/browser_image.js",
+      "js/src/builtin/**",
+      "layout/**",
+      "mobile/android/**",
+      "modules/**",
+      "netwerk/**",
+      "remote/**",
+      "security/manager/**",
+      "services/**",
+      "storage/test/unit/test_vacuum.js",
+      "taskcluster/docker/periodic-updates/scripts/**",
+      "testing/**",
+      "tools/**",
+      "widget/tests/test_assign_event_data.html",
     ],
     "rules": {
-      "mozilla/prefer-boolean-length-check": "error",
+      "mozilla/prefer-boolean-length-check": "off",
     }
   }]
 };

tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js

@@ -134,6 +134,7 @@ module.exports = {
     "mozilla/no-define-cc-etc": "error",
     "mozilla/no-useless-parameters": "error",
     "mozilla/no-useless-removeEventListener": "error",
+    "mozilla/prefer-boolean-length-check": "error",
     "mozilla/reject-importGlobalProperties": ["error", "allownonwebidl"],
     "mozilla/rejects-requires-await": "error",
     "mozilla/use-cc-etc": "error",

tools/lint/eslint/eslint-plugin-mozilla/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-mozilla",
-  "version": "2.1.0",
+  "version": "2.2.0",
   "lockfileVersion": 1,
   "requires": true,
   "dependencies": {

tools/lint/eslint/eslint-plugin-mozilla/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-mozilla",
-  "version": "2.1.0",
+  "version": "2.2.0",
   "description": "A collection of rules that help enforce JavaScript coding standard in the Mozilla project.",
   "keywords": [
     "eslint",