Bug 1315850 - Ensure GMPParent checks whether the adapter version is present. r=gerald

This ensures that when we're using the ChromiumAdapter that we actually ask it
whether it'll work, rather than asking the adapter we're not using.

MozReview-Commit-ID: 85nZPl9MdWa

--HG--
extra : rebase_source : 90de89bec9b004859c3c2c09ed8efbd255acc141
This commit is contained in:
Chris Pearce 2017-02-20 11:48:32 +13:00
Родитель 4961ac416a
Коммит dd99f726b7
1 изменённых файлов: 18 добавлений и 4 удалений

Просмотреть файл

@ -43,6 +43,7 @@ using CrashReporter::GetIDFromMinidump;
#include "mozilla/dom/WidevineCDMManifestBinding.h" #include "mozilla/dom/WidevineCDMManifestBinding.h"
#include "widevine-adapter/WidevineAdapter.h" #include "widevine-adapter/WidevineAdapter.h"
#include "ChromiumCDMAdapter.h"
namespace mozilla { namespace mozilla {
@ -734,6 +735,22 @@ GMPParent::ReadChromiumManifestFile(nsIFile* aFile)
&GMPParent::ParseChromiumManifest, NS_ConvertUTF8toUTF16(json)); &GMPParent::ParseChromiumManifest, NS_ConvertUTF8toUTF16(json));
} }
static bool
IsCDMAPISupported(const mozilla::dom::WidevineCDMManifest& aManifest)
{
nsresult ignored; // Note: ToInteger returns 0 on failure.
int32_t moduleVersion = aManifest.mX_cdm_module_versions.ToInteger(&ignored);
int32_t interfaceVersion =
aManifest.mX_cdm_interface_versions.ToInteger(&ignored);
int32_t hostVersion = aManifest.mX_cdm_host_versions.ToInteger(&ignored);
if (MediaPrefs::EMEChromiumAPIEnabled()) {
return ChromiumCDMAdapter::Supports(
moduleVersion, interfaceVersion, hostVersion);
}
return WidevineAdapter::Supports(
moduleVersion, interfaceVersion, hostVersion);
}
RefPtr<GenericPromise> RefPtr<GenericPromise>
GMPParent::ParseChromiumManifest(const nsAString& aJSON) GMPParent::ParseChromiumManifest(const nsAString& aJSON)
{ {
@ -745,10 +762,7 @@ GMPParent::ParseChromiumManifest(const nsAString& aJSON)
return GenericPromise::CreateAndReject(NS_ERROR_FAILURE, __func__); return GenericPromise::CreateAndReject(NS_ERROR_FAILURE, __func__);
} }
nsresult ignored; // Note: ToInteger returns 0 on failure. if (!IsCDMAPISupported(m)) {
if (!WidevineAdapter::Supports(m.mX_cdm_module_versions.ToInteger(&ignored),
m.mX_cdm_interface_versions.ToInteger(&ignored),
m.mX_cdm_host_versions.ToInteger(&ignored))) {
return GenericPromise::CreateAndReject(NS_ERROR_FAILURE, __func__); return GenericPromise::CreateAndReject(NS_ERROR_FAILURE, __func__);
} }