Bug 534090 - do not use background notification for major updates (was PMU 3.0->3.5 major update has been really poor). r=dtownsend, ui-r=beltzner

toolkit/mozapps/update/src/nsUpdateService.js.in

@@ -2822,6 +2822,20 @@ UpdatePrompt.prototype = {
       }
     };
 
+    // bug 534090 - show the UI for update available notifications when the
+    // the system has been idle for at least IDLE_TIME without displaying an
+    // alert notification.
+    if (page == "updatesavailable") {
+      var idleService = Cc["@mozilla.org/widget/idleservice;1"].
+                        getService(Ci.nsIIdleService);
+
+      const IDLE_TIME = getPref("getIntPref", PREF_APP_UPDATE_IDLETIME, 60);
+      if (idleService.idleTime / 1000 >= IDLE_TIME) {
+        this._showUI(parent, uri, features, name, page, update);
+        return;
+      }
+    }
+
     try {
       var notifier = Cc["@mozilla.org/alerts-service;1"].
                      getService(Ci.nsIAlertsService);
@@ -2837,6 +2851,12 @@ UpdatePrompt.prototype = {
                        getService(Ci.nsIObserverService);
     observer.service.addObserver(observer, "quit-application", false);
 
+    // bug 534090 - show the UI when idle for update available notifications.
+    if (page == "updatesavailable") {
+      this._showUIWhenIdle(parent, uri, features, name, page, update);
+      return;
+    }
+
     // Give the user x seconds to react before showing the big UI
     var promptWaitTime = getPref("getIntPref", PREF_APP_UPDATE_PROMPTWAITTIME, 43200);
     observer.timer = Cc["@mozilla.org/timer;1"].