Bug 455213: Plugins get enabled when updating to Firefox 3.1. r=jst, r=josh

2008-11-02 15:49:03 +00:00 · 2008-11-02 15:49:03 +00:00 · df829bdbff
--- a/modules/plugin/base/src/nsPluginHostImpl.cpp
+++ b/modules/plugin/base/src/nsPluginHostImpl.cpp
@ -93,6 +93,7 @@
 #include "nsIScriptChannel.h"
 #include "nsPrintfCString.h"
 #include "nsIBlocklistService.h"
+#include "nsVersionComparator.h"

 // Friggin' X11 has to "#define None". Lame!
 #ifdef None
@ -204,7 +205,10 @@
 // 0.08 mime entry point on MachO, bug 137535
 // 0.09 the file encoding is changed to UTF-8, bug 420285
 // 0.10 added plugin versions on appropriate platforms, bug 427743
+// The current plugin registry version (and the maximum version we know how to read)
 static const char *kPluginRegistryVersion = "0.10";
+// The minimum registry version we know how to read
+static const char *kMinimumRegistryVersion = "0.9";
 ////////////////////////////////////////////////////////////////////////
 // CID's && IID's
 static NS_DEFINE_IID(kIPluginInstanceIID, NS_IPLUGININSTANCE_IID);
@ -5789,9 +5793,18 @@ nsPluginHostImpl::ReadPluginInfo()
  }

  // kPluginRegistryVersion
-  if (PL_strcmp(values[1], kPluginRegistryVersion)) {
+  PRInt32 vdiff = NS_CompareVersions(values[1], kPluginRegistryVersion);
+  // If this is a registry from some future version then don't attempt to read it
+  if (vdiff > 0) {
    return rv;
  }
+  // If this is a registry from before the minimum then don't attempt to read it
+  if (NS_CompareVersions(values[1], kMinimumRegistryVersion) < 0) {
+    return rv;
+  }
+
+  // Registry v0.10 and upwards includes the plugin version field
+  PRBool regHasVersion = NS_CompareVersions(values[1], "0.10") >= 0;

  if (!ReadSectionHeader(reader, "PLUGINS")) {
    return rv;
@ -5806,15 +5819,22 @@ nsPluginHostImpl::ReadPluginInfo()
    if (!reader.NextLine())
      return rv;

-    char *version = reader.LinePtr();
-    if (!reader.NextLine())
-      return rv;
+    char *version;
+    if (regHasVersion) {
+      version = reader.LinePtr();
+      if (!reader.NextLine())
+        return rv;
+    }
+    else {
+      version = "0";
+    }

    // lastModifiedTimeStamp|canUnload|tag.mFlag
    if (3 != reader.ParseLine(values, 3))
      return rv;

-    PRInt64 lastmod = nsCRT::atoll(values[0]);
+    // If this is an old plugin registry mark this plugin tag to be refreshed
+    PRInt64 lastmod = vdiff == 0 ? nsCRT::atoll(values[0]) : -1;
    PRBool canunload = atoi(values[1]);
    PRUint32 tagflag = atoi(values[2]);
    if (!reader.NextLine())
--- a/modules/plugin/test/Makefile.in
+++ b/modules/plugin/test/Makefile.in
@ -42,8 +42,12 @@ VPATH		= @srcdir@

 include $(DEPTH)/config/autoconf.mk

-MODULE = plugin
+MODULE = test_plugin

 DIRS = testplugin

+XPCSHELL_TESTS = \
+  unit \
+  $(NULL)
+
 include $(topsrcdir)/config/rules.mk
--- a/modules/plugin/test/unit/test_bug455213.js
+++ b/modules/plugin/test/unit/test_bug455213.js
@ -0,0 +1,188 @@
+/* ***** BEGIN LICENSE BLOCK *****
+ * Version: MPL 1.1/GPL 2.0/LGPL 2.1
+ *
+ * The contents of this file are subject to the Mozilla Public License Version
+ * 1.1 (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ * http://www.mozilla.org/MPL/
+ *
+ * Software distributed under the License is distributed on an "AS IS" basis,
+ * WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
+ * for the specific language governing rights and limitations under the
+ * License.
+ *
+ * The Original Code is mozilla.org code.
+ *
+ * The Initial Developer of the Original Code is
+ *      Dave Townsend <dtownsend@oxymoronical.com>.
+ *
+ * Portions created by the Initial Developer are Copyright (C) 2007
+ * the Initial Developer. All Rights Reserved.
+ *
+ * Contributor(s):
+ *
+ * Alternatively, the contents of this file may be used under the terms of
+ * either the GNU General Public License Version 2 or later (the "GPL"), or
+ * the GNU Lesser General Public License Version 2.1 or later (the "LGPL"),
+ * in which case the provisions of the GPL or the LGPL are applicable instead
+ * of those above. If you wish to allow use of your version of this file only
+ * under the terms of either the GPL or the LGPL, and not to allow others to
+ * use your version of this file under the terms of the MPL, indicate your
+ * decision by deleting the provisions above and replace them with the notice
+ * and other provisions required by the GPL or the LGPL. If you do not delete
+ * the provisions above, a recipient may use your version of this file under
+ * the terms of any one of the MPL, the GPL or the LGPL.
+ *
+ * ***** END LICENSE BLOCK *****
+ */
+
+const Cc = Components.classes;
+const Ci = Components.interfaces;
+
+const NS_APP_USER_PROFILE_50_DIR      = "ProfD";
+const NS_APP_PROFILE_DIR_STARTUP      = "ProfDS";
+
+// Plugin registry uses different field delimeters on different platforms
+var DELIM = ":";
+if ("@mozilla.org/windows-registry-key;1" in Components.classes)
+  DELIM = "|";
+
+var gProfD;
+var gDirSvc = Cc["@mozilla.org/file/directory_service;1"].
+             getService(Ci.nsIProperties);
+
+// Creates a fake profile folder that the pluginhost will read our crafted
+// pluginreg.dat from
+function createProfileFolder() {
+  gProfD = gDirSvc.get("CurProcD", Ci.nsILocalFile);
+  gProfD = gProfD.parent.parent;
+  gProfD.append("_tests");
+  gProfD.append("xpcshell-simple");
+  gProfD.append("test_plugin");
+  gProfD.append("profile");
+  
+  if (gProfD.exists())
+    gProfD.remove(true);
+  gProfD.create(Components.interfaces.nsIFile.DIRECTORY_TYPE, 0755);
+  
+  var dirProvider = {
+    getFile: function(prop, persistent) {
+      persistent.value = true;
+      if (prop == NS_APP_USER_PROFILE_50_DIR ||
+          prop == NS_APP_PROFILE_DIR_STARTUP)
+        return gProfD.clone();
+      return null;
+    },
+    QueryInterface: function(iid) {
+      if (iid.equals(Ci.nsIDirectoryServiceProvider) ||
+          iid.equals(Ci.nsISupports)) {
+        return this;
+      }
+      throw Components.results.NS_ERROR_NO_INTERFACE;
+    }
+  };
+  gDirSvc.QueryInterface(Ci.nsIDirectoryService)
+         .registerProvider(dirProvider);
+}
+
+// Writes out some plugin registry to the profile
+function write_registry(version, info) {
+  var header = "Generated File. Do not edit.\n\n";
+  header += "[HEADER]\n";
+  header += "Version" + DELIM + version + DELIM + "$\n\n";
+  header += "[PLUGINS]\n";
+
+  var registry = gProfD.clone();
+  registry.append("pluginreg.dat");
+  var foStream = Components.classes["@mozilla.org/network/file-output-stream;1"]
+                           .createInstance(Components.interfaces.nsIFileOutputStream);
+  // write, create, truncate
+  foStream.init(registry, 0x02 | 0x08 | 0x20, 0666, 0); 
+
+  var charset = "UTF-8"; // Can be any character encoding name that Mozilla supports
+  var os = Cc["@mozilla.org/intl/converter-output-stream;1"].
+           createInstance(Ci.nsIConverterOutputStream);
+  os.init(foStream, charset, 0, 0x0000);
+  
+  os.writeString(header);
+  os.writeString(info);
+  os.close();
+}
+
+// Finds the test plugin library
+function get_test_plugin() {
+  var plugins = gDirSvc.get("CurProcD", Ci.nsILocalFile);
+  plugins.append("plugins");
+  do_check_true(plugins.exists());
+  var plugin = plugins.clone();
+  // OSX plugin
+  plugin.append("Test.plugin");
+  if (plugin.exists()) {
+    plugin.normalize();
+    return plugin;
+  }
+  plugin = plugins.clone();
+  // *nix plugin
+  plugin.append("libnptest.so");
+  if (plugin.exists()) {
+    plugin.normalize();
+    return plugin;
+  }
+  // Windows plugin
+  plugin = plugins.clone();
+  plugin.append("nptest.dll");
+  if (plugin.exists()) {
+    plugin.normalize();
+    return plugin;
+  }
+  return null;
+}
+
+// Finds the test nsIPluginTag
+function get_test_plugintag() {
+  var host = Cc["@mozilla.org/plugin/host;1"].
+             getService(Ci.nsIPluginHost);
+  var tags = host.getPluginTags({});
+  for (var i = 0; i < tags.length; i++) {
+    if (tags[i].name == "Test Plug-in")
+      return tags[i];
+  }
+  return null;
+}
+
+function run_test() {
+  createProfileFolder();
+  var file = get_test_plugin();
+  if (!file)
+    do_throw("Plugin library not found");
+
+  // Write out a 0.9 version registry that marks the test plugin as disabled
+  var registry = "";
+  registry += file.leafName + DELIM + "$\n";
+  registry += file.path + DELIM + "$\n";
+  registry += file.lastModifiedTime + DELIM + "0" + DELIM + "0" + DELIM + "$\n";
+  registry += "Plug-in for testing purposes." + DELIM + "$\n";
+  registry += "Test Plug-in" + DELIM + "$\n";
+  registry += "1\n";
+  registry += "0" + DELIM + "application/x-test" + DELIM + "Test mimetype" +
+              DELIM + "tst" + DELIM + "$\n";
+  write_registry("0.9", registry);
+
+  var plugin = get_test_plugintag();
+  if (!plugin)
+    do_throw("Plugin tag not found");
+
+  // If the plugin was not rescanned then this version will not be correct
+  do_check_eq(plugin.version, "1.0.0.0");
+  do_check_eq(plugin.description, "Plug-in for testing purposes.");
+  // If the plugin registry was not read then the plugin will not be disabled
+  do_check_true(plugin.disabled);
+  do_check_false(plugin.blocklisted);
+
+  try {
+    gProfD.remove(true);
+  }
+  catch (e) {
+    // Failure to remove temp dir shouldn't be a test failure
+  }
+}