Bug 1699858 - Avoid using the toolkit/global icons which are about to change for proton. r=nchevobbe,jdescottes

Differential Revision: https://phabricator.services.mozilla.com/D109186

browser/installer/allowed-dupes.mn

@@ -95,3 +95,9 @@ browser/chrome/browser/content/activity-stream/data/content/tippytop/favicons/du
 browser/chrome/browser/search-extensions/ddg/favicon.ico
 browser/chrome/browser/content/activity-stream/data/content/tippytop/favicons/google-com.ico
 browser/chrome/browser/search-extensions/google/favicon.ico
+
+# Bug 1699889 - Temporarily cloned icons will be resolved when toolkit svgs updated
+chrome/toolkit/skin/classic/global/icons/arrow-dropdown-12.svg
+browser/chrome/devtools/skin/images/arrow-dropdown-12.svg
+chrome/toolkit/skin/classic/global/icons/check.svg
+browser/chrome/devtools/skin/images/check.svg

devtools/client/aboutdebugging/src/components/shared/IconLabel.js

@@ -13,8 +13,8 @@ const {
 } = require("devtools/client/aboutdebugging/src/constants");
 
 const ICONS = {
-  [ICON_LABEL_LEVEL.INFO]: "chrome://global/skin/icons/info.svg",
-  [ICON_LABEL_LEVEL.OK]: "chrome://global/skin/icons/success.svg",
+  [ICON_LABEL_LEVEL.INFO]: "chrome://devtools/skin/images/info.svg",
+  [ICON_LABEL_LEVEL.OK]: "chrome://devtools/skin/images/check.svg",
 };
 
 /* This component displays an icon accompanied by some content. It's similar

devtools/client/aboutdebugging/src/components/shared/Message.js

@@ -23,7 +23,7 @@ const ICONS = {
     "chrome://devtools/skin/images/aboutdebugging-error.svg",
   [MESSAGE_LEVEL.INFO]:
     "chrome://devtools/skin/images/aboutdebugging-information.svg",
-  [MESSAGE_LEVEL.WARNING]: "chrome://global/skin/icons/warning.svg",
+  [MESSAGE_LEVEL.WARNING]: "chrome://devtools/skin/images/alert.svg",
 };
 const CLOSE_ICON_SRC = "chrome://devtools/skin/images/close.svg";
 

devtools/client/aboutdebugging/test/node/components/__snapshots__/shared-message.test.js.snap

@@ -42,7 +42,7 @@ exports[`Message component renders the expected snapshot for WARNING level 1`] =
 >
   <img
     className="message__icon"
-    src="chrome://global/skin/icons/warning.svg"
+    src="chrome://devtools/skin/images/alert.svg"
   />
   <div
     className="message__body"

devtools/client/framework/options-panel.css

@@ -125,7 +125,7 @@
 }
 
 .deprecation-notice::before {
-  background-image: url("chrome://global/skin/icons/warning.svg");
+  background-image: url("chrome://devtools/skin/images/alert.svg");
   content: '';
   display: inline-block;
   flex-shrink: 0;

devtools/client/inspector/rules/test/browser_rules_add-property-svg.js

@@ -5,7 +5,7 @@
 
 // Tests editing SVG styles using the rules view.
 
-var TEST_URL = "chrome://global/skin/icons/warning.svg";
+var TEST_URL = "chrome://devtools/skin/images/alert.svg";
 var TEST_SELECTOR = "path";
 
 add_task(async function() {

devtools/client/inspector/shared/test/browser_styleinspector_tooltip-background-image.js

@@ -17,7 +17,7 @@ const TEST_URI = `
     .test-element {
       font-family: verdana;
       color: #333;
-      background: url(chrome://global/skin/icons/warning.svg) no-repeat left center;
+      background: url(chrome://global/skin/icons/help.svg) no-repeat left center;
       padding-left: 70px;
     }
   </style>

devtools/client/inspector/shared/test/browser_styleinspector_tooltip-size.js

@@ -10,7 +10,7 @@ const TEST_URI = `
   <style type="text/css">
     div {
       width: 300px;height: 300px;border-radius: 50%;
-      background: red url(chrome://global/skin/icons/warning.svg);
+      background: red url(chrome://global/skin/icons/help.svg);
     }
   </style>
   <div></div>

devtools/client/jar.mn

@@ -230,6 +230,7 @@ devtools.jar:
     skin/images/alert.svg (themes/images/alert.svg)
     skin/images/alert-small.svg (themes/images/alert-small.svg)
     skin/images/alert-tiny.svg (themes/images/alert-tiny.svg)
+    skin/images/arrow-dropdown-12.svg (themes/images/arrow-dropdown-12.svg)
     skin/images/error.svg (themes/images/error.svg)
     skin/images/error-small.svg (themes/images/error-small.svg)
     skin/images/error-tiny.svg (themes/images/error-tiny.svg)
@@ -388,6 +389,7 @@ devtools.jar:
     skin/images/select-arrow.svg (themes/images/select-arrow.svg)
     skin/images/settings.svg (themes/images/settings.svg)
     skin/images/lock.svg (themes/images/lock.svg)
+    skin/images/check.svg (themes/images/check.svg)
     skin/images/browsers/chrome.svg (themes/images/browsers/chrome.svg)
     skin/images/browsers/edge.svg (themes/images/browsers/edge.svg)
     skin/images/browsers/firefox.svg (themes/images/browsers/firefox.svg)

devtools/client/shared/components/NotificationBox.css

@@ -73,7 +73,7 @@
 }
 
 .notificationbox .messageImage[data-type="warning"] {
-  background-image: url("chrome://global/skin/icons/warning.svg");
+  background-image: url("chrome://devtools/skin/images/alert.svg");
   /* Keep the icon colored to make it more eye-catching */
   fill: #ffbf00;
 }

devtools/client/themes/images/alert.svg

@@ -2,5 +2,5 @@
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 <svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 16 16">
-  <path fill="context-fill" d="M14.742 12.106L9.789 2.2a2 2 0 0 0-3.578 0l-4.953 9.91A2 2 0 0 0 3.047 15h9.905a2 2 0 0 0 1.79-2.894zM7 5a1 1 0 0 1 2 0v4a1 1 0 0 1-2 0zm1 8.25A1.25 1.25 0 1 1 9.25 12 1.25 1.25 0 0 1 8 13.25z" />
+  <path fill="context-fill #FFBF00" d="M14.742 12.106L9.789 2.2a2 2 0 0 0-3.578 0l-4.953 9.91A2 2 0 0 0 3.047 15h9.905a2 2 0 0 0 1.79-2.894zM7 5a1 1 0 0 1 2 0v4a1 1 0 0 1-2 0zm1 8.25A1.25 1.25 0 1 1 9.25 12 1.25 1.25 0 0 1 8 13.25z" />
 </svg>

devtools/client/themes/images/arrow-dropdown-12.svg

@@ -0,0 +1,6 @@
+<!-- This Source Code Form is subject to the terms of the Mozilla Public
+   - License, v. 2.0. If a copy of the MPL was not distributed with this
+   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
+<svg xmlns="http://www.w3.org/2000/svg" width="12" height="12" viewBox="0 0 12 12">
+  <path fill="context-fill" fill-opacity="context-fill-opacity" d="M6 9a1 1 0 0 1-.707-.293l-3-3a1 1 0 0 1 1.414-1.414L6 6.586l2.293-2.293a1 1 0 0 1 1.414 1.414l-3 3A1 1 0 0 1 6 9z"/>
+</svg>

devtools/client/themes/images/check.svg

@@ -0,0 +1,6 @@
+<!-- This Source Code Form is subject to the terms of the Mozilla Public
+   - License, v. 2.0. If a copy of the MPL was not distributed with this
+   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
+<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 16 16" fill="context-fill" fill-opacity="context-fill-opacity">
+  <path stroke="context-stroke none" stroke-width="0.5" d="M6.52,12.5a1,1,0,0,1-.705-.291l-3.52-3.5a1,1,0,1,1,1.41-1.418l2.812,2.8,5.774-5.793a1,1,0,0,1,1.416,1.412l-6.479,6.5A1,1,0,0,1,6.52,12.5Z"/>
+</svg>

devtools/client/themes/perf.css

@@ -190,7 +190,7 @@ a.perf-photon-button:focus {
   appearance: none;
   color: var(--theme-select-color);
   background-color: var(--theme-select-background);
-  background-image: url('chrome://global/skin/icons/arrow-dropdown-12.svg');
+  background-image: url('chrome://devtools/skin/images/arrow-dropdown-12.svg');
   background-position: right 4px center;
   background-repeat: no-repeat;
 

devtools/client/themes/tooltips.css

@@ -506,7 +506,7 @@ strong {
   list-style-image: none;
   -moz-context-properties: fill;
   fill: currentColor;
-  background: url(chrome://global/skin/icons/check.svg) no-repeat transparent;
+  background: url(chrome://devtools/skin/images/check.svg) no-repeat transparent;
   background-position: 7px center;
 }