Bug 558287: Move behavioural CSS into content. r+a=dtownsend

toolkit/mozapps/extensions/content/extensions.css

@@ -75,6 +75,10 @@
   -moz-binding: url("chrome://mozapps/content/extensions/extensions.xml#install-status");
 }
 
+#header-searching:not([active]) {
+  visibility: hidden;
+}
+
 .addon[active="true"] .disabled-postfix {
   display: none;
 }
@@ -83,6 +87,11 @@
   display: none;
 }
 
+#search-list[local="false"]  > .addon[remote="false"],
+#search-list[remote="false"] > .addon[remote="true"] {
+  visibility: collapse;
+}
+
 #detail-view[loading] > .detail-view-container {
   display: none;
 }

toolkit/mozapps/extensions/test/browser/browser_searching.js

@@ -90,6 +90,22 @@ function getAnonymousElementByAttribute(aElement, aName, aValue) {
                                                                 aValue);
 }
 
+/*
+ * Checks whether or not the Add-ons Manager is currently searching
+ *
+ * @param  aExpectedSearching
+ *         The expected isSearching state
+ */
+function check_is_searching(aExpectedSearching) {
+  is(gManagerWindow.gHeader.isSearching, aExpectedSearching,
+     "Should get expected isSearching state");
+
+  var throbber = gManagerWindow.document.getElementById("header-searching");
+  var style = gManagerWindow.document.defaultView.getComputedStyle(throbber, "");
+  is(style.visibility, aExpectedSearching ? "visible" : "hidden",
+     "Search throbber should be showing iff currently searching");
+}
+
 /*
  * Completes a search
  *
@@ -122,7 +138,7 @@ function search(aQuery, aFinishImmediately, aCallback, aCategoryType) {
     is(gCategoryUtilities.selectedCategory, aCategoryType, "Expected category view should be selected");
     is(gCategoryUtilities.isTypeVisible("search"), aCategoryType == "search",
        "Search category should only be visible if it is the current view");
-    is(gManagerWindow.gHeader.isSearching, false, "Should no longer be searching");
+    check_is_searching(false);
     is(finishImmediately, aFinishImmediately, "Search should finish immediately only if expected");
 
     aCallback();
@@ -130,7 +146,7 @@ function search(aQuery, aFinishImmediately, aCallback, aCategoryType) {
 
   finishImmediately = false
   if (!aFinishImmediately)
-    ok(gManagerWindow.gHeader.isSearching, "Should be searching");
+    check_is_searching(true);
 }
 
 /*

toolkit/themes/gnomestripe/mozapps/extensions/extensions.css

@@ -164,10 +164,6 @@
   -moz-margin-end: 6px;
 }
 
-#header-searching:not([active]) {
-  visibility: hidden;
-}
-
 #header-searching {
   list-style-image: url("chrome://global/skin/icons/loading_16.png");
 }
@@ -414,15 +410,6 @@
   font-size: 120%;
 }
 
-#search-list > .addon {
-  visibility: collapse;
-}
-
-#search-list[local="true"]  > .addon[remote="false"],
-#search-list[remote="true"] > .addon[remote="true"] {
-  visibility: visible;
-}
-
 
 /*** detail view ***/
 

toolkit/themes/pinstripe/mozapps/extensions/extensions.css

@@ -164,10 +164,6 @@
   -moz-margin-end: 6px;
 }
 
-#header-searching:not([active]) {
-  visibility: hidden;
-}
-
 #header-searching {
   list-style-image: url("chrome://global/skin/icons/loading_16.png");
 }
@@ -414,15 +410,6 @@
   font-size: 120%;
 }
 
-#search-list > .addon {
-  visibility: collapse;
-}
-
-#search-list[local="true"]  > .addon[remote="false"],
-#search-list[remote="true"] > .addon[remote="true"] {
-  visibility: visible;
-}
-
 
 /*** detail view ***/
 

toolkit/themes/winstripe/mozapps/extensions/extensions.css

@@ -164,10 +164,6 @@
   -moz-margin-end: 6px;
 }
 
-#header-searching:not([active]) {
-  visibility: hidden;
-}
-
 #header-searching {
   list-style-image: url("chrome://global/skin/icons/loading_16.png");
 }
@@ -414,15 +410,6 @@
   font-size: 120%;
 }
 
-#search-list > .addon {
-  visibility: collapse;
-}
-
-#search-list[local="true"]  > .addon[remote="false"],
-#search-list[remote="true"] > .addon[remote="true"] {
-  visibility: visible;
-}
-
 
 /*** detail view ***/