Bug 1363795 - Enable some Mozilla ESLint recommended rules for dom/indexedDB/test (no-undef). r=bevis

MozReview-Commit-ID: G6uRTV9i0uX

--HG--
extra : rebase_source : d882067602831bc2a257283aa2e70529568ddf0f

dom/indexedDB/test/.eslintrc.js

@@ -0,0 +1,29 @@
+"use strict";
+
+module.exports = {
+  "extends": [
+    "plugin:mozilla/recommended",
+    "plugin:mozilla/browser-test",
+    "plugin:mozilla/chrome-test",
+    "plugin:mozilla/mochitest-test",
+  ],
+  "plugins": [
+    "mozilla"
+  ],
+  "rules": {
+    "brace-style": "off",
+    "consistent-return": "off",
+    "key-spacing": "off",
+    "keyword-spacing": "off",
+    "no-extra-semi": "off",
+    "no-native-reassign": "off",
+    "no-shadow": "off",
+    "no-trailing-spaces": "off",
+    "no-unused-vars": "off",
+    "object-shorthand": "off",
+    "quotes": "off",
+    "spaced-comment": "off",
+    "space-before-blocks": "off",
+    "space-before-function-paren": "off",
+  }
+};

dom/indexedDB/test/blob_worker_crash_iframe.html

@@ -52,6 +52,7 @@ dump("EXCEPTION IN CREATION: " + e + "\n " + e.stack + "\n");
                                    { type: "text/fancy" });
 
       function workerScript() {
+        /* eslint-env worker */
         onmessage = function(event) {
           // Save the Blob to the worker's global scope.
           self.holdOntoBlob = event.data;

dom/indexedDB/test/browserHelpers.js

@@ -3,6 +3,9 @@
  * http://creativecommons.org/publicdomain/zero/1.0/
  */
 
+// testSteps is expected to be defined by the file including this file.
+/* global testSteps */
+
 var testGenerator = testSteps();
 
 var testResult;

dom/indexedDB/test/browser_forgetThisSiteAdd.html

@@ -7,6 +7,7 @@
     <title>Indexed Database Test</title>
 
     <script type="text/javascript">
+      /* import-globals-from browserHelpers.js */
       function* testSteps()
       {
         let request = indexedDB.open("browser_forgetThisSite.js", 11);

dom/indexedDB/test/browser_forgetThisSiteGet.html

@@ -7,6 +7,7 @@
     <title>Indexed Database Test</title>
 
     <script type="text/javascript">
+      /* import-globals-from browserHelpers.js */
       function* testSteps()
       {
         let request = indexedDB.open("browser_forgetThisSite.js");

dom/indexedDB/test/browser_permissionsPrompt.html

@@ -8,6 +8,7 @@
     <title>Indexed Database Test</title>
 
     <script type="text/javascript">
+      /* import-globals-from browserHelpers.js */
       function* testSteps()
       {
         const name = window.location.pathname;

dom/indexedDB/test/browser_permissionsSharedWorker.html

@@ -7,6 +7,8 @@
     <title>Indexed Database Test</title>
 
     <script type="text/javascript">
+    // testFinishedCallback is expected to be set in the scope by head.js.
+    /* global testFinishedCallback */
     let testIsIDBDatabase;
     let testException;
 

dom/indexedDB/test/browser_permissionsSharedWorker.js

@@ -1,3 +1,5 @@
+/* eslint-env worker */
+
 onconnect = function(e) {
   e.ports[0].onmessage = function(e) {
     var request = indexedDB.open(e.data, { version: 1,

dom/indexedDB/test/browser_permissionsWorker.html

@@ -7,6 +7,8 @@
     <title>Indexed Database Test</title>
 
     <script type="text/javascript">
+    // testFinishedCallback is expected to be set in the scope by head.js.
+    /* global testFinishedCallback */
     let testIsIDBDatabase;
     let testException;
 

dom/indexedDB/test/browser_permissionsWorker.js

@@ -1,3 +1,5 @@
+/* eslint-env worker */
+
 onmessage = function(e) {
   var request = indexedDB.open(e.data, { version: 1,
                                          storage: "persistent" });

dom/indexedDB/test/chromeHelpers.js

@@ -5,6 +5,9 @@
 
 var { 'classes': Cc, 'interfaces': Ci, 'utils': Cu } = Components;
 
+// testSteps is expected to be defined by the file including this file.
+/* global testSteps */
+
 var testGenerator = testSteps();
 
 if (!window.runTest) {

dom/indexedDB/test/file.js

@@ -3,6 +3,8 @@
  * http://creativecommons.org/publicdomain/zero/1.0/
  */
 
+/* import-globals-from helpers.js */
+
 var bufferCache = [];
 var utils = SpecialPowers.getDOMWindowUtils(window);
 

dom/indexedDB/test/helpers.js

@@ -3,6 +3,9 @@
  * http://creativecommons.org/publicdomain/zero/1.0/
  */
 
+// testSteps is expected to be defined by the test using this file.
+/* global testSteps:false */
+
 var testGenerator = testSteps();
 // The test js is shared between xpcshell (which has no SpecialPowers object)
 // and content mochitests (where the |Components| object is accessible only as
@@ -188,7 +191,7 @@ function* testHarnessSteps() {
   } else if (testScriptFilename) {
     todo(false,
          "Skipping test in a worker because it is explicitly disabled: " +
-         disableWorkerTest);
+         window.disableWorkerTest);
   } else {
     todo(false,
          "Skipping test in a worker because it's not structured properly");

dom/indexedDB/test/test_bfcache.html

@@ -9,6 +9,7 @@
   <script type="text/javascript" src="/tests/SimpleTest/SimpleTest.js"></script>
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
   <script type="text/javascript">
+    /* import-globals-from helpers.js */
     var gOrigMaxTotalViewers = undefined;
     function setCachePref(enabled) {
       if (enabled) {
@@ -44,7 +45,7 @@
       is(event.data, "go", "set up database successfully");
 
       iframe.src = "bfcache_iframe2.html";
-      res = JSON.parse((yield).data);
+      let res = JSON.parse((yield).data);
       is(res.version, 2, "version was set correctly");
       is(res.storeCount, 1, "correct set of stores");
       ok(!("blockedFired" in res), "blocked shouldn't fire");

dom/indexedDB/test/test_blob_simple.html

@@ -10,6 +10,7 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     info("Setting up test fixtures: create an IndexedDB database and object store.");
@@ -207,6 +208,7 @@
     info("Send blob to a worker, read its contents there, and verify results.");
 
     function workerScript() {
+      /* eslint-env worker */
       onmessage = function(event) {
         var reader = new FileReaderSync();
         postMessage(reader.readAsText(event.data));

dom/indexedDB/test/test_blob_worker_crash.html

@@ -10,6 +10,7 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from helpers.js */
   /*
    * This tests ensures that if the last live reference to a Blob is on the
    * worker and the database has already been shutdown, that there is no crash

dom/indexedDB/test/test_blob_worker_xhr_post.html

@@ -10,6 +10,7 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const BLOB_DATA = ["fun ", "times ", "all ", "around!"];
@@ -71,6 +72,7 @@
     info("Sending slice to a worker");
 
     function workerScript() {
+      /* eslint-env worker */
       onmessage = function(event) {
         var blob = event.data;
         var xhr = new XMLHttpRequest();

dom/indexedDB/test/test_blob_worker_xhr_post_multifile.html

@@ -10,6 +10,7 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from helpers.js */
   /**
    * Create a composite/multi-file Blob on the worker, then post it as an XHR
    * payload and ensure that we don't hang/generate an assertion/etc. but
@@ -69,6 +70,7 @@
     is(blob.type, BLOB_TYPE, "Correct type");
 
     function workerScript() {
+      /* eslint-env worker */
       onmessage = function(event) {
         var blob = event.data;
         var compositeBlob = new Blob(["preceding string. ", blob],

dom/indexedDB/test/test_blob_worker_xhr_read.html

@@ -10,6 +10,7 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from helpers.js */
   /**
    * Create an IndexedDB-backed Blob, send it to the worker, try and read the
    * contents of the Blob from the worker using an XHR.  Ideally, we don't
@@ -70,6 +71,7 @@
     info("Sending blob to a worker");
 
     function workerScript() {
+      /* eslint-env worker */
       onmessage = function(event) {
         var blob = event.data;
         var blobUrl = URL.createObjectURL(blob);

dom/indexedDB/test/test_blob_worker_xhr_read_slice.html

@@ -10,6 +10,7 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from helpers.js */
   /**
    * Create an IndexedDB-backed Blob, send it to the worker, try and read the
    * *SLICED* contents of the Blob from the worker using an XHR.  This is
@@ -71,6 +72,7 @@
     info("Sending blob to a worker");
 
     function workerScript() {
+      /* eslint-env worker */
       onmessage = function(event) {
         var blob = event.data;
         var slicedBlob = blob.slice(0, 3, "text/plain");

dom/indexedDB/test/test_file_array.html

@@ -10,6 +10,8 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from file.js */
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const name = window.location.pathname;

dom/indexedDB/test/test_file_cross_database_copying.html

@@ -10,6 +10,8 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from file.js */
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const READ_WRITE = "readwrite";
@@ -75,7 +77,7 @@
       let objectStore = db.transaction([objectStoreName], READ_WRITE)
                           .objectStore(objectStoreName);
 
-      request = objectStore.add(refResult, 2);
+      let request = objectStore.add(refResult, 2);
       request.onsuccess = grabEventAndContinueHandler;
       event = yield undefined;
 

dom/indexedDB/test/test_file_delete.html

@@ -10,6 +10,8 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from file.js */
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const READ_WRITE = "readwrite";
@@ -80,8 +82,8 @@
       let db = event.target.result;
       db.onerror = errorHandler;
 
-      trans = db.transaction([objectStoreName], READ_WRITE);
-      objectStore = trans.objectStore(objectStoreName);
+      let trans = db.transaction([objectStoreName], READ_WRITE);
+      let objectStore = trans.objectStore(objectStoreName);
 
       request = objectStore.get(fileData2.key);
       request.onsuccess = grabEventAndContinueHandler;

dom/indexedDB/test/test_file_os_delete.html

@@ -10,6 +10,8 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from file.js */
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const READ_WRITE = "readwrite";

dom/indexedDB/test/test_file_put_deleted.html

@@ -10,6 +10,8 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from file.js */
+  /* import-globals-from helpers.js */
   /**
    * Test that a put of a file-backed Blob/File whose backing file has been
    * deleted results in a failure of that put failure.
@@ -109,7 +111,7 @@
       let trans = db.transaction([objectStoreName], READ_WRITE);
       let objectStore = trans.objectStore(objectStoreName);
 
-      request = objectStore.add(fileBackedFile, 2);
+      let request = objectStore.add(fileBackedFile, 2);
       request.onsuccess = unexpectedSuccessHandler;
       request.onerror = expectedErrorHandler("UnknownError");
       trans.onsuccess = unexpectedSuccessHandler;
@@ -133,7 +135,7 @@
 
       // Attempt to fetch the key to verify there's nothing in the DB rather
       // than the value which could return undefined as a misleading error.
-      request = objectStore.getKey(2);
+      let request = objectStore.getKey(2);
       request.onsuccess = grabEventAndContinueHandler;
       request.onerror = errorHandler;
       event = yield undefined;

dom/indexedDB/test/test_file_put_get_object.html

@@ -10,6 +10,8 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from file.js */
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const READ_WRITE = "readwrite";

dom/indexedDB/test/test_file_put_get_values.html

@@ -10,6 +10,8 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from file.js */
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const READ_WRITE = "readwrite";

dom/indexedDB/test/test_file_replace.html

@@ -10,6 +10,8 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from file.js */
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const name = window.location.pathname;

dom/indexedDB/test/test_file_resurrection_delete.html

@@ -10,6 +10,8 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from file.js */
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const READ_WRITE = "readwrite";
@@ -82,7 +84,7 @@
       db.onerror = errorHandler;
 
       let trans = db.transaction([objectStoreName], READ_WRITE);
-      objectStore = trans.objectStore(objectStoreName);
+      let objectStore = trans.objectStore(objectStoreName);
 
       request = objectStore.get(fileData.key);
       request.onsuccess = grabEventAndContinueHandler;

dom/indexedDB/test/test_file_resurrection_transaction_abort.html

@@ -10,6 +10,8 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from file.js */
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const READ_WRITE = "readwrite";

dom/indexedDB/test/test_file_sharing.html

@@ -10,6 +10,8 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from file.js */
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const READ_WRITE = "readwrite";

dom/indexedDB/test/test_file_transaction_abort.html

@@ -10,6 +10,8 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from file.js */
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const READ_WRITE = "readwrite";

dom/indexedDB/test/test_filehandle_compat.html

@@ -10,6 +10,7 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css" />
 
   <script type="text/javascript">
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const name = window.location.pathname;

dom/indexedDB/test/test_filehandle_disabled_pref.html

@@ -13,6 +13,8 @@
     <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
     <script type="text/javascript">
+      /* import-globals-from file.js */
+      /* import-globals-from helpers.js */
       function* testSteps()
       {
         const databaseName = window.location.pathname;

dom/indexedDB/test/test_filehandle_getFile.html

@@ -10,6 +10,7 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css" />
 
   <script type="text/javascript">
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const name = window.location.pathname;

dom/indexedDB/test/test_filehandle_iteration.html

@@ -10,6 +10,7 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const dbName = window.location.pathname;

dom/indexedDB/test/test_filehandle_lifetimes.html

@@ -10,6 +10,7 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const name = window.location.pathname;

dom/indexedDB/test/test_filehandle_lifetimes_nested.html

@@ -10,6 +10,7 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const name = window.location.pathname;

dom/indexedDB/test/test_filehandle_location.html

@@ -10,6 +10,7 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const name = window.location.pathname;

dom/indexedDB/test/test_filehandle_ordering.html

@@ -10,6 +10,7 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const name = window.location.pathname;

dom/indexedDB/test/test_filehandle_overlapping.html

@@ -10,6 +10,7 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const name = window.location.pathname;

dom/indexedDB/test/test_filehandle_progress_events.html

@@ -10,6 +10,8 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from file.js */
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const name = window.location.pathname;

dom/indexedDB/test/test_filehandle_readonly_exceptions.html

@@ -10,6 +10,7 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const name = window.location.pathname;

dom/indexedDB/test/test_filehandle_request_readyState.html

@@ -10,6 +10,7 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const name = window.location.pathname;

dom/indexedDB/test/test_filehandle_serialization.html

@@ -10,6 +10,8 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from file.js */
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const READ_WRITE = "readwrite";

dom/indexedDB/test/test_filehandle_store_snapshot.html

@@ -10,6 +10,8 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from file.js */
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const READ_WRITE = "readwrite";

dom/indexedDB/test/test_filehandle_stream_tracking.html

@@ -10,6 +10,8 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from file.js */
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const name = window.location.pathname;

dom/indexedDB/test/test_filehandle_success_events_after_abort.html

@@ -10,6 +10,7 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const name = window.location.pathname;

dom/indexedDB/test/test_filehandle_truncate.html

@@ -10,6 +10,8 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from file.js */
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const name = window.location.pathname;

dom/indexedDB/test/test_filehandle_workers.html

@@ -10,6 +10,8 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css" />
 
   <script type="text/javascript">
+  /* import-globals-from file.js */
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const name = window.location.pathname;
@@ -43,6 +45,7 @@
     let mutableFile = event.target.result;
 
     function dummyWorkerScript() {
+      /* eslint-env worker */
       onmessage = function(event) {
         throw("Shouldn't be called!");
       }

dom/indexedDB/test/test_filehandle_write_read_data.html

@@ -10,6 +10,8 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from file.js */
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const name = window.location.pathname;

dom/indexedDB/test/test_getFileId.html

@@ -10,6 +10,8 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from file.js */
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     let id = getFileId(null);

dom/indexedDB/test/test_globalObjects_content.html

@@ -10,6 +10,7 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     const name = window.location.pathname;

dom/indexedDB/test/test_leaving_page.html

@@ -15,9 +15,10 @@
   <a id="a" href="leaving_page_iframe.html"></a>
 
   <script type="text/javascript">
-    onmessage = function(e) {
+    /* import-globals-from helpers.js */
+    window.addEventListener("message", function(e) {
       ok(false, "gotmessage: " + e.data);
-    }
+    });
 
     function* testSteps()
     {

dom/indexedDB/test/test_message_manager_ipc.html

@@ -11,6 +11,7 @@
 "use strict";
 
 function childFrameScript() {
+  /* eslint-env mozilla/frame-script */
   "use strict";
 
   const { classes: Cc, interfaces: Ci, utils: Cu } = Components;

dom/indexedDB/test/test_open_for_principal.html

@@ -10,6 +10,7 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+  /* import-globals-from helpers.js */
   function* testSteps()
   {
     is("open" in indexedDB, true, "open() defined");

dom/indexedDB/test/test_persistenceType.html

@@ -10,6 +10,7 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
 
   <script type="text/javascript">
+    /* import-globals-from helpers.js */
     function* testSteps()
     {
       const name = window.location.pathname;

dom/indexedDB/test/test_sandbox.html

@@ -70,6 +70,8 @@ function get(k) {
 function runInSandbox(sandbox, testFunc) {
   is(typeof testFunc, 'function');
   var resolvePromise;
+  // Step-done is defined in the sandbox and used in the add() function above.
+  /* global step_done */
   var testPromise = new Promise(r => resolvePromise = r);
   SpecialPowers.Cu.exportFunction(_ => resolvePromise(), sandbox,
                                   { defineAs: 'step_done' });

dom/indexedDB/test/unit/.eslintrc.js

@@ -2,14 +2,12 @@
 
 module.exports = {
   "extends": [
-    "plugin:mozilla/recommended",
     "plugin:mozilla/xpcshell-test",
   ],
   "plugins": [
     "mozilla"
   ],
   "rules": {
-    "brace-style": "off",
     "no-shadow": "off",
   }
 };

tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js

@@ -16,7 +16,9 @@ module.exports = {
     "ChromeWindow": false,
     "ChromeWorker": false,
     "Components": false,
+    "DOMRequest": false,
     "DedicatedWorkerGlobalScope": false,
+    "IDBFileRequest": false,
     "IDBLocaleAwareKeyRange": false,
     "IDBMutableFile": false,
     "ImageDocument": false,