Bug 1848325 - Part 11: Rename CommonPropertyNames with #-prefix. r=jandem

Depends on D186297

Differential Revision: https://phabricator.services.mozilla.com/D186298

js/src/frontend/Parser.cpp

@@ -7808,7 +7808,7 @@ bool GeneralParser<ParseHandler, Unit>::classMember(
     }
 
     if (handler_.isPrivateName(propName)) {
-      if (propAtom == TaggedParserAtomIndex::WellKnown::hashConstructor()) {
+      if (propAtom == TaggedParserAtomIndex::WellKnown::hash_constructor_()) {
         errorAt(propNameOffset, JSMSG_BAD_METHOD_DEF);
         return false;
       }
@@ -8039,7 +8039,7 @@ bool GeneralParser<ParseHandler, Unit>::classMember(
 
   Maybe<FunctionNodeType> initializerIfPrivate = Nothing();
   if (handler_.isPrivateName(propName)) {
-    if (propAtom == TaggedParserAtomIndex::WellKnown::hashConstructor()) {
+    if (propAtom == TaggedParserAtomIndex::WellKnown::hash_constructor_()) {
       // #constructor is an invalid private name.
       errorAt(propNameOffset, JSMSG_BAD_METHOD_DEF);
       return false;

js/src/vm/CommonPropertyNames.h

@@ -248,7 +248,7 @@
   MACRO_(h24, "h24")                                                           \
   MACRO_(Handle, "Handle")                                                     \
   MACRO_(has, "has")                                                           \
-  MACRO_(hashConstructor, "#constructor")                                      \
+  MACRO_(hash_constructor_, "#constructor")                                    \
   MACRO_(hasIndices, "hasIndices")                                             \
   MACRO_(hasOwn, "hasOwn")                                                     \
   MACRO_(hasOwnProperty, "hasOwnProperty")                                     \