From e233315d023b34ae429ebea1d5a94af6c92c999d Mon Sep 17 00:00:00 2001
From: alwu <alwu@mozilla.com>
Date: Fri, 24 May 2019 00:41:25 +0000
Subject: [PATCH] Bug 1550633 - part9 : capture 'this' in lambda. r=jya

There are too many `self` used in the lambda, we can just capture `this` to remove redudant `self`.

Differential Revision: https://phabricator.services.mozilla.com/D31558

--HG--
extra : moz-landing-system : lando
---
 dom/html/HTMLTrackElement.cpp | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/dom/html/HTMLTrackElement.cpp b/dom/html/HTMLTrackElement.cpp
index 0c12b7a09986..8d30c4991f77 100644
--- a/dom/html/HTMLTrackElement.cpp
+++ b/dom/html/HTMLTrackElement.cpp
@@ -345,32 +345,31 @@ void HTMLTrackElement::LoadResource(RefPtr<WebVTTListener>&& aWebVTTListener) {
   // 9. End the synchronous section, continuing the remaining steps in parallel.
   nsCOMPtr<nsIRunnable> runnable = NS_NewRunnableFunction(
       "dom::HTMLTrackElement::LoadResource",
-      [self = RefPtr<HTMLTrackElement>(this), uri, secFlags]() {
-        if (!self->mListener) {
+      [self = RefPtr<HTMLTrackElement>(this), this, uri, secFlags]() {
+        if (!mListener) {
           // Shutdown got called, abort.
           return;
         }
         nsCOMPtr<nsIChannel> channel;
-        nsCOMPtr<nsILoadGroup> loadGroup =
-            self->OwnerDoc()->GetDocumentLoadGroup();
+        nsCOMPtr<nsILoadGroup> loadGroup = OwnerDoc()->GetDocumentLoadGroup();
         nsresult rv = NS_NewChannel(getter_AddRefs(channel), uri,
-                                    static_cast<Element*>(self), secFlags,
+                                    static_cast<Element*>(this), secFlags,
                                     nsIContentPolicy::TYPE_INTERNAL_TRACK,
                                     nullptr,  // PerformanceStorage
                                     loadGroup);
 
         NS_ENSURE_TRUE_VOID(NS_SUCCEEDED(rv));
 
-        channel->SetNotificationCallbacks(self->mListener);
+        channel->SetNotificationCallbacks(mListener);
 
         LOG(LogLevel::Debug, ("opening webvtt channel"));
-        rv = channel->AsyncOpen(self->mListener);
+        rv = channel->AsyncOpen(mListener);
 
         if (NS_FAILED(rv)) {
-          self->SetReadyState(TextTrackReadyState::FailedToLoad);
+          SetReadyState(TextTrackReadyState::FailedToLoad);
           return;
         }
-        self->mChannel = channel;
+        mChannel = channel;
       });
   doc->Dispatch(TaskCategory::Other, runnable.forget());
 }