From e24817e83e4c6317fe8d5b9a37b4a95ab3dec0ab Mon Sep 17 00:00:00 2001 From: William Lachance Date: Tue, 16 Aug 2016 13:30:06 -0400 Subject: [PATCH] Bug 1295536 - Update performance schema to treeherder latest;r=jmaher This new version of the schema validates that numeric values are within an acceptable range (i.e. are not infinite) MozReview-Commit-ID: 32oT39Bfcwg --HG-- extra : rebase_source : 78ef5402e47e05f3f4e5a1db7b36e2d365c7b13b --- .../performance-artifact-schema.json | 40 ++++++++++++++----- 1 file changed, 30 insertions(+), 10 deletions(-) diff --git a/testing/mozharness/external_tools/performance-artifact-schema.json b/testing/mozharness/external_tools/performance-artifact-schema.json index dc69996baa5d..f79a0419b894 100644 --- a/testing/mozharness/external_tools/performance-artifact-schema.json +++ b/testing/mozharness/external_tools/performance-artifact-schema.json @@ -18,7 +18,9 @@ "value": { "description": "Summary value for subtest", "title": "Subtest value", - "type": "number" + "type": "number", + "minimum": -1000000000000.0, + "maximum": 1000000000000.0 }, "lowerIsBetter": { "description": "Whether lower values are better for subtest", @@ -33,22 +35,30 @@ "alertThreshold": { "description": "% change threshold before alerting", "title": "Alert threshold", - "type": "number" + "type": "number", + "minimum": 0.0, + "maximum": 1000.0 }, "minBackWindow": { "description": "Minimum back window to use for alerting", "title": "Minimum back window", - "type": "number" + "type": "number", + "minimum": 1, + "maximum": 255 }, "maxBackWindow": { "description": "Maximum back window to use for alerting", "title": "Maximum back window", - "type": "number" + "type": "number", + "minimum": 1, + "maximum": 255 }, "foreWindow": { "description": "Fore window to use for alerting", "title": "Fore window", - "type": "number" + "type": "number", + "minimum": 1, + "maximum": 255 } }, "required": [ @@ -80,7 +90,9 @@ }, "value": { "title": "Suite value", - "type": "number" + "type": "number", + "minimum": -1000000000000.0, + "maximum": 1000000000000.0 }, "lowerIsBetter": { "description": "Whether lower values are better for suite", @@ -95,22 +107,30 @@ "alertThreshold": { "description": "% change threshold before alerting", "title": "Alert threshold", - "type": "number" + "type": "number", + "minimum": 0.0, + "maximum": 1000.0 }, "minBackWindow": { "description": "Minimum back window to use for alerting", "title": "Minimum back window", - "type": "number" + "type": "integer", + "minimum": 1, + "maximum": 255 }, "maxBackWindow": { "description": "Maximum back window to use for alerting", "title": "Maximum back window", - "type": "number" + "type": "integer", + "minimum": 1, + "maximum": 255 }, "foreWindow": { "description": "Fore window to use for alerting", "title": "Fore window", - "type": "number" + "type": "integer", + "minimum": 1, + "maximum": 255 } }, "required": [