Bug 1765456 - Move the cancel icon used by about:newtab to the shared icon library in toolkit/themes/shared/icons r=sfoster,desktop-theme-reviewers

This was done because the existing cancel icon (browser/components/newtab/data/content/assets/glyph-cancel-16.svg) is a variation of the (/toolkit/themes/shared/icons/close.svg) in the toolkil icon library and it makes sense for the former to live alongside the latter.

Differential Revision: https://phabricator.services.mozilla.com/D144075

browser/components/newtab/content-src/styles/_icons.scss

@@ -39,7 +39,7 @@
   }
 
   &.icon-clear-input {
-    background-image: url('chrome://activity-stream/content/data/content/assets/glyph-cancel-16.svg');
+    background-image: url('chrome://global/skin/icons/close-fill.svg');
   }
 
   &.icon-delete {

browser/components/newtab/css/activity-stream-linux.css

@@ -108,7 +108,7 @@ body[lwt-newtab-brighttext] {
   background-image: url("chrome://browser/skin/bookmark-hollow.svg");
 }
 .icon.icon-clear-input {
-  background-image: url("chrome://activity-stream/content/data/content/assets/glyph-cancel-16.svg");
+  background-image: url("chrome://global/skin/icons/close-fill.svg");
 }
 .icon.icon-delete {
   background-image: url("chrome://global/skin/icons/delete.svg");

browser/components/newtab/css/activity-stream-mac.css

@@ -112,7 +112,7 @@ body[lwt-newtab-brighttext] {
   background-image: url("chrome://browser/skin/bookmark-hollow.svg");
 }
 .icon.icon-clear-input {
-  background-image: url("chrome://activity-stream/content/data/content/assets/glyph-cancel-16.svg");
+  background-image: url("chrome://global/skin/icons/close-fill.svg");
 }
 .icon.icon-delete {
   background-image: url("chrome://global/skin/icons/delete.svg");

browser/components/newtab/css/activity-stream-windows.css

@@ -108,7 +108,7 @@ body[lwt-newtab-brighttext] {
   background-image: url("chrome://browser/skin/bookmark-hollow.svg");
 }
 .icon.icon-clear-input {
-  background-image: url("chrome://activity-stream/content/data/content/assets/glyph-cancel-16.svg");
+  background-image: url("chrome://global/skin/icons/close-fill.svg");
 }
 .icon.icon-delete {
   background-image: url("chrome://global/skin/icons/delete.svg");

toolkit/themes/shared/desktop-jar.inc.mn

@@ -57,6 +57,7 @@
   skin/classic/global/icons/check-partial.svg              (../../shared/icons/check-partial.svg)
   skin/classic/global/icons/chevron.svg                    (../../shared/icons/chevron.svg)
   skin/classic/global/icons/close.svg                      (../../shared/icons/close.svg)
+  skin/classic/global/icons/close-fill.svg                 (../../shared/icons/close-fill.svg)
   skin/classic/global/icons/columnpicker.svg               (../../shared/icons/columnpicker.svg)
   skin/classic/global/icons/defaultFavicon.svg             (../../shared/icons/defaultFavicon.svg)
   skin/classic/global/icons/delete.svg                     (../../shared/icons/delete.svg)