From e3e655516ae4c682ba1c256a9244b2cb75839364 Mon Sep 17 00:00:00 2001 From: "bbaetz%student.usyd.edu.au" Date: Mon, 8 Jul 2002 06:10:47 +0000 Subject: [PATCH] Bug 105472 - expectbigqueries unnecessary with mysql >=3.23.2 r=jouni x2 --- webtools/bugzilla/buglist.cgi | 4 ---- webtools/bugzilla/defparams.pl | 5 ----- webtools/bugzilla/sanitycheck.cgi | 2 -- 3 files changed, 11 deletions(-) diff --git a/webtools/bugzilla/buglist.cgi b/webtools/bugzilla/buglist.cgi index c2d44de12dc5..9638d9c0fb2e 100755 --- a/webtools/bugzilla/buglist.cgi +++ b/webtools/bugzilla/buglist.cgi @@ -1397,10 +1397,6 @@ if ($serverpush) { # query performance. ReconnectToShadowDatabase(); -# Tell MySQL to store temporary tables on the hard drive instead of memory -# to avoid "table out of space" errors on MySQL versions less than 3.23.2. -SendSQL("SET OPTION SQL_BIG_TABLES=1") if Param('expectbigqueries'); - # Normally, we ignore SIGTERM and SIGPIPE (see globals.pl) but we need to # respond to them here to prevent someone DOSing us by reloading a query # a large number of times. diff --git a/webtools/bugzilla/defparams.pl b/webtools/bugzilla/defparams.pl index 30a7b5fc0aa8..9fe4c186ec2b 100644 --- a/webtools/bugzilla/defparams.pl +++ b/webtools/bugzilla/defparams.pl @@ -449,11 +449,6 @@ sub check_webdotbase { return ""; } -DefParam("expectbigqueries", - "If this is on, then we will tell mysql to set option SQL_BIG_TABLES=1 before doing queries on bugs. This will be a little slower, but one will not get the error The table ### is full for big queries that require a big temporary table.", - "b", - 0); - DefParam("emailregexp", 'This defines the regexp to use for legal email addresses. The default tries to match fully qualified email addresses. Another popular value to put here is ^[^@]+$, which means "local usernames, no @ allowed."', "t", diff --git a/webtools/bugzilla/sanitycheck.cgi b/webtools/bugzilla/sanitycheck.cgi index 706d7dff5aeb..72a9137fd2c9 100755 --- a/webtools/bugzilla/sanitycheck.cgi +++ b/webtools/bugzilla/sanitycheck.cgi @@ -49,8 +49,6 @@ UserInGroup("editbugs") print "Content-type: text/html\n"; print "\n"; -SendSQL("set SQL_BIG_TABLES=1"); - my $offervotecacherebuild = 0; sub Status {