From e489736f600e74245bd2049270c69b891c9fc0f2 Mon Sep 17 00:00:00 2001 From: Mike Hommey Date: Thu, 10 Jan 2019 00:07:53 +0000 Subject: [PATCH] Bug 1518703 - Remove R_386_PC32 check. r=froydnj,ted The test is actually redundant with the TEXTREL check in check_binary.py (R_386_PC32 relocations will only happen as text relocations) Differential Revision: https://phabricator.services.mozilla.com/D16002 --HG-- extra : moz-landing-system : lando --- Makefile.in | 7 ------- 1 file changed, 7 deletions(-) diff --git a/Makefile.in b/Makefile.in index 4f1af53f9a93..f4669c46695e 100644 --- a/Makefile.in +++ b/Makefile.in @@ -292,13 +292,6 @@ endif # NO_PROFILE_GUIDED_OPTIMIZE .PHONY: maybe_clobber_profiledbuild -# Look for R_386_PC32 relocations in shared libs, these -# break x86_64 builds and SELinux users. -ifeq ($(OS_TARGET)_$(TARGET_XPCOM_ABI),Linux_x86-gcc3) -check:: - @relcount=`find $(DIST)/bin -name '*.so' | xargs objdump -R | grep R_386_PC32 | wc -l` && if test $$relcount -gt 0; then echo 'FAILED: R_386_PC32 relocations detected in a shared library. Did you use a system header without adding it to config/system-headers?'; exit 1; else echo 'PASSED'; fi -endif - ifdef JS_STANDALONE # Delegate js-specific rules to js check-%: