From e4b2f13ece481c873631f4817b9c229375db3086 Mon Sep 17 00:00:00 2001 From: "jshin%mailaps.org" Date: Sun, 17 Sep 2006 05:35:16 +0000 Subject: [PATCH] bug 250255 : get rid of a redundant check of 'registry type' in GetSourceHomePageURL (addressing reviewer's comment I missed in the previous check-in) --- browser/components/migration/src/nsIEProfileMigrator.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/browser/components/migration/src/nsIEProfileMigrator.cpp b/browser/components/migration/src/nsIEProfileMigrator.cpp index 5706c649579a..1766f91f2b5e 100644 --- a/browser/components/migration/src/nsIEProfileMigrator.cpp +++ b/browser/components/migration/src/nsIEProfileMigrator.cpp @@ -517,10 +517,7 @@ nsIEProfileMigrator::GetSourceHomePageURL(nsACString& aResult) // read registry data NS_NAMED_LITERAL_STRING(homeURLValName, "Start Page"); nsAutoString homeURLVal; - PRUint32 type; - if (NS_SUCCEEDED(regKey->GetValueType(homeURLValName, &type)) && - type == nsIWindowsRegKey::TYPE_STRING && - NS_SUCCEEDED(regKey->ReadStringValue(homeURLValName, homeURLVal))) { + if (NS_SUCCEEDED(regKey->ReadStringValue(homeURLValName, homeURLVal))) { // Do we need this round-about way to get |homePageURL|? // Perhaps, we do to have the form of URL under our control // (cf. network.standard-url.escape-utf8)