From e5bc6dcf33fbf451aefdace129e67b3fb357c916 Mon Sep 17 00:00:00 2001
From: "Brian R. Bondy" <netzen@gmail.com>
Date: Thu, 23 Aug 2012 22:22:14 -0400
Subject: [PATCH] Bug 784414 - Ensure cache clean file is open before seeking
 in it. r=michal

---
 netwerk/cache/nsDiskCacheMap.cpp | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/netwerk/cache/nsDiskCacheMap.cpp b/netwerk/cache/nsDiskCacheMap.cpp
index e7b610fcee32..848bc62d5832 100644
--- a/netwerk/cache/nsDiskCacheMap.cpp
+++ b/netwerk/cache/nsDiskCacheMap.cpp
@@ -197,6 +197,7 @@ error_exit:
 nsresult
 nsDiskCacheMap::Close(bool flush)
 {
+    nsCacheService::AssertOwnsLock();
     nsresult  rv = NS_OK;
 
     // Cancel any pending cache validation event, the FlushRecords call below
@@ -1274,23 +1275,28 @@ nsresult
 nsDiskCacheMap::WriteCacheClean(bool clean)
 {
     nsCacheService::AssertOwnsLock();
+    if (!mCleanFD) {
+        NS_WARNING("Cache clean file is not open!");
+        return NS_ERROR_FAILURE;
+    }
+
     CACHE_LOG_DEBUG(("CACHE: WriteCacheClean: %d\n", clean? 1 : 0));
     // I'm using a simple '1' or '0' to denote cache clean
     // since it can be edited easily by any text editor for testing.
     char data = clean? '1' : '0';
     int32_t filePos = PR_Seek(mCleanFD, 0, PR_SEEK_SET);
     if (filePos != 0) {
-        NS_WARNING("Could not seek in cache map file!");
+        NS_WARNING("Could not seek in cache clean file!");
         return NS_ERROR_FAILURE;
     }
     int32_t bytesWritten = PR_Write(mCleanFD, &data, 1);
     if (bytesWritten != 1) {
-        NS_WARNING("Could not write cache map file!");
+        NS_WARNING("Could not write cache clean file!");
         return NS_ERROR_FAILURE;
     }
     PRStatus err = PR_Sync(mCleanFD);
     if (err != PR_SUCCESS) {
-        NS_WARNING("Could not flush mCleanFD!");
+        NS_WARNING("Could not flush cache clean file!");
     }
 
     return NS_OK;