Bug 1536631 - Part 7: Fix some test-cases that were expecting InvalidStateError when they should have been expecting InvalidModificationError. r=jib

Rebasing on top of bug 1531110 found some more bugs, and more bad tests.

Differential Revision: https://phabricator.services.mozilla.com/D25478

--HG--
extra : moz-landing-system : lando

dom/media/tests/mochitest/test_peerConnection_setLocalAnswerInHaveLocalOffer.html

@@ -21,7 +21,7 @@ runNetworkTest(function () {
       test.pcLocal._latest_offer.type = "answer";
       return test.pcLocal.setLocalDescriptionAndFail(test.pcLocal._latest_offer)
         .then(err => {
-          is(err.name, "InvalidStateError", "Error is InvalidStateError");
+          is(err.name, "InvalidModificationError", "Error is InvalidModificationError");
         });
     }
   ]);

dom/media/tests/mochitest/test_peerConnection_setLocalAnswerInStable.html

@@ -21,7 +21,7 @@ runNetworkTest(function () {
       test.pcLocal._latest_offer.type = "answer";
       return test.pcLocal.setLocalDescriptionAndFail(test.pcLocal._latest_offer)
         .then(err => {
-          is(err.name, "InvalidStateError", "Error is InvalidStateError");
+          is(err.name, "InvalidModificationError", "Error is InvalidModificationError");
         });
     }
   ]);

media/webrtc/signaling/gtest/jsep_session_unittest.cpp

@@ -5288,7 +5288,7 @@ TEST_F(JsepSessionTest, SetLocalAnswerInHaveLocalOffer) {
   // SetLocalDescription call fails.
   JsepSession::Result result =
       mSessionOff->SetLocalDescription(kJsepSdpAnswer, offer);
-  ASSERT_EQ(dom::PCError::InvalidStateError, *result.mError);
+  ASSERT_EQ(dom::PCError::InvalidModificationError, *result.mError);
   ASSERT_EQ(kJsepStateHaveLocalOffer, mSessionOff->GetState());
 }
 
@@ -5320,7 +5320,7 @@ TEST_F(JsepSessionTest, SetLocalOfferInHaveRemoteOffer) {
   // SetLocalDescription call fails.
   JsepSession::Result result =
       mSessionAns->SetLocalDescription(kJsepSdpOffer, offer);
-  ASSERT_EQ(dom::PCError::InvalidStateError, *result.mError);
+  ASSERT_EQ(dom::PCError::InvalidModificationError, *result.mError);
   ASSERT_EQ(kJsepStateHaveRemoteOffer, mSessionAns->GetState());
 }
 

testing/web-platform/tests/webrtc/RTCPeerConnection-setLocalDescription-answer.html

@@ -153,9 +153,9 @@
 
     return pc.createOffer()
     .then(offer =>
-      promise_rejects(t, 'InvalidStateError',
+      promise_rejects(t, 'InvalidModificationError',
         pc.setLocalDescription({ type: 'answer', sdp: offer.sdp })));
-  }, 'Calling setLocalDescription(answer) from stable state should reject with InvalidStateError');
+  }, 'Calling setLocalDescription(answer) from stable state should reject with InvalidModificationError');
 
   promise_test(t => {
     const pc = new RTCPeerConnection();
@@ -167,9 +167,9 @@
       pc.setLocalDescription(offer)
       .then(() => generateAnswer(offer)))
     .then(answer =>
-      promise_rejects(t, 'InvalidStateError',
+      promise_rejects(t, 'InvalidModificationError',
         pc.setLocalDescription(answer)));
-  }, 'Calling setLocalDescription(answer) from have-local-offer state should reject with InvalidStateError');
+  }, 'Calling setLocalDescription(answer) from have-local-offer state should reject with InvalidModificationError');
 
   promise_test(async t => {
     const pc1 = new RTCPeerConnection();