Backed out changeset fae91b8aa3d7 (bug 1539647) for eslint falure at /content/browser-toolbarKeyNav.js on a CLOSED TREE.

browser/base/content/browser-toolbarKeyNav.js

@@ -51,8 +51,7 @@ ToolbarKeyboardNavigator = {
       }
 
       // Skip invisible or disabled elements.
-      if (aNode.hidden || aNode.disabled
-          || aNode.style["visibility"] == "hidden") {
+      if (aNode.hidden || aNode.disabled) {
         return NodeFilter.FILTER_REJECT;
       }
       // This width check excludes the overflow button when there's no overflow.

browser/base/content/test/keyboard/browser_toolbarKeyNav.js

@@ -75,8 +75,6 @@ function withNewBlankTab(taskFn) {
   });
 }
 
-const BOOKMARKS_COUNT = 100;
-
 add_task(async function setup() {
   await SpecialPowers.pushPrefEnv({
     set: [
@@ -85,17 +83,6 @@ add_task(async function setup() {
     ],
   });
   resetToolbarWithoutDevEditionButtons();
-
-  await PlacesUtils.bookmarks.eraseEverything();
-  // Add bookmarks.
-  let bookmarks = new Array(BOOKMARKS_COUNT);
-  for (let i = 0; i < BOOKMARKS_COUNT; ++i) {
-    bookmarks[i] = {url: `http://test.places.${i}/`};
-  }
-  await PlacesUtils.bookmarks.insertTree({
-    guid: PlacesUtils.bookmarks.toolbarGuid,
-    children: bookmarks,
-  });
 });
 
 // Test tab stops with no page loaded.
@@ -292,27 +279,4 @@ add_task(async function testArrowsRtl() {
   await SpecialPowers.popPrefEnv();
 });
 
-// Test that right arrow reaches the overflow menu button on the Bookmarks
-// toolbar when it is visible.
-add_task(async function testArrowsBookmarksOverflowButton() {
-  let toolbar = document.getElementById("PersonalToolbar");
-  let transitionEnded = BrowserTestUtils.waitForEvent(toolbar, "transitionend");
-  CustomizableUI.setToolbarVisibility("PersonalToolbar", true);
-  await transitionEnded;
-  let items = document.getElementById("PlacesToolbarItems").children;
-  let lastVisible;
-  for (let item of items) {
-    if (item.style.visibility == "hidden") {
-      break;
-    }
-    lastVisible = item;
-  }
-  forceFocus(lastVisible);
-  await expectFocusAfterKey("ArrowRight", "PlacesChevron");
-  CustomizableUI.setToolbarVisibility("PersonalToolbar", false);
-});
-
-registerCleanupFunction(async function () {
-  CustomizableUI.reset();
-  await PlacesUtils.bookmarks.eraseEverything();
-});
+registerCleanupFunction(() => CustomizableUI.reset());