From e66b9f76e69b7c5f985fc912aa4524893ea3b56a Mon Sep 17 00:00:00 2001 From: Jono S Xia Date: Mon, 19 Jul 2010 15:47:12 -0700 Subject: [PATCH] Bug 579688: Notification about study about to start should say "about to start", not "is starting". r=dtownsend --- .../testpilot@labs.mozilla.com/content/experiment-page.js | 2 ++ .../extensions/testpilot@labs.mozilla.com/modules/setup.js | 2 +- browser/locales/en-US/feedback/main.properties | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/browser/app/profile/extensions/testpilot@labs.mozilla.com/content/experiment-page.js b/browser/app/profile/extensions/testpilot@labs.mozilla.com/content/experiment-page.js index a99889410135..c770648047bc 100644 --- a/browser/app/profile/extensions/testpilot@labs.mozilla.com/content/experiment-page.js +++ b/browser/app/profile/extensions/testpilot@labs.mozilla.com/content/experiment-page.js @@ -367,6 +367,8 @@ var stringBundle; var contentDiv = document.getElementById("experiment-specific-text"); var dataPrivacyDiv = document.getElementById("data-privacy-text"); // Get experimentID from the GET args of page + // TODO no reason actually to do parseInt here -- all it accomplishes + // is preventing us from using non-numeric study IDs. var eid = parseInt(getUrlParam("eid")); var experiment = TestPilotSetup.getTaskById(eid); if (!experiment) { diff --git a/browser/app/profile/extensions/testpilot@labs.mozilla.com/modules/setup.js b/browser/app/profile/extensions/testpilot@labs.mozilla.com/modules/setup.js index 2ac95d173c19..f6fa0cc011d7 100644 --- a/browser/app/profile/extensions/testpilot@labs.mozilla.com/modules/setup.js +++ b/browser/app/profile/extensions/testpilot@labs.mozilla.com/modules/setup.js @@ -561,7 +561,7 @@ let TestPilotSetup = { this._showNotification( task, false, this._stringBundle.formatStringFromName( - "testpilot.notification.newTestPilotStudy.message", + "testpilot.notification.newTestPilotStudy.pre.message", [task.title], 1), this._stringBundle.GetStringFromName( "testpilot.notification.newTestPilotStudy"), diff --git a/browser/locales/en-US/feedback/main.properties b/browser/locales/en-US/feedback/main.properties index 1ef8e949eb4a..a7d9e9e7eeb3 100644 --- a/browser/locales/en-US/feedback/main.properties +++ b/browser/locales/en-US/feedback/main.properties @@ -83,7 +83,7 @@ testpilot.notification.thankYouForUploadingData.message = Thank you for uploadin testpilot.notification.readyToSubmit = Ready to Submit testpilot.notification.readyToSubmit.message = The Test Pilot "%S" study is finished gathering data and is ready to submit. testpilot.notification.newTestPilotStudy = New Test Pilot Study -testpilot.notification.newTestPilotStudy.message = The Test Pilot "%S" study is now beginning. +testpilot.notification.newTestPilotStudy.pre.message = The Test Pilot "%S" study is about to begin. testpilot.notification.newTestPilotSurvey = New Test Pilot Survey testpilot.notification.newTestPilotSurvey.message = The Test Pilot "%S" survey is available. testpilot.notification.newTestPilotResults = New Test Pilot Results