diff --git a/webtools/testopia/Bugzilla/Testopia/Table.pm b/webtools/testopia/Bugzilla/Testopia/Table.pm index 5b643c96ea4d..3bd077a3d685 100644 --- a/webtools/testopia/Bugzilla/Testopia/Table.pm +++ b/webtools/testopia/Bugzilla/Testopia/Table.pm @@ -410,7 +410,7 @@ sub get_url { } my @vals = $cgi->param($key); foreach my $val (@vals){ - $qstring .= $key ."=". $val ."&"; + $qstring .= $key ."=". url_quote($val) ."&"; } } chop $qstring; @@ -427,7 +427,7 @@ sub get_query_part { foreach my $key (@keys){ my @vals = $cgi->param($key); foreach my $val (@vals){ - $qstring .= $key ."=". $val ."&"; + $qstring .= $key ."=". url_quote($val) ."&"; } } chop $qstring; diff --git a/webtools/testopia/template/en/default/hook/global/user-error.html.tmpl/errors/tr-user-error.html.tmpl b/webtools/testopia/template/en/default/hook/global/user-error.html.tmpl/errors/tr-user-error.html.tmpl index bfeb0f31f329..61352c7ee3b8 100644 --- a/webtools/testopia/template/en/default/hook/global/user-error.html.tmpl/errors/tr-user-error.html.tmpl +++ b/webtools/testopia/template/en/default/hook/global/user-error.html.tmpl/errors/tr-user-error.html.tmpl @@ -124,6 +124,9 @@ [% ELSIF error == "testopia-plan-acl-denied" %] [% title = "Plan Administrator Privileges Required" %] You must be an administrator of this test plan to modify the access control list. + [% ELSIF error == "testopia-no-admins" %] + [% title = "Plan Must Have at Least One Admin" %] + There do not seem to be any admins selected. You must select at least one admin for this test plan. [% ELSIF error == "testopia-format-error" %] [% title = "Field format error" %] [% field %] is not formatted correctly. diff --git a/webtools/testopia/template/en/default/testopia/caserun/short-form.html.tmpl b/webtools/testopia/template/en/default/testopia/caserun/short-form.html.tmpl index 3f40f154d855..7f7608812dd6 100644 --- a/webtools/testopia/template/en/default/testopia/caserun/short-form.html.tmpl +++ b/webtools/testopia/template/en/default/testopia/caserun/short-form.html.tmpl @@ -22,7 +22,7 @@ [%##### BEGIN Hidden Pane #####%] -
+
[%##### Action, Expected Results #####%] @@ -76,7 +76,7 @@ [% status.name FILTER none %] (disabled) [% ELSE %] - + [% status.name FILTER none %] [% END %] diff --git a/webtools/testopia/template/en/default/testopia/plan/show.html.tmpl b/webtools/testopia/template/en/default/testopia/plan/show.html.tmpl index dd764b82c227..9aa95a0bc03b 100644 --- a/webtools/testopia/template/en/default/testopia/plan/show.html.tmpl +++ b/webtools/testopia/template/en/default/testopia/plan/show.html.tmpl @@ -166,9 +166,9 @@
- - - + + + -
CategoriesTagsBuildsCategoriesTagsBuilds
diff --git a/webtools/testopia/template/en/default/testopia/run/show.html.tmpl b/webtools/testopia/template/en/default/testopia/run/show.html.tmpl index 87d7767ce5a9..613925254a5a 100644 --- a/webtools/testopia/template/en/default/testopia/run/show.html.tmpl +++ b/webtools/testopia/template/en/default/testopia/run/show.html.tmpl @@ -45,7 +45,7 @@ @@ -75,7 +75,7 @@ var id = newcc[i].childNodes[0].firstChild.nodeValue; var name = newcc[i].childNodes[1].firstChild.nodeValue; var myOp = new Option(name, id); - cc.add(myOp,null); + addOption(cc,myOp); } document.getElementById("newcc").value = ''; document.getElementById("addCC").disabled = false; @@ -91,7 +91,7 @@ url: "tr_show_run.cgi", content: { cc: cctext, run_id: [% run.id FILTER none %], action: action }, load: function(type, data, evt){ fillcc(data);}, - error: function(type, error){ alert("ERROR");}, + error: function(type, error){ alert(error.message);}, mimetype: "text/xml" }); } @@ -146,7 +146,7 @@
[% run.manager.identity FILTER html %] + [% PROCESS testopia/percent_bar.html.tmpl percent = run.percent_complete %] @@ -213,9 +213,9 @@
- - - + + + diff --git a/webtools/testopia/template/en/default/testopia/saved-search.html.tmpl b/webtools/testopia/template/en/default/testopia/saved-search.html.tmpl index 2f8b8d52584e..6c1a640ea36e 100644 --- a/webtools/testopia/template/en/default/testopia/saved-search.html.tmpl +++ b/webtools/testopia/template/en/default/testopia/saved-search.html.tmpl @@ -20,7 +20,7 @@
CC ListCase Run StatusTagsCC ListCase Run StatusTags
@@ -283,7 +283,6 @@
[% PROCESS testopia/tag/table.html.tmpl item = run - type = 'run' %]