Bug 1467643 - remove 'help' accessibility property from accessibility inspector. r=pbro

MozReview-Commit-ID: LtmD38VC8sN

devtools/client/accessibility/constants.js

@@ -38,7 +38,6 @@ exports.ORDERED_PROPS = [
   "value",
   "DOMNode",
   "description",
-  "help",
   "keyboardShortcut",
   "childCount",
   "indexInParent",
@@ -52,7 +51,6 @@ exports.ACCESSIBLE_EVENTS = [
   "actions-change",
   "attributes-change",
   "description-change",
-  "help-change",
   "name-change",
   "reorder",
   "shortcut-change",

devtools/client/accessibility/test/browser/browser.ini

@@ -4,6 +4,8 @@ subsuite = devtools
 support-files =
   head.js
   !/devtools/client/shared/test/shared-head.js
+  !/devtools/client/shared/test/test-actor.js
+  !/devtools/client/shared/test/test-actor-registry.js
   !/devtools/client/inspector/test/shared-head.js
   !/devtools/client/shared/test/shared-redux-head.js
   !/devtools/client/shared/test/telemetry-test-helpers.js

devtools/client/accessibility/test/browser/browser_accessibility_mutations.js

@@ -50,7 +50,6 @@ const tests = [{
       actions: [],
       value: "",
       description: "",
-      help: "",
       keyboardShortcut: "",
       childCount: 1,
       indexInParent: 1,

devtools/client/accessibility/test/browser/browser_accessibility_sidebar.js

@@ -29,7 +29,6 @@ const tests = [{
       actions: [],
       value: "",
       description: "",
-      help: "",
       keyboardShortcut: "",
       childCount: 0,
       indexInParent: 0,

devtools/client/accessibility/test/browser/browser_accessibility_tree_nagivation.js

@@ -36,7 +36,6 @@ const tests = [{
       actions: [],
       value: "",
       description: "",
-      help: "",
       keyboardShortcut: "",
       childCount: 2,
       indexInParent: 0,
@@ -81,7 +80,6 @@ const tests = [{
       actions: [],
       value: "",
       description: "",
-      help: "",
       keyboardShortcut: "",
       childCount: 1,
       indexInParent: 0,
@@ -98,7 +96,6 @@ const tests = [{
       actions: [],
       value: "",
       description: "",
-      help: "",
       keyboardShortcut: "",
       childCount: 0,
       indexInParent: 0,
@@ -119,7 +116,6 @@ const tests = [{
       actions: [],
       value: "",
       description: "",
-      help: "",
       keyboardShortcut: "",
       childCount: 2,
       indexInParent: 0,

devtools/server/actors/accessibility.js

@@ -37,7 +37,6 @@ const {
   EVENT_DEFACTION_CHANGE,
   EVENT_DESCRIPTION_CHANGE,
   EVENT_DOCUMENT_ATTRIBUTES_CHANGED,
-  EVENT_HELP_CHANGE,
   EVENT_HIDE,
   EVENT_NAME_CHANGE,
   EVENT_OBJECT_ATTRIBUTE_CHANGED,
@@ -234,13 +233,6 @@ const AccessibleActor = ActorClassWithSpec(accessibleSpec, {
     return this.rawAccessible.description;
   },
 
-  get help() {
-    if (this.isDefunct) {
-      return null;
-    }
-    return this.rawAccessible.help;
-  },
-
   get keyboardShortcut() {
     if (this.isDefunct) {
       return null;
@@ -366,7 +358,6 @@ const AccessibleActor = ActorClassWithSpec(accessibleSpec, {
       name: this.name,
       value: this.value,
       description: this.description,
-      help: this.help,
       keyboardShortcut: this.keyboardShortcut,
       childCount: this.childCount,
       domNodeType: this.domNodeType,
@@ -649,11 +640,6 @@ const AccessibleWalkerActor = ActorClassWithSpec(accessibleWalkerSpec, {
           events.emit(accessible, "description-change", rawAccessible.description);
         }
         break;
-      case EVENT_HELP_CHANGE:
-        if (accessible) {
-          events.emit(accessible, "help-change", rawAccessible.help);
-        }
-        break;
       case EVENT_REORDER:
         if (accessible) {
           accessible.children().forEach(child =>

devtools/server/tests/browser/browser_accessibility_node.js

@@ -21,7 +21,6 @@ add_task(async function() {
     role: "pushbutton",
     value: "",
     description: "Accessibility Test",
-    help: "",
     keyboardShortcut: modifiers + "b",
     childCount: 1,
     domNodeType: 1,

devtools/server/tests/browser/browser_accessibility_node_events.js

@@ -26,7 +26,6 @@ add_task(async function() {
     role: "pushbutton",
     value: "",
     description: "Accessibility Test",
-    help: "",
     keyboardShortcut: modifiers + "b",
     childCount: 1,
     domNodeType: 1,

devtools/shared/fronts/accessibility.js

@@ -41,10 +41,6 @@ const AccessibleFront = FrontClassWithSpec(accessibleSpec, {
     return this._form.description;
   },
 
-  get help() {
-    return this._form.help;
-  },
-
   get keyboardShortcut() {
     return this._form.keyboardShortcut;
   },
@@ -100,10 +96,6 @@ const AccessibleFront = FrontClassWithSpec(accessibleSpec, {
     this._form.description = description;
   }),
 
-  helpChange: preEvent("help-change", function(help) {
-    this._form.help = help;
-  }),
-
   shortcutChange: preEvent("shortcut-change", function(keyboardShortcut) {
     this._form.keyboardShortcut = keyboardShortcut;
   }),

devtools/shared/specs/accessibility.js

@@ -50,10 +50,6 @@ const accessibleSpec = generateActorSpec({
       type: "attributesChange",
       attributes: Arg(0, "json")
     },
-    "help-change": {
-      type: "helpChange",
-      help: Arg(0, "string")
-    },
     "shortcut-change": {
       type: "shortcutChange",
       shortcut: Arg(0, "string")