mozilla
/
gecko-dev
зеркало из https://github.com/mozilla/gecko-dev.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность

Bug 1781321: Fix devtools browser a11y tests for img elements with no alt text, r=morgan 

This revision fixes these failing tests. I made a change in Bug 1748585 which
causes img elements with alt="" to be considered decorative (in most cases).
These tests rely on the accessible existing in the tree, so I've removed them.
I don't think it makes sense to test this any more. FWIW, I've made the same
changes to accessibility tests in the accessible directory.

Differential Revision: https://phabricator.services.mozilla.com/D161331
This commit is contained in:
Nathan LaPre 2022-11-05 00:47:45 +00:00
Родитель 98bc40ef41
Коммит e8b85b1993
2 изменённых файлов: 18 добавлений и 22 удалений
Показать статистику Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

16
devtools/server/tests/browser/browser_accessibility_text_label_audit.js
Просмотреть файл

@ -323,27 +323,26 @@ add_task(async function() {
["Image with aria-label", "#img-2", null],
["Image with aria-labelledby", "#img-3", null],
["Image with alt text", "#img-4", null],
["Image with empty alt text", "#img-5", null],
[
"Image with aria-labelledby an element with empty content",
"#img-6",
"#img-5",
{ score: FAIL, issue: IMAGE_NO_NAME },
],
[
"Aria image with no name",
"#img-7",
"#img-6",
{ score: FAIL, issue: IMAGE_NO_NAME },
],
["Aria image with aria-label", "#img-8", null],
["Aria image with aria-labelledby", "#img-9", null],
["Aria image with aria-label", "#img-7", null],
["Aria image with aria-labelledby", "#img-8", null],
[
"Aria image with empty aria-label",
"#img-10",
"#img-9",
{ score: FAIL, issue: IMAGE_NO_NAME },
],
[
"Aria image with aria-labelledby an element with empty content",
"#img-11",
"#img-10",
{ score: FAIL, issue: IMAGE_NO_NAME },
],
["<optgroup> with label", "#optgroup-1", null],
@ -442,10 +441,9 @@ add_task(async function() {
["Image map with aria-label", "#imagemap-2", null],
["Image map with aria-labelledby", "#imagemap-3", null],
["Image map with alt attribute", "#imagemap-4", null],
["Image map with empty alt attribute", "#imagemap-5", null],
[
"Image map with aria-labelledby an element with empty content",
"#imagemap-6",
"#imagemap-5",
{ score: FAIL, issue: IMAGE_NO_NAME },
],
["<iframe> with title", "#iframe-1", null],

24
devtools/server/tests/browser/doc_accessibility_text_label_audit.html
Просмотреть файл

@ -159,16 +159,15 @@
<p id="img-3-label">Label</p>
<img id="img-3" src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABwAAAAcCAYAAAByDd+UAAAAJklEQVRIie3NMREAAAgAoe9fWls4eAzMVM0xoVAoFAqFQqFQ+C9chp4NHvu+4Q4AAAAASUVORK5CYII=" aria-labelledby="img-3-label">
<img id="img-4" src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABwAAAAcCAYAAAByDd+UAAAAJklEQVRIie3NMREAAAgAoe9fWls4eAzMVM0xoVAoFAqFQqFQ+C9chp4NHvu+4Q4AAAAASUVORK5CYII=" alt="alt text">
<img id="img-5" src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABwAAAAcCAYAAAByDd+UAAAAJklEQVRIie3NMREAAAgAoe9fWls4eAzMVM0xoVAoFAqFQqFQ+C9chp4NHvu+4Q4AAAAASUVORK5CYII=" alt="">
<p id="img-6-label"></p>
<img id="img-6" src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABwAAAAcCAYAAAByDd+UAAAAJklEQVRIie3NMREAAAgAoe9fWls4eAzMVM0xoVAoFAqFQqFQ+C9chp4NHvu+4Q4AAAAASUVORK5CYII=" aria-labelledby="img-6-label">
<div id="img-7" role="img"></div>
<div id="img-8" role="img" aria-label="alt text"></div>
<p id="img-9-label">Label</p>
<div id="img-9" role="img" aria-labelledby="img-9-label"></div>
<div id="img-10" role="img" aria-label=""></div>
<p id="img-11-label"></p>
<div id="img-11" role="img" aria-labelledby="img-11-label"></div>
<p id="img-5-label"></p>
<img id="img-5" src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABwAAAAcCAYAAAByDd+UAAAAJklEQVRIie3NMREAAAgAoe9fWls4eAzMVM0xoVAoFAqFQqFQ+C9chp4NHvu+4Q4AAAAASUVORK5CYII=" aria-labelledby="img-5-label">
<div id="img-6" role="img"></div>
<div id="img-7" role="img" aria-label="alt text"></div>
<p id="img-8-label">Label</p>
<div id="img-8" role="img" aria-labelledby="img-8-label"></div>
<div id="img-9" role="img" aria-label=""></div>
<p id="img-10-label"></p>
<div id="img-10" role="img" aria-labelledby="img-10-label"></div>
<select>
<optgroup id="optgroup-1" label="Group 1">
<option>Option 1.1</option>
@ -219,9 +218,8 @@
<p id="imagemap-3-label">image map name</p>
<img id="imagemap-3" usemap="#imagemap" src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABwAAAAcCAYAAAByDd+UAAAAJklEQVRIie3NMREAAAgAoe9fWls4eAzMVM0xoVAoFAqFQqFQ+C9chp4NHvu+4Q4AAAAASUVORK5CYII=" aria-labelledby="imagemap-3-label">
<img id="imagemap-4" usemap="#imagemap" src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABwAAAAcCAYAAAByDd+UAAAAJklEQVRIie3NMREAAAgAoe9fWls4eAzMVM0xoVAoFAqFQqFQ+C9chp4NHvu+4Q4AAAAASUVORK5CYII=" alt="image map name">
<img id="imagemap-5" usemap="#imagemap" src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABwAAAAcCAYAAAByDd+UAAAAJklEQVRIie3NMREAAAgAoe9fWls4eAzMVM0xoVAoFAqFQqFQ+C9chp4NHvu+4Q4AAAAASUVORK5CYII=" alt="">
<p id="imagemap-6-label"></p>
<img id="imagemap-6" usemap="#imagemap" src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABwAAAAcCAYAAAByDd+UAAAAJklEQVRIie3NMREAAAgAoe9fWls4eAzMVM0xoVAoFAqFQqFQ+C9chp4NHvu+4Q4AAAAASUVORK5CYII=" aria-labelledby="img-6-label">
<p id="imagemap-5-label"></p>
<img id="imagemap-5" usemap="#imagemap" src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABwAAAAcCAYAAAByDd+UAAAAJklEQVRIie3NMREAAAgAoe9fWls4eAzMVM0xoVAoFAqFQqFQ+C9chp4NHvu+4Q4AAAAASUVORK5CYII=" aria-labelledby="img-5-label">
<iframe id="iframe-1" title="IFrame Title" src="https://example.com"></iframe>
<iframe id="iframe-2" title="" src="https://example.com"></iframe>
<iframe id="iframe-3" src="https://example.com"></iframe>