From e9a5487529f8ffa5964535ef1a17d7bdc1125c11 Mon Sep 17 00:00:00 2001 From: Michael Ratcliffe Date: Tue, 19 Mar 2019 15:29:37 +0000 Subject: [PATCH] Bug 1531845 - Silence various React warnings to help clear up debug mode test logs r=rcaliman Differential Revision: https://phabricator.services.mozilla.com/D23115 --HG-- extra : moz-landing-system : lando --- devtools/client/aboutdebugging/aboutdebugging.xhtml | 1 + devtools/client/aboutdebugging/components/PanelMenu.js | 1 + .../client/aboutdebugging/components/TargetList.js | 10 ++++++++-- devtools/client/aboutdebugging/initializer.js | 4 ++-- devtools/client/accessibility/components/Accessible.js | 2 +- devtools/client/accessibility/components/Button.js | 3 ++- devtools/client/application/src/components/App.js | 2 +- devtools/client/inspector/flexbox/types.js | 4 ++-- devtools/client/memory/app.js | 6 +++--- .../performance-new/components/DirectoryPicker.js | 1 + devtools/client/shared/components/Accordion.js | 1 + devtools/client/shared/components/VirtualizedTree.js | 2 +- 12 files changed, 24 insertions(+), 13 deletions(-) diff --git a/devtools/client/aboutdebugging/aboutdebugging.xhtml b/devtools/client/aboutdebugging/aboutdebugging.xhtml index ed0c1ec208a0..4248d62adf13 100644 --- a/devtools/client/aboutdebugging/aboutdebugging.xhtml +++ b/devtools/client/aboutdebugging/aboutdebugging.xhtml @@ -17,5 +17,6 @@ +
diff --git a/devtools/client/aboutdebugging/components/PanelMenu.js b/devtools/client/aboutdebugging/components/PanelMenu.js index 3e3ee0f93c2d..1025f560e0c7 100644 --- a/devtools/client/aboutdebugging/components/PanelMenu.js +++ b/devtools/client/aboutdebugging/components/PanelMenu.js @@ -28,6 +28,7 @@ class PanelMenu extends Component { const panelLinks = panels.map(({ id, name, icon }) => { const selected = id == selectedPanelId; return PanelMenuEntry({ + key: id, id, name, icon, diff --git a/devtools/client/aboutdebugging/components/TargetList.js b/devtools/client/aboutdebugging/components/TargetList.js index 3c9abe501c18..33f21a64c74f 100644 --- a/devtools/client/aboutdebugging/components/TargetList.js +++ b/devtools/client/aboutdebugging/components/TargetList.js @@ -48,8 +48,14 @@ class TargetList extends Component { if (sort) { targets = targets.sort(LocaleCompare); } - targets = targets.map(target => { - return targetClass({ client, connect, target, debugDisabled }); + targets = targets.map((target, index) => { + return targetClass({ + key: target.addonID || target.url || index, + client, + connect, + target, + debugDisabled, + }); }); let content = ""; diff --git a/devtools/client/aboutdebugging/initializer.js b/devtools/client/aboutdebugging/initializer.js index 5e024b2ad36d..01f85b8cbb3d 100644 --- a/devtools/client/aboutdebugging/initializer.js +++ b/devtools/client/aboutdebugging/initializer.js @@ -42,11 +42,11 @@ var AboutDebugging = { const telemetry = new Telemetry(); render(AboutDebuggingApp({ client, connect, telemetry }), - document.querySelector("#body")); + document.querySelector("#root")); }, destroy() { - unmountComponentAtNode(document.querySelector("#body")); + unmountComponentAtNode(document.querySelector("#root")); if (this.client) { this.client.close(); diff --git a/devtools/client/accessibility/components/Accessible.js b/devtools/client/accessibility/components/Accessible.js index 442ac3e83811..c6c39f90c115 100644 --- a/devtools/client/accessibility/components/Accessible.js +++ b/devtools/client/accessibility/components/Accessible.js @@ -283,7 +283,7 @@ class Accessible extends Component { className: classList.join(" "), style: { paddingInlineStart: depthPadding, - "inline-size": + inlineSize: `calc(var(--accessibility-properties-item-width) - ${depthPadding}px)`, }, onClick: e => { diff --git a/devtools/client/accessibility/components/Button.js b/devtools/client/accessibility/components/Button.js index 9f0ea356d2ff..a9a8560ab110 100644 --- a/devtools/client/accessibility/components/Button.js +++ b/devtools/client/accessibility/components/Button.js @@ -44,7 +44,8 @@ class Button extends Component { ].join(" "); const props = Object.assign({}, this.props, { className, - "aria-busy": this.props.busy, + "aria-busy": this.props.busy.toString(), + busy: this.props.busy.toString(), }); const classList = ["btn-content"]; diff --git a/devtools/client/application/src/components/App.js b/devtools/client/application/src/components/App.js index eec3d9eb6758..7be862fecd2f 100644 --- a/devtools/client/application/src/components/App.js +++ b/devtools/client/application/src/components/App.js @@ -22,7 +22,7 @@ class App extends Component { static get propTypes() { return { client: PropTypes.object.isRequired, - workers: PropTypes.object.isRequired, + workers: PropTypes.array.isRequired, serviceContainer: PropTypes.object.isRequired, domain: PropTypes.string.isRequired, fluentBundles: PropTypes.array.isRequired, diff --git a/devtools/client/inspector/flexbox/types.js b/devtools/client/inspector/flexbox/types.js index 3176800dbd6e..0c4d4c07d32e 100644 --- a/devtools/client/inspector/flexbox/types.js +++ b/devtools/client/inspector/flexbox/types.js @@ -30,10 +30,10 @@ const flexItemProperties = exports.flexItemProperties = { "max-width": PropTypes.string, // The computed height of the flex item element. - "height": PropTypes.number, + "height": PropTypes.string, // The computed width of the flex item element. - "width": PropTypes.number, + "width": PropTypes.string, }; diff --git a/devtools/client/memory/app.js b/devtools/client/memory/app.js index 1036959b2189..9a5f13b6d373 100644 --- a/devtools/client/memory/app.js +++ b/devtools/client/memory/app.js @@ -59,15 +59,15 @@ class MemoryApp extends Component { allocations: appModel.allocations, censusDisplay: appModel.censusDisplay, diffing: appModel.diffing, - dispatch: appModel.dispatch, + dispatch: PropTypes.func, filter: appModel.filter, front: appModel.front, heapWorker: appModel.heapWorker, individuals: appModel.individuals, labelDisplay: appModel.labelDisplay, - sizes: appModel.sizes, + sizes: PropTypes.object, snapshots: appModel.snapshots, - toolbox: appModel.toolbox, + toolbox: PropTypes.object, view: appModel.view, }; } diff --git a/devtools/client/performance-new/components/DirectoryPicker.js b/devtools/client/performance-new/components/DirectoryPicker.js index 283fac1b19e3..7aef380b8cd4 100644 --- a/devtools/client/performance-new/components/DirectoryPicker.js +++ b/devtools/client/performance-new/components/DirectoryPicker.js @@ -62,6 +62,7 @@ class DirectoryPicker extends PureComponent { }, dirs.map((fullPath, i) => option( { + key: fullPath, className: "pref-settings-dir-list-item", title: fullPath, }, diff --git a/devtools/client/shared/components/Accordion.js b/devtools/client/shared/components/Accordion.js index 53014d51ad76..f64443f4e84b 100644 --- a/devtools/client/shared/components/Accordion.js +++ b/devtools/client/shared/components/Accordion.js @@ -76,6 +76,7 @@ class Accordion extends Component { className, "aria-expanded": opened, "aria-labelledby": labelledby, + key: labelledby, }, h2( { diff --git a/devtools/client/shared/components/VirtualizedTree.js b/devtools/client/shared/components/VirtualizedTree.js index 274837b3d1b0..2ec01de9fd0d 100644 --- a/devtools/client/shared/components/VirtualizedTree.js +++ b/devtools/client/shared/components/VirtualizedTree.js @@ -1016,7 +1016,7 @@ class TreeNodeClass extends Component { ref: "treenode", "aria-level": this.props.depth + 1, onClick: this.props.onClick, - onKeyDownCapture: this.props.active && this._onKeyDown, + onKeyDownCapture: this.props.active ? this._onKeyDown : undefined, "aria-expanded": ariaExpanded, "data-expanded": this.props.expanded ? "" : undefined, "data-depth": this.props.depth,