From e9fe7004bd658fa8af840d3d70220a15c03e1b4d Mon Sep 17 00:00:00 2001 From: "av%netscape.com" Date: Wed, 18 Apr 2001 00:05:20 +0000 Subject: [PATCH] Fixing bug 76384 -- crash in the default plugin, r=serge, sr=attinasi --- modules/plugin/default/windows/plugin.cpp | 8 ++++++-- modules/plugin/samples/default/windows/plugin.cpp | 8 ++++++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/modules/plugin/default/windows/plugin.cpp b/modules/plugin/default/windows/plugin.cpp index 37bc3a7a0a5e..405adb571a25 100644 --- a/modules/plugin/default/windows/plugin.cpp +++ b/modules/plugin/default/windows/plugin.cpp @@ -428,9 +428,13 @@ void CPlugin::showGetPluginDialog() if((m_szPageURL != NULL) || (m_szFileURL != NULL) || !m_bJavaScript) { - CreateDialogParam(m_hInst, MAKEINTRESOURCE(IDD_PLUGIN_DOWNLOAD), m_hWnd, - (DLGPROC)GetPluginDialogProc, (LPARAM)this); + // we don't want it more than once + if(m_hWndDialog == NULL) + CreateDialogParam(m_hInst, MAKEINTRESOURCE(IDD_PLUGIN_DOWNLOAD), m_hWnd, + (DLGPROC)GetPluginDialogProc, (LPARAM)this); } + else + getPlugin(); } void CPlugin::getPlugin() diff --git a/modules/plugin/samples/default/windows/plugin.cpp b/modules/plugin/samples/default/windows/plugin.cpp index 37bc3a7a0a5e..405adb571a25 100644 --- a/modules/plugin/samples/default/windows/plugin.cpp +++ b/modules/plugin/samples/default/windows/plugin.cpp @@ -428,9 +428,13 @@ void CPlugin::showGetPluginDialog() if((m_szPageURL != NULL) || (m_szFileURL != NULL) || !m_bJavaScript) { - CreateDialogParam(m_hInst, MAKEINTRESOURCE(IDD_PLUGIN_DOWNLOAD), m_hWnd, - (DLGPROC)GetPluginDialogProc, (LPARAM)this); + // we don't want it more than once + if(m_hWndDialog == NULL) + CreateDialogParam(m_hInst, MAKEINTRESOURCE(IDD_PLUGIN_DOWNLOAD), m_hWnd, + (DLGPROC)GetPluginDialogProc, (LPARAM)this); } + else + getPlugin(); } void CPlugin::getPlugin()