From eab83a05b4ae9679d7fb25290f4354aa25f4247a Mon Sep 17 00:00:00 2001
From: Brian Birtles <birtles@gmail.com>
Date: Thu, 22 Oct 2015 15:16:18 +0900
Subject: [PATCH] Bug 1194639 part 2 - Report changes to playbackRate to
 animation mutation observers; r=heycam

---
 dom/animation/Animation.cpp                   | 10 ++++
 .../test/chrome/test_animation_observers.html | 49 +++++++++++++++++++
 2 files changed, 59 insertions(+)

diff --git a/dom/animation/Animation.cpp b/dom/animation/Animation.cpp
index a0828c4b6944..74de21839529 100644
--- a/dom/animation/Animation.cpp
+++ b/dom/animation/Animation.cpp
@@ -205,11 +205,21 @@ Animation::SetCurrentTime(const TimeDuration& aSeekTime)
 void
 Animation::SetPlaybackRate(double aPlaybackRate)
 {
+  if (aPlaybackRate == mPlaybackRate) {
+    return;
+  }
+
+  AutoMutationBatchForAnimation mb(*this);
+
   Nullable<TimeDuration> previousTime = GetCurrentTime();
   mPlaybackRate = aPlaybackRate;
   if (!previousTime.IsNull()) {
     SetCurrentTime(previousTime.Value());
   }
+
+  if (IsRelevant()) {
+    nsNodeUtils::AnimationChanged(this);
+  }
 }
 
 // https://w3c.github.io/web-animations/#play-state
diff --git a/dom/animation/test/chrome/test_animation_observers.html b/dom/animation/test/chrome/test_animation_observers.html
index d04b29c53ebe..c07548b9d6d6 100644
--- a/dom/animation/test/chrome/test_animation_observers.html
+++ b/dom/animation/test/chrome/test_animation_observers.html
@@ -689,6 +689,55 @@ function assert_records(expected, desc) {
     });
   });
 
+  // Test that updating a property on the Animation object dispatches a changed
+  // notification.
+  [
+    { prop: "playbackRate", val: 0.5 },
+  ].forEach(function(aChangeTest) {
+    addAsyncAnimTest(`single_animation_api_change_${aChangeTest.prop}`,
+                     aOptions, function*() {
+      // Start a long animation
+      //
+      // We use a forwards fill mode so that even if the change we make causes
+      // the animation to become finished, it will still be "relevant" so we
+      // won't mark it as removed.
+      e.style = "animation: anim 100s forwards";
+
+      // The animation should cause the creation of a single Animation.
+      var animations = e.getAnimations();
+      is(animations.length, 1, "getAnimations().length after animation start");
+
+      // Wait for the single MutationRecord for the Animation addition to
+      // be delivered.
+      yield await_frame();
+      assert_records([{ added: animations, changed: [], removed: [] }],
+                     "records after animation start");
+
+      // Wait until the animation is playing
+      yield animations[0].ready;
+
+      // Update the property
+      animations[0][aChangeTest.prop] = aChangeTest.val;
+
+      // Make a redundant change
+      animations[0][aChangeTest.prop] = animations[0][aChangeTest.prop];
+
+      // Wait for the single MutationRecord for the Animation change to
+      // be delivered.
+      yield await_frame();
+      assert_records([{ added: [], changed: animations, removed: [] }],
+                     "records after animation property change");
+
+      // Cancel the animation.
+      e.style = "";
+
+      // Wait for the single removal notification.
+      yield await_frame();
+      assert_records([{ added: [], changed: [], removed: animations }],
+                     "records after animation end");
+    });
+  });
+
   // Test that a non-cancelling change to an animation followed immediately by a
   // cancelling change will only send an animation removal notification.
   addAsyncAnimTest("coalesce_change_cancel", aOptions, function*() {