mozilla
/
gecko-dev
зеркало из https://github.com/mozilla/gecko-dev.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность

Bug 1265968 - fire change event after selected item is changed in dropdown. r=smaug

This commit is contained in:
Jessica Jong 2016-05-17 12:50:50 -07:00
Родитель 94f266f4ff
Коммит eb72222ba6
3 изменённых файлов: 63 добавлений и 5 удалений
Показать статистику Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

2
dom/html/test/forms/mochitest.ini
Просмотреть файл

@ -85,6 +85,8 @@ skip-if = buildapp == 'mulet'
[test_required_attribute.html]
[test_restore_form_elements.html]
[test_save_restore_radio_groups.html]
[test_select_change_event.html]
skip-if = android_version == '18'
[test_select_selectedOptions.html]
[test_select_validation.html]
[test_set_range_text.html]

54
dom/html/test/forms/test_select_change_event.html Normal file
Просмотреть файл

@ -0,0 +1,54 @@
<!DOCTYPE HTML>
<html>
<!--
https://bugzilla.mozilla.org/show_bug.cgi?id=1265968
-->
<head>
<title>Test for Bug 1265968</title>
<script type="text/javascript" src="/tests/SimpleTest/SimpleTest.js"></script>
<script type="text/javascript" src="/tests/SimpleTest/EventUtils.js"></script>
<link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css" />
</head>
<body>
<a target="_blank" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1265968">Mozilla Bug 1265968</a>
<p id="display"></p>
<div id="content">
<select id="select" onchange="++selectChange;">
<option>one</option>
<option>two</option>
<option>three</option>
<option>four</option>
<option>five</option>
</select>
</div>
<pre id="test">
<script type="application/javascript">
var select = document.getElementById("select");
var selectChange = 0;
var expectedChange = 0;
select.focus();
for (var i = 1; i < select.length; i++) {
synthesizeKey("VK_DOWN", {});
is(select.options[i].selected, true, "Option should be selected");
is(selectChange, ++expectedChange, "Down key should fire change event.");
}
// We are at the end of the list, going down should not fire change event.
synthesizeKey("VK_DOWN", {});
is(selectChange, expectedChange, "Down key should not fire change event when reaching end of the list.");
for (var i = select.length - 2; i >= 0; i--) {
synthesizeKey("VK_UP", {});
is(select.options[i].selected, true, "Option should be selected");
is(selectChange, ++expectedChange, "Up key should fire change event.");
}
// We are at the top of the list, going up should not fire change event.
synthesizeKey("VK_UP", {});
is(selectChange, expectedChange, "Up key should not fire change event when reaching top of the list.");
</script>
</pre>
</body>
</html>

12
layout/forms/nsListControlFrame.cpp
Просмотреть файл

@ -1317,9 +1317,14 @@ nsListControlFrame::UpdateSelection()
nsWeakFrame weakFrame(this);
if (mComboboxFrame) {
mComboboxFrame->RedisplaySelectedText();
// When dropdown list is open, onchange event will be fired when Enter key
// is hit or when dropdown list is dismissed.
if (mComboboxFrame->IsDroppedDown()) {
return weakFrame.IsAlive();
}
}
// if it's a listbox, fire on change
else if (mIsAllContentHere) {
if (mIsAllContentHere) {
FireOnChange();
}
return weakFrame.IsAlive();
@ -2164,9 +2169,6 @@ nsListControlFrame::KeyDown(nsIDOMEvent* aKeyEvent)
return NS_OK;
}
}
// XXX This is strange. On other browsers, "change" event is fired
// immediately after the selected item is changed rather than
// Enter key is pressed.
FireOnChange();
return NS_OK;
}