From ec63a27082a5a1db3c29268a21cf18867435ad47 Mon Sep 17 00:00:00 2001
From: Anshul <malikanshul29@gmail.com>
Date: Mon, 28 Oct 2019 22:24:26 +0000
Subject: [PATCH] Bug 1590811 - Better align the breakpoint icon and change
 hover effects.

Differential Revision: https://phabricator.services.mozilla.com/D50157

--HG--
extra : moz-landing-system : lando
---
 .../client/debugger/bin/module-manifest.json     | 14 +++++++-------
 .../components/ObjectInspector.css               | 16 ++++++++++++----
 devtools/client/shared/components/reps/reps.css  | 16 ++++++++++++----
 3 files changed, 31 insertions(+), 15 deletions(-)

diff --git a/devtools/client/debugger/bin/module-manifest.json b/devtools/client/debugger/bin/module-manifest.json
index a552f19b069c..d373a5549748 100644
--- a/devtools/client/debugger/bin/module-manifest.json
+++ b/devtools/client/debugger/bin/module-manifest.json
@@ -15,7 +15,7 @@
         "byName": {},
         "byBlocks": {},
         "usedIds": {
-          "0": 0
+          "1": 1
         }
       }
     }
@@ -36,7 +36,7 @@
         "byName": {},
         "byBlocks": {},
         "usedIds": {
-          "0": 0
+          "1": 1
         }
       }
     }
@@ -57,7 +57,7 @@
         "byName": {},
         "byBlocks": {},
         "usedIds": {
-          "0": 0
+          "1": 1
         }
       }
     }
@@ -78,7 +78,7 @@
         "byName": {},
         "byBlocks": {},
         "usedIds": {
-          "0": 0
+          "1": 1
         }
       }
     }
@@ -99,7 +99,7 @@
         "byName": {},
         "byBlocks": {},
         "usedIds": {
-          "0": 0
+          "1": 1
         }
       }
     }
@@ -120,7 +120,7 @@
         "byName": {},
         "byBlocks": {},
         "usedIds": {
-          "0": 0
+          "1": 1
         }
       }
     }
@@ -141,7 +141,7 @@
         "byName": {},
         "byBlocks": {},
         "usedIds": {
-          "0": 0
+          "1": 1
         }
       }
     }
diff --git a/devtools/client/debugger/packages/devtools-reps/src/object-inspector/components/ObjectInspector.css b/devtools/client/debugger/packages/devtools-reps/src/object-inspector/components/ObjectInspector.css
index 9812b29cfb85..5d4299b31122 100644
--- a/devtools/client/debugger/packages/devtools-reps/src/object-inspector/components/ObjectInspector.css
+++ b/devtools/client/debugger/packages/devtools-reps/src/object-inspector/components/ObjectInspector.css
@@ -58,10 +58,10 @@
 
 button.remove-set-watchpoint {
   mask: url("resource://devtools/client/debugger/images/webconsole-logpoint.svg")
-  no-repeat;
+    no-repeat;
   display: inline-block;
   vertical-align: top;
-  height: 15px;
+  height: 13px;
   width: 15px;
   margin: 0 4px 0px 20px;
   padding: 0;
@@ -72,10 +72,10 @@ button.remove-set-watchpoint {
 
 button.remove-get-watchpoint {
   mask: url("resource://devtools/client/debugger/images/webconsole-logpoint.svg")
-  no-repeat;
+    no-repeat;
   display: inline-block;
   vertical-align: top;
-  height: 15px;
+  height: 13px;
   width: 15px;
   margin: 0 4px 0px 20px;
   padding: 0;
@@ -83,3 +83,11 @@ button.remove-get-watchpoint {
   background-color: var(--purple-60);
   cursor: pointer;
 }
+.theme-dark button.remove-set-watchpoint:hover,
+.theme-light button.remove-set-watchpoint:hover {
+  background-color: var(--breakpoint-fill);
+}
+.theme-dark button.remove-get-watchpoint:hover,
+.theme-light button.remove-get-watchpoint:hover {
+  background-color: var(--purple-60);
+}
diff --git a/devtools/client/shared/components/reps/reps.css b/devtools/client/shared/components/reps/reps.css
index 998e38cbcbff..14100153dcd4 100644
--- a/devtools/client/shared/components/reps/reps.css
+++ b/devtools/client/shared/components/reps/reps.css
@@ -461,10 +461,10 @@ button.invoke-getter {
 
 button.remove-set-watchpoint {
   mask: url("resource://devtools/client/debugger/images/webconsole-logpoint.svg")
-  no-repeat;
+    no-repeat;
   display: inline-block;
   vertical-align: top;
-  height: 15px;
+  height: 13px;
   width: 15px;
   margin: 0 4px 0px 20px;
   padding: 0;
@@ -475,10 +475,10 @@ button.remove-set-watchpoint {
 
 button.remove-get-watchpoint {
   mask: url("resource://devtools/client/debugger/images/webconsole-logpoint.svg")
-  no-repeat;
+    no-repeat;
   display: inline-block;
   vertical-align: top;
-  height: 15px;
+  height: 13px;
   width: 15px;
   margin: 0 4px 0px 20px;
   padding: 0;
@@ -486,3 +486,11 @@ button.remove-get-watchpoint {
   background-color: var(--purple-60);
   cursor: pointer;
 }
+.theme-dark button.remove-set-watchpoint:hover,
+.theme-light button.remove-set-watchpoint:hover {
+  background-color: var(--breakpoint-fill);
+}
+.theme-dark button.remove-get-watchpoint:hover,
+.theme-light button.remove-get-watchpoint:hover {
+  background-color: var(--purple-60);
+}