Bug 1452159 periodic file update clears out old reviews r=jlorenzo

Summary:
the periodic file updates keep adding new reviews, and it's easy to fall behind.
This adjusts the script so it clears out any previous submissions that are still awaiting review.

Reviewers: jlorenzo

Reviewed By: jlorenzo

Bug #: 1452159

Differential Revision: https://phabricator.services.mozilla.com/D872

--HG--
extra : rebase_source : 4a36ddd91bf7e971fd6b424d02117bd4739a91ed

taskcluster/docker/periodic-updates/scripts/periodic_file_updates.sh

@@ -408,6 +408,17 @@ function push_repo {
   then
     return 1
   fi
+
+  # Clean up older review requests
+  # Turn  Needs Review D624: No bug, Automated HSTS ...
+  # into D624
+  for diff in $($ARC list | grep "Needs Review" | grep -E "Automated HSTS|Automated HPKP|Automated blocklist" | awk 'match($0, /D[0-9]+[^: ]/, arr) { print arr[0] }')
+  do
+    echo "Removing old request $diff"
+    # There is no 'arc abandon', see bug 1452082
+    echo '{"transactions": [{"type":"abandon"}], "objectIdentifier": "'"${diff}"'"}' | arc call-conduit differential.revision.edit
+  done
+
   $ARC diff --verbatim --reviewers "${REVIEWERS}"
 }