Bug 658065 Fix some warnings in mochitest harness r=ctalbert

testing/mochitest/browser-test.js

@@ -1,5 +1,6 @@
 // Test timeout (seconds)
 const TIMEOUT_SECONDS = 30;
+var gConfig;
 
 if (Cc === undefined) {
   var Cc = Components.classes;

testing/mochitest/chrome-harness.js

@@ -365,7 +365,7 @@ function readConfig() {
   configFile.append("testConfig.js");
 
   if (!configFile.exists())
-    return;
+    return {};
 
   var fileInStream = Components.classes["@mozilla.org/network/file-input-stream;1"].
                      createInstance(Components.interfaces.nsIFileInputStream);

testing/mochitest/server.js

@@ -200,7 +200,7 @@ function runServer()
   if (serverAlive.exists()) {
     serverAlive.append("server_alive.txt");
     foStream.init(serverAlive,
-                  0x02 | 0x08 | 0x20, 0664, 0); // write, create, truncate
+                  0x02 | 0x08 | 0x20, 436, 0); // write, create, truncate
     data = "It's alive!";
     foStream.write(data, data.length);
     foStream.close();
@@ -275,7 +275,7 @@ function processLocations(server)
   serverLocations.append("server-locations.txt");
 
   const PR_RDONLY = 0x01;
-  var fis = new FileInputStream(serverLocations, PR_RDONLY, 0444,
+  var fis = new FileInputStream(serverLocations, PR_RDONLY, 292 /* 0444 */,
                                 Ci.nsIFileInputStream.CLOSE_ON_EOF);
 
   var lis = new ConverterInputStream(fis, "UTF-8", 1024, 0x0);

testing/mochitest/tests/SimpleTest/SimpleTest.js

@@ -639,7 +639,8 @@ SimpleTest._eqArray = function (a1, a2, stack, seen) {
         var e1 = i > a1.length - 1 ? SimpleTest.DNE : a1[i];
         var e2 = i > a2.length - 1 ? SimpleTest.DNE : a2[i];
         stack.push({ type: 'Array', idx: i, vals: [e1, e2] });
-        if (ok = SimpleTest._deepCheck(e1, e2, stack, seen)) {
+        ok = SimpleTest._deepCheck(e1, e2, stack, seen);
+        if (ok) {
             stack.pop();
         } else {
             break;
@@ -680,7 +681,8 @@ SimpleTest._eqAssoc = function (o1, o2, stack, seen) {
         var e1 = o1[i] == undefined ? SimpleTest.DNE : o1[i];
         var e2 = o2[i] == undefined ? SimpleTest.DNE : o2[i];
         stack.push({ type: 'Object', idx: i, vals: [e1, e2] });
-        if (ok = SimpleTest._deepCheck(e1, e2, stack, seen)) {
+        ok = SimpleTest._deepCheck(e1, e2, stack, seen)
+        if (ok) {
             stack.pop();
         } else {
             break;