Bug 1692940 - Switch ffvpx build to nasm instead of yasm. r=firefox-build-system-reviewers,dmajor

nasm doesn't like compiling simple_idct10.asm on x86
(https://bugzilla.nasm.us/show_bug.cgi?id=3392738), which is empty once
preprocessed for x86, so exclude it there.

Differential Revision: https://phabricator.services.mozilla.com/D105429

media/ffvpx/ffvpxcommon.mozbuild

@@ -12,8 +12,8 @@ if CONFIG['CPU_ARCH'] != 'aarch64':
     ASFLAGS += ['-I%s/media/ffvpx/libavutil/x86/' % TOPSRCDIR]
 
 if CONFIG['FFVPX_ASFLAGS']:
-    if CONFIG['FFVPX_USE_YASM']:
-        USE_YASM = True
+    if CONFIG['FFVPX_USE_NASM']:
+        USE_NASM = True
 
     if CONFIG['OS_ARCH'] == 'WINNT':
        # Fix inline symbols and math defines for windows.

media/ffvpx/libavcodec/x86/moz.build

@@ -20,7 +20,6 @@ SOURCES += [
     'imdct36.asm',
     'mpegaudiodsp.c',
     'simple_idct.asm',
-    'simple_idct10.asm',
     'videodsp.asm',
     'videodsp_init.c',
     'vp8dsp.asm',
@@ -40,6 +39,11 @@ SOURCES += [
     'vp9mc_16bpp.asm',
 ]
 
+if CONFIG['CPU_ARCH'] == "x86_64":
+    SOURCES += [
+        'simple_idct10.asm',
+    ]
+
 if CONFIG['MOZ_LIBAV_FFT']:
     SOURCES += [
         'fft.asm',

toolkit/moz.configure

@@ -1846,9 +1846,9 @@ with only_when(compile_environment):
 # Artifact builds need MOZ_FFVPX defined as if compilation happened.
 with only_when(compile_environment | artifact_builds):
 
-    @depends(vpx_as_flags, target)
-    def ffvpx(vpx_as_flags, target):
-        enable = use_yasm = True
+    @depends(target)
+    def ffvpx(target):
+        enable = use_nasm = True
         flac_only = False
         flags = []
 
@@ -1866,7 +1866,7 @@ with only_when(compile_environment | artifact_builds):
                 ]
             elif target.cpu == "aarch64":
                 flags = ["-DPIC", "-DWIN64"]
-                use_yasm = False
+                use_nasm = False
         elif target.kernel == "Darwin":
             if target.cpu == "x86_64":
                 # 32/64-bit macosx asemblers need to prefix symbols with an
@@ -1882,45 +1882,51 @@ with only_when(compile_environment | artifact_builds):
                 flac_only = True
         elif target.cpu == "x86_64":
             flags = ["-D__x86_64__", "-DPIC", "-DELF", "-Pconfig_unix64.asm"]
-        elif target.cpu == "x86":
+        elif target.cpu in ("x86", "arm", "aarch64"):
             flac_only = True
-        elif target.cpu in ("arm", "aarch64"):
-            flac_only = True
-            if vpx_as_flags:
-                flags.extend(vpx_as_flags)
         else:
             enable = False
 
         if flac_only or not enable:
-            use_yasm = False
+            use_nasm = False
 
-        if use_yasm:
+        if use_nasm:
             # default disabled components
             flags.append("-Pdefaults_disabled.asm")
 
         return namespace(
             enable=enable,
-            need_yasm="1.2" if use_yasm else False,
+            use_nasm=use_nasm,
             flac_only=flac_only,
             flags=flags,
         )
 
+    @depends(when=ffvpx.use_nasm)
+    def ffvpx_nasm():
+        # nasm 2.10 for AVX-2 support.
+        return namespace(version="2.10", what="FFVPX")
+
+    # ffvpx_nasm can't indirectly depend on vpx_as_flags, because it depends
+    # on a compiler test, so we have to do a little bit of dance here.
+    @depends(ffvpx, vpx_as_flags, target)
+    def ffvpx(ffvpx, vpx_as_flags, target):
+        if ffvpx and target.cpu in ("arm", "aarch64"):
+            ffvpx.flags.extend(vpx_as_flags)
+        return ffvpx
+
     set_config("MOZ_FFVPX", True, when=ffvpx.enable)
     set_define("MOZ_FFVPX", True, when=ffvpx.enable)
     set_config("MOZ_FFVPX_AUDIOONLY", True, when=ffvpx.flac_only)
     set_define("MOZ_FFVPX_AUDIOONLY", True, when=ffvpx.flac_only)
     set_config("FFVPX_ASFLAGS", ffvpx.flags)
-    set_config("FFVPX_USE_YASM", True, when=ffvpx.need_yasm)
+    set_config("FFVPX_USE_NASM", True, when=ffvpx.use_nasm)
 
 
 @depends(
     yasm_version,
-    ffvpx.use_yasm,
 )
-def valid_yasm_version(yasm_version, for_ffvpx=False):
-    # Note: the default for for_ffvpx above only matters for unit tests.
+def valid_yasm_version(yasm_version):
     requires = {
-        "ffvpx": for_ffvpx,
     }
     requires = {k: v for (k, v) in requires.items() if v}
     if requires and not yasm_version:
@@ -1947,7 +1953,7 @@ def valid_yasm_version(yasm_version, for_ffvpx=False):
 
 # nasm detection
 # ==============================================================
-@depends(dav1d_nasm, vpx_nasm, jpeg_nasm)
+@depends(dav1d_nasm, vpx_nasm, jpeg_nasm, ffvpx_nasm)
 def need_nasm(*requirements):
     requires = {
         x.what: x.version if hasattr(x, "version") else True for x in requirements if x