From eddf868fb546e5ed51b57d7ec03800e6c7e80df5 Mon Sep 17 00:00:00 2001 From: Alex Turner Date: Thu, 2 Jan 2020 10:51:52 +0000 Subject: [PATCH] Bug 1605296 [wpt PR 20880] - Use HTTP_NOTSAMESITE_ORIGIN for split cache Web Platform Test, a=testonly Automatic update from web-platform-tests Use HTTP_NOTSAMESITE_ORIGIN for split cache Web Platform Test Currently HTTP_REMOTE_ORIGIN is used as the third-party origin, but this does not work for split cache experiments using eTLD+1 as the additional key (i.e. when UseRegistrableDomainInNetworkIsolationKey is enabled). This is due to HTTP_REMOTE_ORIGIN simply prepending 'ww1.' to the HTTP_ORIGIN, which results in the same registrable domain. Bug: 1035508 Change-Id: Ib42bb30491bb451a47b80914a48e252a9c93d10f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978037 Reviewed-by: Shivani Sharma Commit-Queue: Alex Turner Cr-Commit-Position: refs/heads/master@{#727110} -- wpt-commits: 44e3f8a64aacebd5123aac7456cb81f423c38860 wpt-pr: 20880 --- .../tests/fetch/http-cache/split-cache.tentative.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testing/web-platform/tests/fetch/http-cache/split-cache.tentative.html b/testing/web-platform/tests/fetch/http-cache/split-cache.tentative.html index 533dd6a936fe..9e557fed7b79 100644 --- a/testing/web-platform/tests/fetch/http-cache/split-cache.tentative.html +++ b/testing/web-platform/tests/fetch/http-cache/split-cache.tentative.html @@ -16,7 +16,7 @@ const host = get_host_info(); // We run this entire test twice: first with a same-origin then with a cross-origin popup function performFullTest(is_same_origin_test) { - const POPUP_HTTP_ORIGIN = is_same_origin_test ? host.HTTP_ORIGIN : host.HTTP_REMOTE_ORIGIN + const POPUP_HTTP_ORIGIN = is_same_origin_test ? host.HTTP_ORIGIN : host.HTTP_NOTSAMESITE_ORIGIN const LOCAL_HTTP_ORIGIN = host.HTTP_ORIGIN const popupBaseURL = POPUP_HTTP_ORIGIN + window.location.pathname.replace(/\/[^\/]*$/, '/') ;