Removed WS_VISIBLE from everywhere so that windows when created are hidden until positioned and shown

widget/src/windows/nsCheckButton.cpp

@@ -158,7 +158,7 @@ LPCTSTR nsCheckButton::WindowClass()
 //-------------------------------------------------------------------------
 DWORD nsCheckButton::WindowStyle()
 {
-    return BS_CHECKBOX | WS_CHILD | WS_VISIBLE | WS_CLIPSIBLINGS; 
+    return BS_CHECKBOX | WS_CHILD | WS_CLIPSIBLINGS; 
 }
 
 

widget/src/windows/nsComboBox.cpp

@@ -220,7 +220,7 @@ LPCTSTR nsComboBox::WindowClass()
 //-------------------------------------------------------------------------
 DWORD nsComboBox::WindowStyle()
 {
-  return (CBS_DROPDOWNLIST | CBS_DISABLENOSCROLL | WS_BORDER | WS_CHILD | WS_VISIBLE | WS_CLIPSIBLINGS);
+  return (CBS_DROPDOWNLIST | CBS_DISABLENOSCROLL | WS_BORDER | WS_CHILD | WS_CLIPSIBLINGS);
 }
 
 //-------------------------------------------------------------------------

widget/src/windows/nsListBox.cpp

@@ -295,7 +295,7 @@ LPCTSTR nsListBox::WindowClass()
 //-------------------------------------------------------------------------
 DWORD nsListBox::WindowStyle()
 {
-  DWORD style = (LBS_NOINTEGRALHEIGHT | WS_BORDER | WS_CHILD | WS_VISIBLE | WS_CLIPSIBLINGS | WS_VSCROLL);
+  DWORD style = (LBS_NOINTEGRALHEIGHT | WS_BORDER | WS_CHILD | WS_CLIPSIBLINGS | WS_VSCROLL);
   if (mMultiSelect) 
     style = LBS_MULTIPLESEL | style;
 

widget/src/windows/nsScrollbar.cpp

@@ -435,7 +435,7 @@ LPCTSTR nsScrollbar::WindowClass()
 //-------------------------------------------------------------------------
 DWORD nsScrollbar::WindowStyle()
 {
-    return mPositionFlag | WS_CHILD | WS_VISIBLE | WS_CLIPSIBLINGS;
+    return mPositionFlag | WS_CHILD | WS_CLIPSIBLINGS;
 }
 
 

widget/src/windows/nsTextHelper.cpp

@@ -117,7 +117,7 @@ PRUint32  nsTextHelper::GetCaretPosition()
   if (start == end) {
     return start;
   }
-  return -1;
+  return PRUint32(-1);/* XXX is this right??? scary cast! */
 }
 
 //-------------------------------------------------------------------------
@@ -158,7 +158,7 @@ LPCTSTR nsTextHelper::WindowClass()
 //-------------------------------------------------------------------------
 DWORD nsTextHelper::WindowStyle()
 {
-    DWORD style = ES_AUTOHSCROLL | WS_BORDER | WS_CHILD | WS_VISIBLE | WS_CLIPSIBLINGS | ES_NOHIDESEL;
+    DWORD style = ES_AUTOHSCROLL | WS_BORDER | WS_CHILD | WS_CLIPSIBLINGS | ES_NOHIDESEL;
     if (mIsPassword)
       style = style | ES_PASSWORD;
 

widget/src/windows/nsWindow.cpp

@@ -2040,7 +2040,7 @@ void nsWindow::Enumerator::GrowArray()
 //-------------------------------------------------------------------------
 DWORD ChildWindow::WindowStyle()
 {
-    return WS_CHILD | WS_VISIBLE | WS_CLIPCHILDREN | GetBorderStyle(mBorderStyle);
+    return WS_CHILD | WS_CLIPCHILDREN | GetBorderStyle(mBorderStyle);
 }