Bug 1331804 - Add more runnable names (r=ehsan)

MozReview-Commit-ID: 1QBmqfgY6WI
This commit is contained in:
Bill McCloskey 2017-01-17 16:50:34 -08:00
Родитель bd752b7e5b
Коммит ef3d0f1c2e
17 изменённых файлов: 57 добавлений и 23 удалений

Просмотреть файл

@ -1192,7 +1192,8 @@ class WorkerThreadPrimaryRunnable final : public Runnable
public:
explicit FinishedRunnable(already_AddRefed<WorkerThread> aThread)
: mThread(aThread)
: Runnable("WorkerThreadPrimaryRunnable::FinishedRunnable")
, mThread(aThread)
{
MOZ_ASSERT(mThread);
}

Просмотреть файл

@ -750,7 +750,8 @@ public:
OpenMainProcessActorRunnable(already_AddRefed<ChildImpl>&& aChildActor,
already_AddRefed<ParentImpl> aParentActor,
MessageLoop* aParentMessageLoop)
: mActor(aChildActor), mParentActor(aParentActor),
: Runnable("ChildImpl::OpenMainProcessActorRunnable"),
mActor(aChildActor), mParentActor(aParentActor),
mParentMessageLoop(aParentMessageLoop)
{
AssertIsOnMainThread();

Просмотреть файл

@ -1591,6 +1591,14 @@ MessageChannel::RunMessage(MessageTask& aTask)
NS_IMPL_ISUPPORTS_INHERITED(MessageChannel::MessageTask, CancelableRunnable, nsIRunnablePriority)
MessageChannel::MessageTask::MessageTask(MessageChannel* aChannel, Message&& aMessage)
: CancelableRunnable(StringFromIPCMessageType(aMessage.type()))
, mChannel(aChannel)
, mMessage(Move(aMessage))
, mScheduled(false)
{
}
nsresult
MessageChannel::MessageTask::Run()
{

Просмотреть файл

@ -455,9 +455,7 @@ class MessageChannel : HasResultCodes
public nsIRunnablePriority
{
public:
explicit MessageTask(MessageChannel* aChannel, Message&& aMessage)
: mChannel(aChannel), mMessage(Move(aMessage)), mScheduled(false)
{}
explicit MessageTask(MessageChannel* aChannel, Message&& aMessage);
NS_DECL_ISUPPORTS_INHERITED

Просмотреть файл

@ -55,7 +55,8 @@ public:
nsresult status,
int64_t progress,
int64_t progressMax)
: mProxy(proxy)
: Runnable("nsTransportStatusEvent")
, mProxy(proxy)
, mTransport(transport)
, mStatus(status)
, mProgress(progress)

Просмотреть файл

@ -186,7 +186,8 @@ private:
public:
AvailableCallbackRunnable(CacheEntry* aEntry,
Callback const &aCallback)
: mEntry(aEntry)
: Runnable("CacheEntry::AvailableCallbackRunnable")
, mEntry(aEntry)
, mCallback(aCallback)
{}

Просмотреть файл

@ -43,7 +43,8 @@ public:
nsICancelable* aRequest,
nsIDNSRecord* aRecord,
nsresult aStatus)
: mListener(aListener)
: Runnable("DNSListenerProxy::OnLookupCompleteRunnable")
, mListener(aListener)
, mRequest(aRequest)
, mRecord(aRecord)
, mStatus(aStatus)

Просмотреть файл

@ -12,7 +12,8 @@
using namespace mozilla;
nsHtml5SVGLoadDispatcher::nsHtml5SVGLoadDispatcher(nsIContent* aElement)
: mElement(aElement)
: Runnable("nsHtml5SVGLoadDispatcher")
, mElement(aElement)
, mDocument(mElement->OwnerDoc())
{
mDocument->BlockOnload();

Просмотреть файл

@ -56,7 +56,8 @@ public:
CallbackResultNotifier(mozIStorageStatementCallback *aCallback,
mozIStorageResultSet *aResults,
AsyncExecuteStatements *aEventStatus) :
mCallback(aCallback)
Runnable("storage::CallbackResultNotifier")
, mCallback(aCallback)
, mResults(aResults)
, mEventStatus(aEventStatus)
{
@ -93,7 +94,8 @@ public:
ErrorNotifier(mozIStorageStatementCallback *aCallback,
mozIStorageError *aErrorObj,
AsyncExecuteStatements *aEventStatus) :
mCallback(aCallback)
Runnable("storage::ErrorNotifier")
, mCallback(aCallback)
, mErrorObj(aErrorObj)
, mEventStatus(aEventStatus)
{
@ -133,7 +135,8 @@ public:
*/
CompletionNotifier(mozIStorageStatementCallback *aCallback,
ExecutionState aReason)
: mCallback(aCallback)
: Runnable("storage::CompletionNotifier")
, mCallback(aCallback)
, mReason(aReason)
{
}

Просмотреть файл

@ -446,7 +446,8 @@ public:
Connection* aClone,
const bool aReadOnly,
mozIStorageCompletionCallback* aCallback)
: mConnection(aConnection)
: Runnable("storage::AsyncInitializeClone")
, mConnection(aConnection)
, mClone(aClone)
, mReadOnly(aReadOnly)
, mCallback(aCallback)

Просмотреть файл

@ -398,7 +398,8 @@ public:
CallbackComplete(nsresult aStatus,
nsISupports* aValue,
already_AddRefed<mozIStorageCompletionCallback> aCallback)
: mStatus(aStatus)
: Runnable("storage::CallbackComplete")
, mStatus(aStatus)
, mValue(aValue)
, mCallback(aCallback)
{

Просмотреть файл

@ -308,7 +308,7 @@ nsBaseAppShell::DispatchDummyEvent(nsIThread* aTarget)
NS_ASSERTION(NS_IsMainThread(), "Wrong thread!");
if (!mDummyEvent)
mDummyEvent = new mozilla::Runnable();
mDummyEvent = new mozilla::Runnable("DummyEvent");
return NS_SUCCEEDED(aTarget->Dispatch(mDummyEvent, NS_DISPATCH_NORMAL));
}

Просмотреть файл

@ -38,7 +38,8 @@ public:
nsInputStreamReadyEvent(nsIInputStreamCallback* aCallback,
nsIEventTarget* aTarget)
: mCallback(aCallback)
: CancelableRunnable("nsInputStreamReadyEvent")
, mCallback(aCallback)
, mTarget(aTarget)
{
}
@ -128,7 +129,8 @@ public:
nsOutputStreamReadyEvent(nsIOutputStreamCallback* aCallback,
nsIEventTarget* aTarget)
: mCallback(aCallback)
: CancelableRunnable("nsOutputStreamReadyEvent")
, mCallback(aCallback)
, mTarget(aTarget)
{
}
@ -241,7 +243,8 @@ public:
NS_DECL_ISUPPORTS_INHERITED
nsAStreamCopier()
: mLock("nsAStreamCopier.mLock")
: CancelableRunnable("nsAStreamCopier")
, mLock("nsAStreamCopier.mLock")
, mCallback(nullptr)
, mProgressCallback(nullptr)
, mClosure(nullptr)

Просмотреть файл

@ -29,7 +29,7 @@ class ProxyReleaseEvent : public mozilla::Runnable
{
public:
explicit ProxyReleaseEvent(already_AddRefed<T> aDoomed)
: mDoomed(aDoomed.take()) {}
: Runnable("ProxyReleaseEvent"), mDoomed(aDoomed.take()) {}
NS_IMETHOD Run() override
{

Просмотреть файл

@ -195,7 +195,8 @@ class nsThreadStartupEvent : public Runnable
{
public:
nsThreadStartupEvent()
: mMon("nsThreadStartupEvent.mMon")
: Runnable("nsThreadStartupEvent")
, mMon("nsThreadStartupEvent.mMon")
, mInitialized(false)
{
}
@ -334,7 +335,8 @@ class nsThreadShutdownAckEvent : public CancelableRunnable
{
public:
explicit nsThreadShutdownAckEvent(NotNull<nsThreadShutdownContext*> aCtx)
: mShutdownContext(aCtx)
: CancelableRunnable("nsThreadShutdownAckEvent")
, mShutdownContext(aCtx)
{
}
NS_IMETHOD Run() override
@ -358,7 +360,8 @@ class nsThreadShutdownEvent : public Runnable
public:
nsThreadShutdownEvent(NotNull<nsThread*> aThr,
NotNull<nsThreadShutdownContext*> aCtx)
: mThread(aThr)
: Runnable("nsThreadShutdownEvent")
, mThread(aThr)
, mShutdownContext(aCtx)
{
}

Просмотреть файл

@ -57,7 +57,11 @@ Runnable::GetName(nsACString& aName)
#ifdef RELEASE_OR_BETA
aName.Truncate();
#else
aName.AssignASCII(mName);
if (mName) {
aName.AssignASCII(mName);
} else {
aName.Truncate();
}
#endif
return NS_OK;
}

Просмотреть файл

@ -237,6 +237,12 @@ public:
Runnable() {}
#ifdef RELEASE_OR_BETA
explicit Runnable(const char* aName) {}
#else
explicit Runnable(const char* aName) : mName(aName) {}
#endif
protected:
virtual ~Runnable() {}
private:
@ -259,6 +265,7 @@ public:
virtual nsresult Cancel() override;
CancelableRunnable() {}
explicit CancelableRunnable(const char* aName) : Runnable(aName) {}
protected:
virtual ~CancelableRunnable() {}