From ef4348692cfe603806b498b655f24daef5397382 Mon Sep 17 00:00:00 2001
From: Nicholas Nethercote <nnethercote@mozilla.com>
Date: Thu, 10 Sep 2015 08:02:30 -0700
Subject: [PATCH] Bug 1203357 - Fix MSVC warning in
 dom/workers/test/gtest/TestReadWrite.cpp. r=baku.

The particular warning here was complaining about an unsafe comparison between
a uint32_t and a bool.

Also, remove ALLOW_COMPILER_WARNINGS=True for this directory.

--HG--
extra : rebase_source : e2ce5c425a48bf9cf29182f222d1f2dd44eb9bc8
---
 dom/workers/test/gtest/TestReadWrite.cpp | 2 +-
 dom/workers/test/gtest/moz.build         | 3 ---
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/dom/workers/test/gtest/TestReadWrite.cpp b/dom/workers/test/gtest/TestReadWrite.cpp
index 9955dec89527..bf85a6031ea2 100644
--- a/dom/workers/test/gtest/TestReadWrite.cpp
+++ b/dom/workers/test/gtest/TestReadWrite.cpp
@@ -248,7 +248,7 @@ TEST(ServiceWorkerRegistrar, TestWriteData)
     const mozilla::ipc::ContentPrincipalInfo& cInfo = data[i].principal();
 
     ASSERT_EQ((uint32_t)i, cInfo.appId());
-    ASSERT_EQ((uint32_t)(i %2), cInfo.isInBrowserElement());
+    ASSERT_EQ((uint32_t)(i % 2), (uint32_t)cInfo.isInBrowserElement());
 
     test.AppendPrintf("spec write %d", i);
     ASSERT_STREQ(test.get(), cInfo.spec().get());
diff --git a/dom/workers/test/gtest/moz.build b/dom/workers/test/gtest/moz.build
index f4386bb40b10..6be8377e9f29 100644
--- a/dom/workers/test/gtest/moz.build
+++ b/dom/workers/test/gtest/moz.build
@@ -10,7 +10,4 @@ UNIFIED_SOURCES = [
 
 include('/ipc/chromium/chromium-config.mozbuild')
 
-# XXX: We should fix these warnings.
-ALLOW_COMPILER_WARNINGS = True
-
 FINAL_LIBRARY = 'xul-gtest'