Bug 587344: block update publishing on successful startup tests. r=taskgraph-reviewers,aki

This moves the startup tests to Tier 1 (required, because they will block a Tier 1 task), and adds them as a dependency for Balrog submission on both Nightly and Release branches.

Differential Revision: https://phabricator.services.mozilla.com/D107834

taskcluster/ci/balrog/kind.yml

@@ -12,6 +12,7 @@ transforms:
 
 kind-dependencies:
     - beetmover-repackage
+    - startup-test
 
 only-for-attributes:
     - nightly

taskcluster/ci/startup-test/kind.yml

@@ -33,7 +33,7 @@ job-defaults:
     treeherder:
         symbol: SUT
         kind: test
-        tier: 3
+        tier: 1
 
 jobs:
     linux32:
@@ -49,8 +49,9 @@ jobs:
         worker-type: b-linux
         worker:
             docker-image: {in-tree: ubuntu1804-test}
+        shipping-product: firefox
         attributes:
-            build_platform: linux32
+            build_platform: linux-shippable
         treeherder:
             platform: linux-shippable/opt
 
@@ -67,8 +68,9 @@ jobs:
         worker-type: b-linux
         worker:
             docker-image: {in-tree: ubuntu1804-test}
+        shipping-product: firefox
         attributes:
-            build_platform: linux64
+            build_platform: linux64-shippable
         treeherder:
             platform: linux64-shippable/opt
 
@@ -83,8 +85,9 @@ jobs:
             upstream_artifact: target.dmg
             binary: Contents/MacOS/firefox
         worker-type: t-osx-1014
+        shipping-product: firefox
         attributes:
-            build_platform: macosx64
+            build_platform: macosx64-shippable
         treeherder:
             platform: macosx64-shippable/opt
 
@@ -99,8 +102,9 @@ jobs:
             upstream_artifact: target.installer.exe
             binary: core/firefox.exe
         worker-type: t-win10-64-source
+        shipping-product: firefox
         attributes:
-            build_platform: win32
+            build_platform: win32-shippable
         treeherder:
             platform: windows2012-32-shippable/opt
 
@@ -115,7 +119,8 @@ jobs:
             upstream_artifact: target.installer.exe
             binary: core/firefox.exe
         worker-type: t-win10-64-source
+        shipping-product: firefox
         attributes:
-            build_platform: win64
+            build_platform: win64-shippable
         treeherder:
             platform: windows2012-64-shippable/opt

taskcluster/taskgraph/transforms/balrog_submit.py

@@ -111,6 +111,18 @@ def make_task_description(config, jobs):
             }
         ]
 
+        dependencies = {"beetmover": dep_job.label}
+        for kind_dep in config.kind_dependencies_tasks.values():
+            if (
+                kind_dep.kind == "startup-test"
+                and kind_dep.attributes["build_platform"]
+                == attributes.get("build_platform")
+                and kind_dep.attributes["build_type"] == attributes.get("build_type")
+                and kind_dep.attributes.get("shipping_product")
+                == job.get("shipping-product")
+            ):
+                dependencies["startup-test"] = kind_dep.label
+
         task = {
             "label": label,
             "description": description,
@@ -121,7 +133,7 @@ def make_task_description(config, jobs):
                 "balrog-action": "v2-submit-locale",
                 "suffixes": ["", "-No-WNP"] if job.get("update-no-wnp") else [""],
             },
-            "dependencies": {"beetmover": dep_job.label},
+            "dependencies": dependencies,
             "attributes": attributes,
             "run-on-projects": dep_job.attributes.get("run_on_projects"),
             "treeherder": treeherder,