Bug 1106569 - Part 1 : Move oneoff search styling to shared. r=dolske

2014-12-01 08:38:00 +01:00 · 2014-12-01 08:38:00 +01:00 · f0124dd892
--- a/browser/themes/linux/jar.mn
+++ b/browser/themes/linux/jar.mn
@ -66,7 +66,7 @@ browser.jar:
  skin/classic/browser/Privacy-16.png
  skin/classic/browser/privatebrowsing-mask.png
  skin/classic/browser/reload-stop-go.png
-  skin/classic/browser/searchbar.css
+* skin/classic/browser/searchbar.css
  skin/classic/browser/search-pref.png                      (../shared/search/search-pref.png)
  skin/classic/browser/search-indicator.png                 (../shared/search/search-indicator.png)
  skin/classic/browser/search-indicator-add-engine.png      (../shared/search/search-indicator-add-engine.png)
--- a/browser/themes/linux/searchbar.css
+++ b/browser/themes/linux/searchbar.css
@ -67,178 +67,4 @@ menuitem[cmd="cmd_clearhistory"][disabled] {
  list-style-image: url("moz-icon://stock/gtk-clear?size=menu&state=disabled");
 }

-
-
-
-.searchbar-search-button-container {
-  -moz-box-align: center;
-  padding: 2px 3px;
-  -moz-padding-end: 2px;
-}
-
-.searchbar-search-button {
-  list-style-image: url("chrome://browser/skin/search-indicator.png");
-  -moz-image-region: rect(0, 20px, 20px, 0);
-  margin: -2px -2px;
-}
-
-.searchbar-search-button:hover {
-  -moz-image-region: rect(0, 40px, 20px, 20px);
-}
-
-.searchbar-search-button:hover:active {
-  -moz-image-region: rect(0, 60px, 20px, 40px);
-}
-
-searchbar[oneoffui] .search-go-button {
-  list-style-image: url("chrome://browser/skin/reload-stop-go.png");
-  -moz-image-region: rect(0, 42px, 14px, 28px);
-}
-
-searchbar[oneoffui] .search-go-button:hover {
-  -moz-image-region: rect(14px, 42px, 28px, 28px);
-}
-
-searchbar[oneoffui] .search-go-button:hover:active {
-  -moz-image-region: rect(28px, 42px, 42px, 28px);
-}
-
-searchbar[oneoffui] .search-go-button:-moz-locale-dir(rtl) > .toolbarbutton-icon {
-  transform: scaleX(-1);
-}
-
-
-.search-panel-current-engine {
-  border-top: none !important;
-  border-bottom: 1px solid #ccc;
-  -moz-box-align: center;
-}
-
-.search-panel-header {
-  font-weight: normal;
-  background-color: rgb(245, 245, 245);
-  border-top: 1px solid #ccc;
-  margin: 0 1px;
-  padding: 3px 5px;
-  color: #666;
-}
-
-.search-panel-current-input > label {
-  margin: 0 0 !important;
-}
-
-.search-panel-input-value {
-  color: black;
-}
-
-.search-panel-one-offs {
-  margin: 0 0 !important;
-  border-top: 1px solid #ccc;
-}
-
-.searchbar-engine-one-off-item {
-  -moz-appearance: none;
-  display: inline-block;
-  border: none;
-  min-width: 48px;
-  height: 32px;
-  margin: 0 0;
-  padding: 0 0;
-  background: none;
-  background-image: url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAAWCAYAAAABxvaqAAAABmJLR0QA/wD/AP+gvaeTAAAACXBIWXMAAAsTAAALEwEAmpwYAAAAB3RJTUUH3gofECQNNVW2/AAAABBJREFUGFdjOHPmzH8GehEA/KpKg9YTf4AAAAAASUVORK5CYII=');
-  background-repeat: no-repeat;
-  background-position: right center;
-}
-
-.searchbar-engine-one-off-item:not(.last-row) {
-  box-sizing: padding-box;
-  border-bottom: 1px solid #ccc;
-}
-
-.searchbar-engine-one-off-item.last-of-row {
-  background-image: none;
-}
-
-.searchbar-engine-one-off-item:hover:not(.dummy),
-.searchbar-engine-one-off-item[selected] {
-  background-color: Highlight;
-  background-image: none;
-}
-
-.searchbar-engine-one-off-item > .button-box {
-  border: none;
-  padding: 0 0;
-}
-
-.searchbar-engine-one-off-item > .button-box > .button-text {
-  display: none;
-}
-
-.searchbar-engine-one-off-item > .button-box > .button-icon {
-  display: -moz-box;
-  -moz-margin-end: 0;
-  width: 16px;
-  height: 16px;
-}
-
-.addengine-item {
-  -moz-appearance: none;
-  border: none;
-  height: 32px;
-  margin: 0 0;
-  padding: 0 10px;
-}
-
-.addengine-item > .button-box {
-  -moz-box-pack: start;
-}
-
-.addengine-item:first-of-type {
-  border-top: 1px solid #ccc;
-}
-
-.addengine-item:hover {
-  background-color: Highlight;
-  color: HighlightText;
-}
-
-.addengine-item > .button-box > .button-icon {
-  width: 16px;
-}
-
-.addengine-item > .button-box > .button-text {
-  -moz-box-flex: 1;
-  text-align: start;
-  -moz-padding-start: 10px;
-}
-
-.addengine-item:not([image]) {
-  list-style-image: url("chrome://browser/skin/search-engine-placeholder.png");
-}
-
-searchbar[oneoffui] .searchbar-engine-button {
-  display: none;
-}
-
-.search-panel-tree > .autocomplete-treebody::-moz-tree-cell {
-  -moz-padding-start: 16px;
-  border-top: none !important;
-}
-
-searchbar[oneoffui] .searchbar-engine-image {
-  -moz-margin-start: -1px;
-}
-
-.search-setting-button {
-  -moz-appearance: none;
-  border-bottom: none;
-  border-left: none;
-  border-right: none;
-  -moz-border-top-colors: none;
-  min-height: 32px;
-}
-
-.search-setting-button:hover {
-  background-color: #d3d3d3;
-  border-top-color: #bdbebe;
-}
+%include ../shared/searchbar.inc.css
--- a/browser/themes/osx/jar.mn
+++ b/browser/themes/osx/jar.mn
@ -101,7 +101,7 @@ browser.jar:
  skin/classic/browser/reload-stop-go@2x.png
  skin/classic/browser/searchbar-dropmarker.png
  skin/classic/browser/searchbar-dropmarker@2x.png
-  skin/classic/browser/searchbar.css
+* skin/classic/browser/searchbar.css
  skin/classic/browser/Search.png
  skin/classic/browser/Search@2x.png
  skin/classic/browser/search-pref.png                         (../shared/search/search-pref.png)
--- a/browser/themes/osx/searchbar.css
+++ b/browser/themes/osx/searchbar.css
@ -47,42 +47,11 @@
  -moz-padding-end: 6px;
 }

-.searchbar-search-button-container {
-  -moz-box-align: center;
-  -moz-padding-start: 6px;
-  -moz-padding-end: 4px;
-}
-
 .search-go-button {
  list-style-image: url("chrome://browser/skin/Search.png");
 }

-.searchbar-search-button {
-  list-style-image: url("chrome://browser/skin/search-indicator.png");
-  -moz-image-region: rect(0, 20px, 20px, 0);
-  margin: 0 -3px;
-}
-
-.searchbar-search-button:hover {
-  -moz-image-region: rect(0, 40px, 20px, 20px);
-}
-
-.searchbar-search-button:hover:active {
-  -moz-image-region: rect(0, 60px, 20px, 40px);
-}
-
-searchbar[oneoffui] .search-go-button {
-  list-style-image: url("chrome://browser/skin/reload-stop-go.png");
-  -moz-image-region: rect(0, 42px, 14px, 28px);
-}
-
-searchbar[oneoffui] .search-go-button:hover:active {
-  -moz-image-region: rect(14px, 42px, 28px, 28px);
-}
-
-searchbar[oneoffui] .search-go-button:-moz-locale-dir(rtl) > .toolbarbutton-icon {
-  transform: scaleX(-1);
-}
+%include ../shared/searchbar.inc.css

@media (min-resolution: 2dppx) {
  .searchbar-engine-image {
@ -124,139 +93,16 @@ searchbar[oneoffui] .search-go-button:-moz-locale-dir(rtl) > .toolbarbutton-icon
    -moz-image-region: rect(28px, 84px, 56px, 56px);
    width: 14px;
  }
-}

-.search-panel-current-engine {
-  border-top: none !important;
-  border-bottom: 1px solid #ccc;
-  border-radius: 4px 4px 0 0;
-}
-
-.search-panel-header {
-  font-size: 10px;
-  font-weight: normal;
-  background-color: rgb(245, 245, 245);
-  border-top: 1px solid #ccc;
-  margin: 0;
-  padding: 3px 6px;
-  color: #666;
-}
-
-.search-panel-current-input > label {
-  margin: 0 0 !important;
-}
-
-.search-panel-input-value {
-  color: black;
-}
-
-.search-panel-one-offs {
-  border-top: 1px solid #ccc;
-  margin-bottom: 0 !important;
-}
-
-.searchbar-engine-one-off-item {
-  -moz-appearance: none;
-  display: inline-block;
-  min-width: 48px;
-  height: 32px;
-  margin: 0 0;
-  padding: 0 0;
-  background-image: url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAAWCAYAAAABxvaqAAAABmJLR0QA/wD/AP+gvaeTAAAACXBIWXMAAAsTAAALEwEAmpwYAAAAB3RJTUUH3gofECQNNVW2/AAAABBJREFUGFdjOHPmzH8GehEA/KpKg9YTf4AAAAAASUVORK5CYII=');
-  background-repeat: no-repeat;
-  background-position: right center;
-}
-
-.searchbar-engine-one-off-item:not(.last-row) {
-  box-sizing: padding-box;
-  border-bottom: 1px solid #ccc;
-}
-
-.searchbar-engine-one-off-item.last-of-row {
-  background-image: none;
-}
-
-.searchbar-engine-one-off-item:hover:not(.dummy),
-.searchbar-engine-one-off-item[selected] {
-  background-color: Highlight;
-  background-image: none;
-}
-
-.searchbar-engine-one-off-item > .button-box > .button-text {
-  display: none;
-}
-
-.searchbar-engine-one-off-item > .button-box > .button-icon {
-  -moz-margin-start: 0;
-  width: 16px;
-  height: 16px;
-}
-
-.addengine-item {
-  -moz-appearance: none;
-  font-size: 10px;
-  height: 32px;
-  margin: 0 0;
-  padding: 0 10px;
-}
-
-.addengine-item > .button-box {
-  -moz-box-pack: start;
-}
-
-.addengine-item:first-of-type {
-  border-top: 1px solid #ccc;
-}
-
-.addengine-item:hover {
-  background-color: Highlight;
-  color: HighlightText;
-}
-
-.addengine-item > .button-box > .button-icon {
-  width: 16px;
-}
-
-.addengine-item > .button-box > .button-text {
-  -moz-box-flex: 1;
-  text-align: start;
-  -moz-padding-start: 10px;
-}
-
-.addengine-item:not([image]) {
-  list-style-image: url("chrome://browser/skin/search-engine-placeholder.png");
-}
-
-@media (min-resolution: 2dppx) {
  .addengine-item:not([image]) {
    list-style-image: url("chrome://browser/skin/search-engine-placeholder@2x.png");
  }
 }

-searchbar[oneoffui] .searchbar-engine-button {
-  display: none;
-}
-
-.search-panel-tree > .autocomplete-treebody::-moz-tree-cell {
-  -moz-padding-start: 22px;
-  border-top: none !important;
-}
-
 #PopupSearchAutoComplete {
  border-radius: 4px;
 }

-.search-setting-button {
-  -moz-appearance: none;
-  border-radius: 0 0 4px 4px;
-  min-height: 32px;
-}
-
 .search-setting-button[showonlysettings] {
  border-radius: 4px;
-}
-
-.search-setting-button:hover {
-  background-color: #d3d3d3;
-  border-top-color: #bdbebe;
-}
+}
--- a/browser/themes/shared/searchbar.inc.css
+++ b/browser/themes/shared/searchbar.inc.css
@ -0,0 +1,170 @@
+.searchbar-search-button-container {
+  -moz-box-align: center;
+  padding: 3px 4px;
+  -moz-padding-end: 2px;
+}
+
+.searchbar-search-button {
+  list-style-image: url("chrome://browser/skin/search-indicator.png");
+  -moz-image-region: rect(0, 20px, 20px, 0);
+  margin: -2px -2px;
+}
+
+.searchbar-search-button:hover {
+  -moz-image-region: rect(0, 40px, 20px, 20px);
+}
+
+.searchbar-search-button:hover:active {
+  -moz-image-region: rect(0, 60px, 20px, 40px);
+}
+
+searchbar[oneoffui] .search-go-button {
+  list-style-image: url("chrome://browser/skin/reload-stop-go.png");
+  -moz-image-region: rect(0, 42px, 14px, 28px);
+}
+
+searchbar[oneoffui] .search-go-button:hover {
+  -moz-image-region: rect(14px, 42px, 28px, 28px);
+}
+
+searchbar[oneoffui] .search-go-button:hover:active {
+  -moz-image-region: rect(28px, 42px, 42px, 28px);
+}
+
+searchbar[oneoffui] .search-go-button:-moz-locale-dir(rtl) > .toolbarbutton-icon {
+  transform: scaleX(-1);
+}
+
+
+.search-panel-current-engine {
+  border-top: none !important;
+  border-bottom: 1px solid #ccc;
+  -moz-box-align: center;
+}
+
+.search-panel-header {
+  font-weight: normal;
+  background-color: rgb(245, 245, 245);
+  border-top: 1px solid #ccc;
+  margin: 0;
+  padding: 3px 6px;
+  color: #666;
+}
+
+.search-panel-current-input > label {
+  margin: 0 0 !important;
+}
+
+.search-panel-input-value {
+  color: black;
+}
+
+.search-panel-one-offs {
+  margin: 0 0 !important;
+  border-top: 1px solid #ccc;
+}
+
+.searchbar-engine-one-off-item {
+  -moz-appearance: none;
+  display: inline-block;
+  border: none;
+  min-width: 48px;
+  height: 32px;
+  margin: 0 0;
+  padding: 0 0;
+  background: none;
+  background-image: url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAAWCAYAAAABxvaqAAAABmJLR0QA/wD/AP+gvaeTAAAACXBIWXMAAAsTAAALEwEAmpwYAAAAB3RJTUUH3gofECQNNVW2/AAAABBJREFUGFdjOHPmzH8GehEA/KpKg9YTf4AAAAAASUVORK5CYII=');
+  background-repeat: no-repeat;
+  background-position: right center;
+}
+
+.searchbar-engine-one-off-item:not(.last-row) {
+  box-sizing: padding-box;
+  border-bottom: 1px solid #ccc;
+}
+
+.searchbar-engine-one-off-item.last-of-row {
+  background-image: none;
+}
+
+.searchbar-engine-one-off-item:hover:not(.dummy),
+.searchbar-engine-one-off-item[selected] {
+  background-color: Highlight;
+  background-image: none;
+}
+
+.searchbar-engine-one-off-item > .button-box {
+  border: none;
+  padding: 0 0;
+}
+
+.searchbar-engine-one-off-item > .button-box > .button-text {
+  display: none;
+}
+
+.searchbar-engine-one-off-item > .button-box > .button-icon {
+  width: 16px;
+  height: 16px;
+}
+
+.addengine-item {
+  -moz-appearance: none;
+  border: none;
+  height: 32px;
+  margin: 0 0;
+  padding: 0 10px;
+}
+
+.addengine-item > .button-box {
+  -moz-box-pack: start;
+}
+
+.addengine-item:first-of-type {
+  border-top: 1px solid #ccc;
+}
+
+.addengine-item:hover {
+  background-color: Highlight;
+  color: HighlightText;
+}
+
+.addengine-item > .button-box > .button-icon {
+  width: 16px;
+}
+
+.addengine-item > .button-box > .button-text {
+  -moz-box-flex: 1;
+  text-align: start;
+  -moz-padding-start: 10px;
+}
+
+.addengine-item:not([image]) {
+  list-style-image: url("chrome://browser/skin/search-engine-placeholder.png");
+}
+
+searchbar[oneoffui] .searchbar-engine-button {
+  display: none;
+}
+
+.search-panel-tree > .autocomplete-treebody::-moz-tree-cell {
+  -moz-padding-start: 15px;
+  border-top: none !important;
+}
+
+searchbar[oneoffui] .searchbar-engine-image {
+  -moz-margin-start: -1px;
+}
+
+.search-setting-button {
+  -moz-appearance: none;
+  border-bottom: none;
+  border-left: none;
+  border-right: none;
+  -moz-border-top-colors: none;
+  min-height: 32px;
+}
+
+.search-setting-button:hover {
+  background-color: #d3d3d3;
+  border-top-color: #bdbebe;
+}
--- a/browser/themes/windows/jar.mn
+++ b/browser/themes/windows/jar.mn
@ -80,7 +80,7 @@ browser.jar:
        skin/classic/browser/privatebrowsing-mask-titlebar-XPVista7.png
        skin/classic/browser/privatebrowsing-mask-titlebar-XPVista7-tall.png
        skin/classic/browser/reload-stop-go.png
-        skin/classic/browser/searchbar.css
+*       skin/classic/browser/searchbar.css
        skin/classic/browser/searchbar-dropdown-arrow.png
        skin/classic/browser/search-pref.png                         (../shared/search/search-pref.png)
        skin/classic/browser/search-indicator.png                    (../shared/search/search-indicator.png)
@ -525,7 +525,7 @@ browser.jar:
        skin/classic/aero/browser/privatebrowsing-mask-titlebar-XPVista7.png
        skin/classic/aero/browser/privatebrowsing-mask-titlebar-XPVista7-tall.png
        skin/classic/aero/browser/reload-stop-go.png
-        skin/classic/aero/browser/searchbar.css
+*       skin/classic/aero/browser/searchbar.css
        skin/classic/aero/browser/searchbar-dropdown-arrow.png       (searchbar-dropdown-arrow-aero.png)
        skin/classic/aero/browser/search-pref.png                    (../shared/search/search-pref.png)
        skin/classic/aero/browser/search-indicator.png               (../shared/search/search-indicator.png)
--- a/browser/themes/windows/searchbar.css
+++ b/browser/themes/windows/searchbar.css
@ -79,175 +79,4 @@
  font-weight: bold;
 }

-
-
-.searchbar-search-button-container {
-  -moz-box-align: center;
-  padding: 3px 4px;
-  -moz-padding-end: 2px;
-}
-
-.searchbar-search-button {
-  list-style-image: url("chrome://browser/skin/search-indicator.png");
-  -moz-image-region: rect(0, 20px, 20px, 0);
-  margin: -2px -2px;
-}
-
-.searchbar-search-button:hover {
-  -moz-image-region: rect(0, 40px, 20px, 20px);
-}
-
-.searchbar-search-button:hover:active {
-  -moz-image-region: rect(0, 60px, 20px, 40px);
-}
-
-searchbar[oneoffui] .search-go-button {
-  list-style-image: url("chrome://browser/skin/reload-stop-go.png");
-  -moz-image-region: rect(0, 42px, 14px, 28px);
-}
-
-searchbar[oneoffui] .search-go-button:hover {
-  -moz-image-region: rect(14px, 42px, 28px, 28px);
-}
-
-searchbar[oneoffui] .search-go-button:hover:active {
-  -moz-image-region: rect(28px, 42px, 42px, 28px);
-}
-
-searchbar[oneoffui] .search-go-button:-moz-locale-dir(rtl) > .toolbarbutton-icon {
-  transform: scaleX(-1);
-}
-
-
-.search-panel-current-engine {
-  border-top: none !important;
-  border-bottom: 1px solid #ccc;
-  -moz-box-align: center;
-}
-
-.search-panel-header {
-  font-weight: normal;
-  background-color: rgb(245, 245, 245);
-  border-top: 1px solid #ccc;
-  margin: 0;
-  padding: 3px 6px;
-  color: #666;
-}
-
-.search-panel-current-input > label {
-  margin: 0 0 !important;
-}
-
-.search-panel-input-value {
-  color: black;
-}
-
-.search-panel-one-offs {
-  margin: 0 0 !important;
-  border-top: 1px solid #ccc;
-}
-
-.searchbar-engine-one-off-item {
-  -moz-appearance: none;
-  display: inline-block;
-  border: none;
-  min-width: 48px;
-  height: 32px;
-  margin: 0 0;
-  padding: 0 0;
-  background: none;
-  background-image: url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAAWCAYAAAABxvaqAAAABmJLR0QA/wD/AP+gvaeTAAAACXBIWXMAAAsTAAALEwEAmpwYAAAAB3RJTUUH3gofECQNNVW2/AAAABBJREFUGFdjOHPmzH8GehEA/KpKg9YTf4AAAAAASUVORK5CYII=');
-  background-repeat: no-repeat;
-  background-position: right center;
-}
-
-.searchbar-engine-one-off-item:not(.last-row) {
-  box-sizing: padding-box;
-  border-bottom: 1px solid #ccc;
-}
-
-.searchbar-engine-one-off-item.last-of-row {
-  background-image: none;
-}
-
-.searchbar-engine-one-off-item:hover:not(.dummy),
-.searchbar-engine-one-off-item[selected] {
-  background-color: Highlight;
-  background-image: none;
-}
-
-.searchbar-engine-one-off-item > .button-box {
-  border: none;
-  padding: 0 0;
-}
-
-.searchbar-engine-one-off-item > .button-box > .button-text {
-  display: none;
-}
-
-.searchbar-engine-one-off-item > .button-box > .button-icon {
-  width: 16px;
-  height: 16px;
-}
-
-.addengine-item {
-  -moz-appearance: none;
-  border: none;
-  height: 32px;
-  margin: 0 0;
-  padding: 0 10px;
-}
-
-.addengine-item > .button-box {
-  -moz-box-pack: start;
-}
-
-.addengine-item:first-of-type {
-  border-top: 1px solid #ccc;
-}
-
-.addengine-item:hover {
-  background-color: Highlight;
-  color: HighlightText;
-}
-
-.addengine-item > .button-box > .button-icon {
-  width: 16px;
-}
-
-.addengine-item > .button-box > .button-text {
-  -moz-box-flex: 1;
-  text-align: start;
-  -moz-padding-start: 10px;
-}
-
-.addengine-item:not([image]) {
-  list-style-image: url("chrome://browser/skin/search-engine-placeholder.png");
-}
-
-searchbar[oneoffui] .searchbar-engine-button {
-  display: none;
-}
-
-.search-panel-tree > .autocomplete-treebody::-moz-tree-cell {
-  -moz-padding-start: 15px;
-  border-top: none !important;
-}
-
-searchbar[oneoffui] .searchbar-engine-image {
-  -moz-margin-start: -1px;
-}
-
-.search-setting-button {
-  -moz-appearance: none;
-  border-bottom: none;
-  border-left: none;
-  border-right: none;
-  -moz-border-top-colors: none;
-  min-height: 32px;
-}
-
-.search-setting-button:hover {
-  background-color: #d3d3d3;
-  border-top-color: #bdbebe;
-}
+%include ../shared/searchbar.inc.css