From f0253701917fece6729210e6a8a89ef67da324c6 Mon Sep 17 00:00:00 2001
From: Benjamin Bouvier <benj@benj.me>
Date: Thu, 14 Feb 2019 11:52:57 +0100
Subject: [PATCH] Bug 1527861: Allow disabling BinAST compilation; r=tcampbell

Differential Revision: https://phabricator.services.mozilla.com/D19765

--HG--
extra : rebase_source : 059c236c7c3bcfff8349072cfb7a0364cf4d5f71
extra : amend_source : ee72ef04d5bc75c003f6aa3eedae028a8a3f491d
extra : histedit_source : 795c699d7f003b69569e8aacede6fea76b6e79f9
---
 js/moz.configure          | 15 +++++++++------
 js/src/frontend/moz.build |  4 ++++
 js/src/moz.build          |  1 -
 3 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/js/moz.configure b/js/moz.configure
index 07930e513163..5e56b8317e1f 100644
--- a/js/moz.configure
+++ b/js/moz.configure
@@ -475,13 +475,16 @@ set_define('ENABLE_PIPELINE_OPERATOR', enable_pipeline_operator)
 # Experimental support for BinAST
 # ==============================================================
 
-@depends(milestone)
-def enable_build_binast(milestone):
-    if milestone.is_nightly:
-        return True
+@depends(milestone.is_nightly)
+def default_binast(is_nightly):
+    return is_nightly
 
-set_define('JS_BUILD_BINAST', enable_build_binast)
-set_config('JS_BUILD_BINAST', enable_build_binast)
+js_option('--enable-binast',
+          default=default_binast,
+          help="{Enable|Disable} BinAST support")
+
+set_config('JS_BUILD_BINAST', depends_if('--enable-binast')(lambda x: True))
+set_define('JS_BUILD_BINAST', depends_if('--enable-binast')(lambda x: True))
 
 
 # Experimental support for wasm code generation with Cranelift
diff --git a/js/src/frontend/moz.build b/js/src/frontend/moz.build
index adf62256f158..26026388f986 100644
--- a/js/src/frontend/moz.build
+++ b/js/src/frontend/moz.build
@@ -76,6 +76,10 @@ if CONFIG['JS_BUILD_BINAST']:
         'BinTokenReaderMultipart.cpp',
     ]
 
+    DIRS += [
+        'binsource'
+    ]
+
     # Instrument BinAST files for fuzzing as we have a fuzzing target for BinAST.
     if CONFIG['FUZZING_INTERFACES'] and CONFIG['LIBFUZZER']:
         include('/tools/fuzzing/libfuzzer-flags.mozbuild')
diff --git a/js/src/moz.build b/js/src/moz.build
index 2690de939433..c1bcd33b2cc7 100755
--- a/js/src/moz.build
+++ b/js/src/moz.build
@@ -409,7 +409,6 @@ else:
 DIRS += [
     'build',
     'frontend',
-    'frontend/binsource',
     'gc',
     'jit',
     'wasm',