Bug 1746298 - Move --enable-dump-painting to python configure. r=firefox-build-system-reviewers,mhentges

Differential Revision: https://phabricator.services.mozilla.com/D133969

build/moz.configure/old.configure

@@ -91,7 +91,6 @@ def old_configure_options(*options):
 @old_configure_options(
     "--cache-file",
     "--datadir",
-    "--enable-dump-painting",
     "--enable-extensions",
     "--enable-libproxy",
     "--enable-logrefcnt",

old-configure.in

@@ -1680,21 +1680,6 @@ elif test -z "$_ENABLE_LOGREFCNT"; then
     AC_DEFINE(NO_BUILD_REFCNT_LOGGING)
 fi
 
-dnl ========================================================
-dnl moz_dump_painting
-dnl ========================================================
-MOZ_ARG_ENABLE_BOOL(dump-painting,
-[  --enable-dump-painting          Enable paint debugging.],
-    MOZ_DUMP_PAINTING=1,
-    MOZ_DUMP_PAINTING= )
-if test -n "$MOZ_DUMP_PAINTING"; then
-    AC_DEFINE(MOZ_DUMP_PAINTING)
-    AC_DEFINE(MOZ_LAYERS_HAVE_LOG)
-fi
-if test -n "$MOZ_DEBUG"; then
-    AC_DEFINE(MOZ_DUMP_PAINTING)
-fi
-
 case "${OS_TARGET}" in
 Android|WINNT|Darwin)
   MOZ_GLUE_IN_PROGRAM=

toolkit/moz.configure

@@ -2720,3 +2720,17 @@ set_config("NECKO_WIFI_DBUS", True, when=necko_wifi_dbus)
 option("--enable-debug-js-modules", help="Enable debug mode for frontend JS libraries")
 
 set_config("DEBUG_JS_MODULES", True, when="--enable-debug-js-modules")
+
+
+# moz_dump_painting
+# ==============================================================
+option("--enable-dump-painting", help="Enable paint debugging")
+
+set_define(
+    "MOZ_DUMP_PAINTING",
+    True,
+    when=depends("--enable-dump-painting", "--enable-debug")(
+        lambda painting, debug: painting or debug
+    ),
+)
+set_define("MOZ_LAYERS_HAVE_LOG", True, when="--enable-dump-painting")