Bug 1392641 Check return value for functions declared with warn_unused_result r=bagder,nwgh

MozReview-Commit-ID: BJj3Lvtntd6

--HG--
extra : rebase_source : 1776aab1d6de123323dc034d11b24a6c7b9d7ea1

netwerk/base/BackgroundFileSaver.cpp

@@ -908,7 +908,12 @@ BackgroundFileSaver::ExtractSignatureInfo(const nsAString& filePath)
             LOG(("Couldn't create NSS cert [this = %p]", this));
             break;
           }
-          nssCertList->AddCert(nssCert);
+          rv = nssCertList->AddCert(nssCert);
+          if (NS_FAILED(rv)) {
+            extractionSuccess = false;
+            LOG(("Couldn't add NSS cert to cert list [this = %p]", this));
+            break;
+          }
           nsString subjectName;
           nssCert->GetSubjectName(subjectName);
           LOG(("Adding cert %s [this = %p]",

netwerk/protocol/http/nsHttpNTLMAuth.cpp

@@ -351,7 +351,9 @@ nsHttpNTLMAuth::GenerateCredentials(nsIHttpAuthenticableChannel *authChannel,
 
             uint32_t length;
             uint8_t* certArray;
-            cert->GetRawDER(&length, &certArray);
+            rv = cert->GetRawDER(&length, &certArray);
+            if (NS_FAILED(rv))
+                return rv;
 
             // If there is a server certificate, we pass it along the
             // first time we call GetNextToken().

netwerk/system/win32/nsNotifyAddrListener.cpp

@@ -213,7 +213,11 @@ bool nsNotifyAddrListener::findMac(char *gateway)
                     sha1.finish(digest);
                     nsCString newString(reinterpret_cast<char*>(digest),
                                         SHA1Sum::kHashSize);
-                    Base64Encode(newString, output);
+                    nsresult rv = Base64Encode(newString, output);
+                    if (NS_FAILED(rv)) {
+                        found = false;
+                        break;
+                    }
                     LOG(("networkid: id %s\n", output.get()));
                     if (mNetworkId != output) {
                         // new id