Bug 1028588 - Fix dangerous public destructors in Gonk-specific dom/media code - r=ehsan

dom/media/MediaPermissionGonk.cpp

@@ -150,7 +150,6 @@ public:
 
   MediaPermissionRequest(nsRefPtr<dom::GetUserMediaRequest> &aRequest,
                          nsTArray<nsCOMPtr<nsIMediaDevice> > &aDevices);
-  virtual ~MediaPermissionRequest() {}
 
   // It will be called when prompt dismissed.
   virtual bool Recv__delete__(const bool &allow,
@@ -159,6 +158,9 @@ public:
 
   already_AddRefed<nsPIDOMWindow> GetOwner();
 
+protected:
+  virtual ~MediaPermissionRequest() {}
+
 private:
   nsresult DoAllow(const nsString &audioDevice, const nsString &videoDevice);
 
@@ -378,6 +380,8 @@ public:
 
   MediaDeviceSuccessCallback(nsRefPtr<dom::GetUserMediaRequest> &aRequest)
     : mRequest(aRequest) {}
+
+protected:
   virtual ~MediaDeviceSuccessCallback() {}
 
 private:
@@ -479,6 +483,7 @@ public:
   MediaDeviceErrorCallback(const nsAString &aCallID)
     : mCallID(aCallID) {}
 
+protected:
   virtual ~MediaDeviceErrorCallback() {}
 
 private:

dom/media/MediaPermissionGonk.h

@@ -23,6 +23,8 @@ public:
   NS_DECL_NSIOBSERVER
 
   static MediaPermissionManager* GetInstance();
+
+protected:
   virtual ~MediaPermissionManager();
 
 private: