Bug 1253706: If no pairs are started, but gathering is done, do not cancel the grace period timer. r=mjf

This was a pre-existing bug detected by new tests. Also add a little logging.

Differential Revision: https://phabricator.services.mozilla.com/D135371

dom/media/webrtc/transport/third_party/nICEr/src/ice/ice_peer_ctx.c

@@ -390,6 +390,7 @@ static void nr_ice_peer_ctx_start_trickle_timer(nr_ice_peer_ctx *pctx)
     NR_reg_get_uint4(NR_ICE_REG_TRICKLE_GRACE_PERIOD,&grace_period_timeout);
 
     if (grace_period_timeout) {
+      r_log(LOG_ICE,LOG_INFO,"ICE(%s): peer (%s) starting grace period timer for %u ms",pctx->ctx->label,pctx->label, grace_period_timeout);
       /* If we're doing trickle, we need to allow a grace period for new
        * trickle candidates to arrive in case the pairs we have fail quickly. */
        NR_ASYNC_TIMER_SET(grace_period_timeout,nr_ice_peer_ctx_trickle_wait_cb,pctx,&pctx->trickle_grace_period_timer);
@@ -618,8 +619,8 @@ int nr_ice_peer_ctx_start_checks2(nr_ice_peer_ctx *pctx, int allow_non_first)
       stream=STAILQ_NEXT(stream, entry);
     }
 
-    if (!started) {
-      r_log(LOG_ICE,LOG_NOTICE,"ICE(%s): peer (%s) no checks to start",pctx->ctx->label,pctx->label);
+    if (!started && pctx->ctx->uninitialized_candidates) {
+      r_log(LOG_ICE,LOG_INFO,"ICE(%s): peer (%s) no checks to start, but gathering is not done yet, cancelling grace period timer",pctx->ctx->label,pctx->label);
       /* Never mind on the grace period timer */
       NR_async_timer_cancel(pctx->trickle_grace_period_timer);
       pctx->trickle_grace_period_timer=0;
@@ -748,6 +749,7 @@ void nr_ice_peer_ctx_check_if_connected(nr_ice_peer_ctx *pctx)
 
     /* Make sure grace period timer is cancelled */
     if(pctx->trickle_grace_period_timer) {
+      r_log(LOG_ICE,LOG_INFO,"ICE(%s): peer (%s) cancelling grace period timer",pctx->ctx->label,pctx->label);
       NR_async_timer_cancel(pctx->trickle_grace_period_timer);
       pctx->trickle_grace_period_timer=0;
     }