Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium.

The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.

--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973

accessible/atk/moz.build

@@ -55,5 +55,3 @@ include('/ipc/chromium/chromium-config.mozbuild')
 if CONFIG['CLANG_CXX']:
     # Suppress clang warning about unused function from gobject's RTTI macros.
     CXXFLAGS += ['-Wno-unused-function']
-
-FAIL_ON_WARNINGS = True

accessible/base/moz.build

@@ -97,5 +97,3 @@ if CONFIG['MOZ_ENABLE_GTK']:
     CXXFLAGS += CONFIG['MOZ_CAIRO_CFLAGS']
 
 include('/ipc/chromium/chromium-config.mozbuild')
-
-FAIL_ON_WARNINGS = True

accessible/generic/moz.build

@@ -57,5 +57,3 @@ else:
 FINAL_LIBRARY = 'xul'
 
 include('/ipc/chromium/chromium-config.mozbuild')
-
-FAIL_ON_WARNINGS = True

accessible/html/moz.build

@@ -43,5 +43,3 @@ else:
     ]
 
 FINAL_LIBRARY = 'xul'
-
-FAIL_ON_WARNINGS = True

accessible/ipc/moz.build

@@ -47,5 +47,3 @@ if CONFIG['ACCESSIBILITY']:
     FINAL_LIBRARY = 'xul'
 
 include('/ipc/chromium/chromium-config.mozbuild')
-
-FAIL_ON_WARNINGS = True

accessible/mac/moz.build

@@ -41,5 +41,3 @@ LOCAL_INCLUDES += [
 FINAL_LIBRARY = 'xul'
 
 include('/ipc/chromium/chromium-config.mozbuild')
-
-FAIL_ON_WARNINGS = True

accessible/other/moz.build

@@ -22,5 +22,3 @@ LOCAL_INCLUDES += [
 ]
 
 FINAL_LIBRARY = 'xul'
-
-FAIL_ON_WARNINGS = True

accessible/windows/ia2/moz.build

@@ -50,6 +50,4 @@ FINAL_LIBRARY = 'xul'
 if CONFIG['GNU_CXX']:
     CXXFLAGS += ['-Wshadow']
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')

accessible/windows/msaa/moz.build

@@ -64,5 +64,3 @@ FINAL_LIBRARY = 'xul'
 
 if CONFIG['GNU_CXX']:
     CXXFLAGS += ['-Wshadow']
-
-FAIL_ON_WARNINGS = True

accessible/windows/sdn/moz.build

@@ -23,5 +23,3 @@ FINAL_LIBRARY = 'xul'
 
 if CONFIG['GNU_CXX']:
     CXXFLAGS += ['-Wshadow']
-
-FAIL_ON_WARNINGS = True

accessible/windows/uia/moz.build

@@ -18,5 +18,3 @@ LOCAL_INCLUDES += [
 ]
 
 FINAL_LIBRARY = 'xul'
-
-FAIL_ON_WARNINGS = True

accessible/xpcom/moz.build

@@ -48,5 +48,5 @@ else:
 
 FINAL_LIBRARY = 'xul'
 
-if CONFIG['GNU_CXX']:
-    FAIL_ON_WARNINGS = True
+if not CONFIG['GNU_CXX']:
+    ALLOW_COMPILER_WARNINGS = True

accessible/xul/moz.build

@@ -48,5 +48,3 @@ else:
     ]
 
 FINAL_LIBRARY = 'xul'
-
-FAIL_ON_WARNINGS = True

b2g/app/moz.build

@@ -78,8 +78,6 @@ if CONFIG['OS_ARCH'] == 'WINNT':
 if CONFIG['GNU_CXX']:
     CXXFLAGS += ['-Wshadow']
 
-FAIL_ON_WARNINGS = True
-
 JS_PREFERENCE_FILES += [
     'b2g.js',
 ]

b2g/config/mozconfigs/linux32_gecko/debug

@@ -19,7 +19,7 @@ export MOZILLA_OFFICIAL=1
 
 export MOZ_TELEMETRY_REPORTING=1
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 # Use sccache

b2g/config/mozconfigs/linux32_gecko/nightly

@@ -19,7 +19,7 @@ export MOZILLA_OFFICIAL=1
 
 export MOZ_TELEMETRY_REPORTING=1
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 # Use sccache

b2g/config/mozconfigs/linux64_gecko/debug

@@ -19,7 +19,7 @@ export MOZILLA_OFFICIAL=1
 
 export MOZ_TELEMETRY_REPORTING=1
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 # Use sccache

b2g/config/mozconfigs/linux64_gecko/nightly

@@ -19,7 +19,7 @@ export MOZILLA_OFFICIAL=1
 
 export MOZ_TELEMETRY_REPORTING=1
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 # Use sccache

b2g/config/mozconfigs/macosx64_gecko/debug

@@ -18,7 +18,7 @@ export MOZ_TELEMETRY_REPORTING=1
 
 #ac_add_options --with-macbundlename-prefix=Firefox
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 # B2G Stuff

b2g/config/mozconfigs/macosx64_gecko/nightly

@@ -19,7 +19,7 @@ export MOZ_TELEMETRY_REPORTING=1
 
 #ac_add_options --with-macbundlename-prefix=Firefox
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 # B2G Stuff

b2g/dev/config/mozconfigs/macosx64/mulet

@@ -17,7 +17,7 @@ export MOZILLA_OFFICIAL=1
 
 ac_add_options --with-macbundlename-prefix=Firefox
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 # Package js shell.

b2g/gaia/moz.build

@@ -20,5 +20,3 @@ if not CONFIG['MOZ_B2GDROID']:
         ]
         DEFINES['B2G_NAME'] = '"%s-bin%s"' % (PROGRAM, CONFIG['BIN_SUFFIX'])
         DEFINES['GAIA_PATH'] = '"gaia/profile"'
-
-FAIL_ON_WARNINGS = True

browser/app/moz.build

@@ -86,5 +86,3 @@ JAR_MANIFESTS += ['jar.mn']
 
 if CONFIG['GNU_CXX']:
     CXXFLAGS += ['-Wshadow']
-
-FAIL_ON_WARNINGS = True

browser/components/about/moz.build

@@ -17,5 +17,3 @@ FINAL_LIBRARY = 'browsercomps'
 LOCAL_INCLUDES += [
     '../build',
 ]
-
-FAIL_ON_WARNINGS = True

browser/components/build/moz.build

@@ -34,5 +34,3 @@ if CONFIG['OS_ARCH'] == 'WINNT':
 # GTK2: Need to link with glib for GNOME shell service
 if CONFIG['MOZ_WIDGET_TOOLKIT'] in ('cocoa', 'gtk2', 'gtk3'):
     OS_LIBS += CONFIG['TK_LIBS']
-
-FAIL_ON_WARNINGS = True

browser/components/dirprovider/moz.build

@@ -21,5 +21,3 @@ FINAL_LIBRARY = 'browsercomps'
 LOCAL_INCLUDES += [
     '../build'
 ]
-
-FAIL_ON_WARNINGS = True

browser/components/feeds/moz.build

@@ -40,7 +40,5 @@ LOCAL_INCLUDES += [
     '../build',
 ]
 
-FAIL_ON_WARNINGS = True
-
 with Files('**'):
     BUG_COMPONENT = ('Firefox', 'RSS Discovery and Preview')

browser/components/migration/moz.build

@@ -62,7 +62,5 @@ if CONFIG['OS_ARCH'] == 'WINNT':
 
 FINAL_LIBRARY = 'browsercomps'
 
-FAIL_ON_WARNINGS = True
-
 with Files('**'):
     BUG_COMPONENT = ('Firefox', 'Migration')

browser/components/shell/moz.build

@@ -50,7 +50,5 @@ for var in ('MOZ_APP_NAME', 'MOZ_APP_VERSION'):
 
 CXXFLAGS += CONFIG['TK_CFLAGS']
 
-FAIL_ON_WARNINGS = True
-
 with Files('**'):
     BUG_COMPONENT = ('Firefox', 'Shell Integration')

browser/config/mozconfigs/linux32/common-opt

@@ -13,7 +13,7 @@ export MOZILLA_OFFICIAL=1
 
 export MOZ_TELEMETRY_REPORTING=1
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 # Package js shell.

browser/config/mozconfigs/linux32/debug

@@ -12,7 +12,7 @@ export MOZILLA_OFFICIAL=1
 
 #Use ccache
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 # Package js shell.

browser/config/mozconfigs/linux64/common-opt

@@ -13,7 +13,7 @@ export MOZILLA_OFFICIAL=1
 
 export MOZ_TELEMETRY_REPORTING=1
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 # Package js shell.

browser/config/mozconfigs/linux64/debug

@@ -10,7 +10,7 @@ MOZ_AUTOMATION_L10N_CHECK=0
 # Needed to enable breakpad in application.ini
 export MOZILLA_OFFICIAL=1
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 # Package js shell.

browser/config/mozconfigs/macosx-universal/common-opt

@@ -16,7 +16,7 @@ export MOZILLA_OFFICIAL=1
 
 export MOZ_TELEMETRY_REPORTING=1
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 # Package js shell.

browser/config/mozconfigs/macosx64/debug

@@ -12,7 +12,7 @@ if test "${MOZ_UPDATE_CHANNEL}" = "nightly"; then
 ac_add_options --with-macbundlename-prefix=Firefox
 fi
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 # Package js shell.

browser/config/mozconfigs/macosx64/debug-static-analysis

@@ -7,7 +7,7 @@ MOZ_AUTOMATION_L10N_CHECK=0
 ac_add_options --enable-debug
 ac_add_options --enable-dmd
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 ac_add_options --enable-clang-plugin

browser/config/mozconfigs/macosx64/nightly

@@ -10,7 +10,7 @@ if test "${MOZ_UPDATE_CHANNEL}" = "nightly"; then
 ac_add_options --with-macbundlename-prefix=Firefox
 fi
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 # Package js shell.

browser/config/mozconfigs/win32/common-opt

@@ -29,7 +29,7 @@ export MOZ_TELEMETRY_REPORTING=1
 
 . $topsrcdir/build/win32/mozconfig.vs2013-win64
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 # Enable Adobe Primetime CDM on 32-bit Windows in Mozilla builds.

browser/config/mozconfigs/win32/debug

@@ -20,7 +20,7 @@ export MOZILLA_OFFICIAL=1
 
 . $topsrcdir/build/win32/mozconfig.vs2013-win64
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 # Package js shell.

browser/config/mozconfigs/win64/common-opt

@@ -25,7 +25,7 @@ export MOZILLA_OFFICIAL=1
 
 export MOZ_TELEMETRY_REPORTING=1
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 . $topsrcdir/build/win64/mozconfig.vs2013

browser/config/mozconfigs/win64/debug

@@ -20,7 +20,7 @@ ac_add_options --with-google-oauth-api-keyfile=${_google_oauth_api_keyfile}
 # Needed to enable breakpad in application.ini
 export MOZILLA_OFFICIAL=1
 
-# Treat warnings as errors in directories with FAIL_ON_WARNINGS.
+# Treat warnings as errors (modulo ALLOW_COMPILER_WARNINGS).
 ac_add_options --enable-warnings-as-errors
 
 # Package js shell.

build/stlport/moz.build

@@ -69,3 +69,5 @@ if CONFIG['GNU_CXX']:
 # Force to build a static library, instead of a fake library, without
 # installing it in dist/lib.
 NO_EXPAND_LIBS = True
+
+ALLOW_COMPILER_WARNINGS = True

caps/moz.build

@@ -51,5 +51,3 @@ LOCAL_INCLUDES += [
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'
-
-FAIL_ON_WARNINGS = True

chrome/moz.build

@@ -40,5 +40,3 @@ LOCAL_INCLUDES += [
 
 if CONFIG['MOZ_ENABLE_GTK']:
     CXXFLAGS += CONFIG['TK_CFLAGS']
-
-FAIL_ON_WARNINGS = True

config/config.mk

@@ -359,25 +359,27 @@ endif # CROSS_COMPILE
 CFLAGS += $(MOZ_FRAMEPTR_FLAGS)
 CXXFLAGS += $(MOZ_FRAMEPTR_FLAGS)
 
-# Check for FAIL_ON_WARNINGS (Shorthand for Makefiles to request that we use
-# the 'warnings as errors' compile flags)
+# Check for ALLOW_COMPILER_WARNINGS (shorthand for Makefiles to request that we
+# *don't* use the warnings-as-errors compile flags)
 
-# NOTE: First, we clear FAIL_ON_WARNINGS[_DEBUG] if we're doing a Windows PGO
-# build, since WARNINGS_AS_ERRORS has been suspected of causing isuses in that
-# situation. (See bug 437002.)
+# Don't use warnings-as-errors in Windows PGO builds because it is suspected of
+# causing problems in that situation. (See bug 437002.)
 ifeq (WINNT_1,$(OS_ARCH)_$(MOZ_PROFILE_GENERATE)$(MOZ_PROFILE_USE))
-FAIL_ON_WARNINGS=
+ALLOW_COMPILER_WARNINGS=1
 endif # WINNT && (MOS_PROFILE_GENERATE ^ MOZ_PROFILE_USE)
 
-# Check for normal version of flag, and add WARNINGS_AS_ERRORS if it's set to 1.
-ifdef FAIL_ON_WARNINGS
-# Never treat warnings as errors in clang-cl, because it warns about many more
+# Don't use warnings-as-errors in clang-cl because it warns about many more
 # things than MSVC does.
-ifndef CLANG_CL
+ifdef CLANG_CL
+ALLOW_COMPILER_WARNINGS=1
+endif # CLANG_CL
+
+# Use warnings-as-errors if ALLOW_COMPILER_WARNINGS is not set to 1 (which
+# includes the case where it's undefined).
+ifneq (1,$(ALLOW_COMPILER_WARNINGS))
 CXXFLAGS += $(WARNINGS_AS_ERRORS)
 CFLAGS   += $(WARNINGS_AS_ERRORS)
-endif # CLANG_CL
-endif # FAIL_ON_WARNINGS
+endif # ALLOW_COMPILER_WARNINGS
 
 ifeq ($(OS_ARCH)_$(GNU_CC),WINNT_)
 #// Currently, unless USE_STATIC_LIBS is defined, the multithreaded

config/external/nss/moz.build

@@ -45,3 +45,6 @@ else:
         '/security/nss/lib/util/nssutil3',
         'sqlite',
     ]
+
+# XXX: We should fix these warnings.
+ALLOW_COMPILER_WARNINGS = True

db/sqlite3/src/moz.build

@@ -9,6 +9,8 @@ EXPORTS += [
     'sqlite3.h',
 ]
 
+ALLOW_COMPILER_WARNINGS = True
+
 if CONFIG['MOZ_FOLD_LIBS']:
     # When folding libraries, sqlite is actually in the nss library.
     FINAL_LIBRARY = 'nss'

docshell/base/moz.build

@@ -65,8 +65,6 @@ UNIFIED_SOURCES += [
     'SerializedLoadContext.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

docshell/base/timeline/moz.build

@@ -20,8 +20,6 @@ UNIFIED_SOURCES += [
     'TimelineMarker.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 FINAL_LIBRARY = 'xul'
 
 LOCAL_INCLUDES += [

docshell/build/moz.build

@@ -27,5 +27,3 @@ FINAL_LIBRARY = 'xul'
 
 if CONFIG['GNU_CXX']:
     CXXFLAGS += ['-Wshadow']
-
-FAIL_ON_WARNINGS = True

docshell/shistory/moz.build

@@ -27,8 +27,6 @@ UNIFIED_SOURCES += [
     'nsSHTransaction.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '/docshell/base',
 ]

dom/activities/moz.build

@@ -31,8 +31,6 @@ EXTRA_JS_MODULES += [
     'ActivitiesServiceFilter.jsm',
 ]
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '/dom/base',
 ]

dom/alarm/moz.build

@@ -28,8 +28,6 @@ EXTRA_JS_MODULES += [
     'AlarmService.jsm',
 ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

dom/animation/moz.build

@@ -30,6 +30,4 @@ UNIFIED_SOURCES += [
     'PendingAnimationTracker.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 FINAL_LIBRARY = 'xul'

dom/apps/moz.build

@@ -54,8 +54,6 @@ EXTRA_PP_JS_MODULES += [
 if CONFIG['GNU_CXX']:
     CXXFLAGS += ['-Wshadow']
 
-FAIL_ON_WARNINGS = True
-
 FINAL_LIBRARY = 'xul'
 
 LOCAL_INCLUDES += [

dom/archivereader/moz.build

@@ -24,8 +24,6 @@ UNIFIED_SOURCES += [
 if CONFIG['GNU_CXX']:
     CXXFLAGS += ['-Wshadow']
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '../base',
 ]

dom/asmjscache/moz.build

@@ -16,8 +16,6 @@ IPDL_SOURCES += [
     'PAsmJSCacheEntry.ipdl'
 ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

dom/audiochannel/moz.build

@@ -21,8 +21,6 @@ UNIFIED_SOURCES += [
     'AudioChannelService.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

dom/base/moz.build

@@ -409,8 +409,6 @@ EXTRA_JS_MODULES += [
     'IndexedDBHelper.jsm',
 ]
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '../battery',
     '../bluetooth/common',

dom/battery/moz.build

@@ -13,8 +13,6 @@ SOURCES += [
     'BatteryManager.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

dom/bindings/moz.build

@@ -39,8 +39,6 @@ EXPORTS.mozilla.dom += [
     'UnionMember.h',
 ]
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '/dom/base',
     '/dom/battery',

dom/bluetooth/moz.build

@@ -152,8 +152,6 @@ IPDL_SOURCES += [
     'ipc/PBluetoothRequest.ipdl'
 ]
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '../base',
     '../network',

dom/broadcastchannel/moz.build

@@ -29,4 +29,3 @@ MOCHITEST_CHROME_MANIFESTS += ['tests/chrome.ini']
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'
-FAIL_ON_WARNINGS = True

dom/browser-element/moz.build

@@ -32,8 +32,6 @@ EXTRA_JS_MODULES += [
     'BrowserElementPromptService.jsm',
 ]
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '../bluetooth',
     '/dom/html',

dom/cache/moz.build

@@ -87,8 +87,6 @@ LOCAL_INCLUDES += [
     '../workers',
 ]
 
-FAIL_ON_WARNINGS = True
-
 FINAL_LIBRARY = 'xul'
 
 MOCHITEST_MANIFESTS += [

dom/camera/moz.build

@@ -61,8 +61,6 @@ else:
         'FallbackCameraManager.cpp',
     ]
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '../base',
     '/media/libyuv/include',

dom/canvas/compiledtest/moz.build

@@ -11,8 +11,6 @@ GeckoCppUnitTests([
 if CONFIG['GNU_CXX']:
     CXXFLAGS += ['-Wshadow']
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '../',
 ]

dom/canvas/moz.build

@@ -143,8 +143,6 @@ LOCAL_INCLUDES += [
     '/js/xpconnect/wrappers',
 ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

dom/cellbroadcast/moz.build

@@ -35,6 +35,4 @@ IPDL_SOURCES += [
 
 include('/ipc/chromium/chromium-config.mozbuild')
 
-FAIL_ON_WARNINGS = True
-
 FINAL_LIBRARY = 'xul'

dom/crypto/moz.build

@@ -19,8 +19,6 @@ UNIFIED_SOURCES += [
     'WebCryptoTask.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

dom/datastore/moz.build

@@ -45,4 +45,3 @@ MOCHITEST_MANIFESTS += ['tests/mochitest.ini']
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'
-FAIL_ON_WARNINGS = True

dom/devicestorage/moz.build

@@ -32,8 +32,6 @@ IPDL_SOURCES += [
     'PDeviceStorageRequest.ipdl',
 ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

dom/encoding/moz.build

@@ -18,8 +18,6 @@ UNIFIED_SOURCES += [
     'TextEncoder.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 FINAL_LIBRARY = 'xul'
 LOCAL_INCLUDES += [
     '/intl/locale',

dom/events/moz.build

@@ -124,8 +124,6 @@ SOURCES += [
 if CONFIG['MOZ_WEBSPEECH']:
     UNIFIED_SOURCES += ['SpeechRecognitionError.cpp']
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

dom/fetch/moz.build

@@ -44,7 +44,6 @@ LOCAL_INCLUDES += [
     '/netwerk/protocol/http',
 ]
 
-FAIL_ON_WARNINGS = True
 FINAL_LIBRARY = 'xul'
 
 include('/ipc/chromium/chromium-config.mozbuild')

dom/filehandle/moz.build

@@ -26,8 +26,6 @@ UNIFIED_SOURCES += [
     'MutableFile.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 LOCAL_INCLUDES += [

dom/filesystem/moz.build

@@ -42,5 +42,5 @@ LOCAL_INCLUDES += [
     '/dom/base',
 ]
 
-if not CONFIG['CLANG_CXX']:
-    FAIL_ON_WARNINGS = True
+if CONFIG['CLANG_CXX']:
+    ALLOW_COMPILER_WARNINGS = True

dom/fmradio/ipc/moz.build

@@ -18,8 +18,6 @@ UNIFIED_SOURCES += [
     'FMRadioRequestParent.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '/dom/base',
 ]

dom/fmradio/moz.build

@@ -27,8 +27,6 @@ IPDL_SOURCES += [
     'ipc/PFMRadioRequest.ipdl',
 ]
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '../base',
     '../system/gonk',

dom/gamepad/moz.build

@@ -43,8 +43,6 @@ elif CONFIG['MOZ_GAMEPAD_BACKEND'] == 'android':
         'android/AndroidGamepad.cpp'
     ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

dom/geolocation/moz.build

@@ -21,8 +21,6 @@ UNIFIED_SOURCES += [
     'nsGeoPosition.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

dom/html/moz.build

@@ -222,8 +222,6 @@ EXTRA_COMPONENTS += [
     'htmlMenuBuilder.manifest'
 ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 LOCAL_INCLUDES += [

dom/icc/moz.build

@@ -48,8 +48,6 @@ if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gonk' and CONFIG['MOZ_B2G_RIL']:
         'gonk/StkCmdFactory.manifest'
     ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

dom/indexedDB/moz.build

@@ -87,8 +87,6 @@ include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '/db/sqlite3/src',
     '/dom/base',

dom/inputport/moz.build

@@ -44,5 +44,3 @@ XPCSHELL_TESTS_MANIFESTS += ['test/xpcshell/xpcshell.ini']
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'
-
-FAIL_ON_WARNINGS = True

dom/ipc/moz.build

@@ -112,8 +112,6 @@ IPDL_SOURCES += [
     'PTabContext.ipdlh',
 ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

dom/json/moz.build

@@ -12,8 +12,6 @@ UNIFIED_SOURCES += [
     'nsJSON.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '/dom/base',
 ]

dom/jsurl/moz.build

@@ -12,8 +12,6 @@ UNIFIED_SOURCES += [
     'nsJSProtocolHandler.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     "/dom/base",
     "/netwerk/base",

dom/mathml/moz.build

@@ -9,8 +9,6 @@ UNIFIED_SOURCES += [
     'nsMathMLElementFactory.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'

dom/media/android/moz.build

@@ -25,5 +25,3 @@ LOCAL_INCLUDES += [
 ]
 
 FINAL_LIBRARY = 'xul'
-
-FAIL_ON_WARNINGS = True

dom/media/apple/moz.build

@@ -14,8 +14,6 @@ UNIFIED_SOURCES += [
     'AppleMP3Reader.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 FINAL_LIBRARY = 'xul'
 
 OS_LIBS += ['-framework AudioToolbox']

dom/media/bridge/moz.build

@@ -26,5 +26,3 @@ LOCAL_INCLUDES += [
 ]
 
 FINAL_LIBRARY = 'xul'
-
-FAIL_ON_WARNINGS = True

dom/media/compiledtest/moz.build

@@ -9,8 +9,6 @@ GeckoCppUnitTests([
     'TestAudioMixer'
 ])
 
-FAIL_ON_WARNINGS = True
-
 LOCAL_INCLUDES += [
     '..',
 ]

dom/media/directshow/moz.build

@@ -35,8 +35,6 @@ if not CONFIG['MOZ_WEBRTC']:
         '/media/webrtc/trunk/webrtc/modules/video_capture/windows/MediaType.cpp',
     ]
 
-FAIL_ON_WARNINGS = True
-
 FINAL_LIBRARY = 'xul'
 LOCAL_INCLUDES += [
     '/media/webrtc/trunk/webrtc/modules/video_capture/windows',

dom/media/eme/moz.build

@@ -48,5 +48,3 @@ if CONFIG['OS_ARCH'] == 'WINNT':
     ]
 
 FINAL_LIBRARY = 'xul'
-
-FAIL_ON_WARNINGS = True

dom/media/encoder/fmp4_muxer/moz.build

@@ -18,6 +18,4 @@ UNIFIED_SOURCES += [
     'MP4ESDS.cpp',
 ]
 
-FAIL_ON_WARNINGS = True
-
 FINAL_LIBRARY = 'xul'

dom/media/encoder/moz.build

@@ -38,8 +38,6 @@ if CONFIG['MOZ_WEBM_ENCODER']:
     ]
     LOCAL_INCLUDES += ['/media/libyuv/include']
 
-FAIL_ON_WARNINGS = True
-
 FINAL_LIBRARY = 'xul'
 
 # These includes are from Android JB, for use of MediaCodec.

dom/media/fmp4/moz.build

@@ -21,7 +21,5 @@ SOURCES += [
 
 FINAL_LIBRARY = 'xul'
 
-FAIL_ON_WARNINGS = True
-
 if CONFIG['MOZ_GONK_MEDIACODEC']:
     DEFINES['MOZ_GONK_MEDIACODEC'] = True

dom/media/gmp-plugin-openh264/moz.build

@@ -22,5 +22,3 @@ USE_STATIC_LIBS = True
 NO_VISIBILITY_FLAGS = True
 # Don't use STL wrappers; this isn't Gecko code
 DISABLE_STL_WRAPPING = True
-
-FAIL_ON_WARNINGS = True

dom/media/gmp-plugin/moz.build

@@ -24,5 +24,3 @@ USE_STATIC_LIBS = True
 NO_VISIBILITY_FLAGS = True
 # Don't use STL wrappers; this isn't Gecko code
 DISABLE_STL_WRAPPING = True
-
-FAIL_ON_WARNINGS = True