fix for #23661, we were being overly aggressive about hiding controls using hidefor=

mailnews/base/prefs/resources/content/am-server.js

@@ -66,7 +66,7 @@ function hideShowControls(serverType)
 
         // skip generic server/identity things
         var hideFor = control.getAttribute("hidefor");
-        if (!hideFor &&
+        if ((!hideFor || hideFor == "") &&
             (controlType == "server" ||
              controlType == "identity")) continue;
 
@@ -76,7 +76,9 @@ function hideShowControls(serverType)
 
         // hide unsupported server type
 
-        if (controlType != serverType ||
+        if ((controlType != "server" &&
+             controlType != "identity" &&
+             controlType != serverType) ||
             hideFor == serverType) {
             box.setAttribute("hidden", "true");
         }

mailnews/base/prefs/resources/content/am-server.xul

@@ -47,10 +47,10 @@
   <box id="serverPrefContainer" orient="vertical">
 
   <checkbox wsm_persist="true" id="server.isSecure" value="&isSecure.label;"/>
-
+<!--
   <checkbox wsm_persist="true" id="server.rememberPassword" hidefor="nntp"
             value="&savePassword.label;"/>
-
+-->
   <box orient="horizontal">
     <checkbox wsm_persist="true" id="server.doBiff" value="&biffStart.label;"/>
     <textfield wsm_persist="true" id="server.biffMinutes" size="3"/>